Promote ADR-0025 from Draft (design note) to Accepted with the
architectural home decision reversed: rotor admissibility lives at
the same generation/propagation seam as ADR-0024's destination
check — in a sibling-but-separate module
`generate/rotor_admissibility.py` — NOT in `algebra/versor.py` or
`field/propagate.py`.
Algebra rejected because admissibility is a pack-semantic test, not
a closure invariant; placing it there couples algebra to pack state
and creates structural temptation toward grade-projection repair
(CLAUDE.md §Normalization Rules forbids). field/propagate rejected
as a forbidden normalization site even when framed as precondition
guard. The clean answer is generation-side, in its own file:
endpoint admissibility (token-side, blade) and rotor admissibility
(rotor-side, frame) compose at the same seam while remaining
conceptually separable.
New module generate/rotor_admissibility.py:
RotorVerdict — admit/reject + score + region_label + reason
check_rotor_admissibility(region, *, field_current, rotor)
-> RotorVerdict
Pure semantic check:
F' = versor_apply(V, F_current)
score = cga_inner(F', region.frame_versor)
admit iff score > 0 (basic positivity in frame half-space)
No state mutation, no closure enforcement (algebra's job).
region.frame_versor is None → trivial admit (back-compat).
RefusalReason extended:
INNER_LOOP_EXHAUSTION — destination-side (ADR-0024 / ADR-0026)
ROTOR_REJECTION — rotor-side (this ADR)
The two reasons let the trace name the axis that ran out without a
parallel exception type. InnerLoopExhaustion(ValueError) hierarchy
unchanged; back-compat preserved.
Wiring in generate/stream.py:
threshold mode per-candidate rotor check after destination admit;
reject → log rotor score, retry next candidate;
exhaustion routes reason to ROTOR_REJECTION iff
any rotor rejection occurred in the step
margin mode rotor check on the top-ranked admissible candidate;
reject → immediate InnerLoopExhaustion(
reason=ROTOR_REJECTION) carrying the destination
ranking + the rejected rotor's score
Phase 4 keeps positivity (score > 0), not margin, on the rotor side.
No cross-case calibration evidence to inform a rotor-margin constant
yet; promoting to ranked-with-margin awaits Phase 5 diversified-
families evidence. Destination-side margin (ADR-0026) is unchanged.
Teaching boundary closed at Stance A — strictly hygiene-only.
Rotor rejections are deterministic geometric outcomes, not reviewed
teaching examples. CLAUDE.md §Teaching Safety forbids parallel
correction paths; entangling rotor rejection with reviewed teaching
would create one. Confirmed in ADR-0025 §"Teaching boundary".
Acceptance evidence (tests/test_rotor_admissibility.py, 11 passing):
No-frame back-compat — frame_versor=None tokens identical to
Phase 3 baseline
Admit when aligned — frame_versor=seed direction admits
seed→destination rotor
Refuse with named axis — orthogonal frame raises
InnerLoopExhaustion(reason=ROTOR_REJECTION); threshold mode
also routes reason correctly
versor_condition < 1e-6 preserved on admitted rotors
Deterministic replay — 5 reruns identical for both admitted and
refused turns
Suite results:
full: 1048 passed, 2 skipped (+11 new rotor tests)
docs/runtime_contracts.md updated with "Rotor admissibility contract"
subsection documenting the seam, the algorithm, and the refusal
taxonomy.
Architectural invariants preserved:
no new code in algebra/versor.py, field/propagate.py, vault/store.py
no approximate recall, no cosine similarity, no HNSW/ANN
no hot-path repair; check is pure typed-verdict
InnerLoopExhaustion(ValueError) hierarchy unchanged
13 KiB
Runtime Contracts
This document freezes the runtime contracts used by chat, telemetry, memory, and future teaching work. It exists to prevent contract drift between tests, runtime code, and future cognitive pipeline work.
Field invariant
CORE state is a versor field. Runtime code must preserve the core closure contract:
versor_condition(F) < 1e-6
If a propagation path violates this invariant, fix the operator path or the explicit closure boundary that owns the transition. Do not hide violations by changing tests or silently downgrading the invariant.
ChatResponse contract
ChatResponse.surface- The selected user-facing response. This is the exact string returned by
ChatRuntime.respond()and should match what the user receives. ChatResponse.walk_surface- The manifold/token-walk evidence surface. It is trace evidence for what the field traversal produced. It is not necessarily the user-facing response.
ChatResponse.articulation_surface- The proposition/realizer surface. This is the structured linguistic realization of the current proposition or proposition graph.
Current selection policy:
surface = articulation_surface (when no unknown-domain gate fired)
surface = _UNKNOWN_DOMAIN_SURFACE (when the gate fired)
walk_surface = retained telemetry/evidence (always)
Unknown-domain gate honour
When vault/decompose.py::UnknownDomainGate fires, ChatRuntime returns
the safety stub _UNKNOWN_DOMAIN_SURFACE ("I don't have field
coordinates for that yet.") and vault_hits == 0.
CognitiveTurnPipeline honours that stub: the user-facing surface
remains the gate's response and is not overridden by the realizer's
fallback articulation. The realizer's surface always survives in
walk_surface as evidence — only the user-facing selection is
gated. This closes evals/calibration/gaps.md Finding 2.
Future realizer work may change the selection policy, but must update this document and the contract tests in the same PR.
Refusal contract (ADR-0024 Phase 2)
When the inner-loop admissibility check leaves no admissible destination
for the next step, the generation walk in generate/stream.py raises
generate.exhaustion.InnerLoopExhaustion, a typed subclass of
ValueError carrying:
reason : RefusalReason (machine-readable taxonomy)
region_label : str (which AdmissibilityRegion blocked)
step_index : int (-1 = pre-walk empty intersection;
>=0 = in-walk per-step exhaustion)
rejected_attempts : tuple[(int, str, float), ...] (per-step evidence)
Reason codes are minimal in Phase 2: a single INNER_LOOP_EXHAUSTION
covers both raise sites. Phase 4 (rotor-frame admissibility, ADR-0025)
is expected to add a second reason for rotor exhaustion.
CognitiveTurnResult.refusal_reason carries the stable string value of
the RefusalReason when a turn refuses, and the empty string otherwise.
compute_trace_hash folds refusal_reason into the payload only when
non-empty, preserving byte-identical hashes for non-refused turns
relative to pre-Phase-2 (determinism invariant). When the field is
non-empty, it becomes load-bearing in replay equality.
Backward compatibility: InnerLoopExhaustion is a ValueError, so
every pre-Phase-2 except ValueError handler in chat/runtime.py,
eval lanes, and tests continues to catch it without modification.
Residual silent path (out of scope for Phase 2, future ADR):
ChatRuntime.respond() and arespond() still convert any ValueError
to the empty string for their public str return contract, so a real
turn that refuses today produces surface == "" with
refusal_reason == "" — the typed evidence is unread between the
raise site and the result. The plumbing on CognitiveTurnResult,
compute_trace_hash, and CognitiveTurnPipeline is in place so a
future ADR can wire materialisation (e.g. propagate the typed
exception to ChatResponse.refusal_reason or catch at the pipeline
seam) without re-deriving the contract.
Rotor admissibility contract (ADR-0025 / Phase 4)
The destination-side admissibility documented above (token-side blade
alignment, ADR-0024 / Phase 3) is complemented by a rotor-side check:
when a region carries a non-null frame_versor, the inner loop
additionally verifies that the rotor's effect on the current field
stays within the frame's admissible cone:
F' = versor_apply(V, F_current)
score = cga_inner(F', frame_versor)
admit iff score > 0
generate.rotor_admissibility.check_rotor_admissibility performs
this pure semantic check. It lives at the same generation/propagation
seam as the inner loop — in generate/rotor_admissibility.py, a
sibling-but-separate module to generate/admissibility.py — not
in algebra/versor.py (admissibility is a pack-semantic test, not a
closure invariant) and not in field/propagate.py (forbidden
normalization/repair site). The placement is the load-bearing
architectural decision in ADR-0025.
Refusal is materialised through the same InnerLoopExhaustion
mechanism as destination-side refusal, but with
RefusalReason.ROTOR_REJECTION instead of INNER_LOOP_EXHAUSTION,
so the trace names the axis that ran out. In threshold mode, a step
that exhausts after any rotor rejection is reported under
ROTOR_REJECTION; pure destination exhaustion stays
INNER_LOOP_EXHAUSTION. In margin mode, the rotor check runs on the
top-ranked admissible candidate after destination margin admits; on
rotor refusal the typed exception carries the full destination
ranking plus the rejected rotor's score as evidence.
The versor_condition(F) < 1e-6 invariant remains the algebra
layer's responsibility on actual propagation. check_rotor_admissibility
does not mutate field state and does not enforce closure — it only
asks whether applying V to F would leave the field in the
frame's half-space.
TurnEvent contract
TurnEvent.surface- Exact emitted user-facing response for the turn.
TurnEvent.walk_surface- Exact manifold/token-walk evidence surface for the turn.
TurnEvent.articulation_surface- Exact proposition/realizer surface for the turn.
TurnEvent.vault_hits- Actual count of recall hits applied during generation. Never hardcode this.
TurnEvent.flagged- Mirrors
IdentityScore.flaggedfor filtering and trace inspection.
Identity contract
Identity checks are telemetry/gating signals. A flagged identity score must not silently erase useful generation unless an explicit hard-block policy is configured and tested.
Canonical call style:
IdentityCheck().check(trajectory, manifold)
Legacy constructor injection:
IdentityCheck(manifold=manifold).check(trajectory)
is supported temporarily and emits DeprecationWarning. New code must not use
it.
Memory and teaching contract
Session memory can be immediate and local to the running context.
Reviewed memory must be explicit: user corrections or teaching examples become reviewed memory only through the reviewed teaching loop.
Pack mutation is proposal-only until reviewed. Runtime correction capture must not directly rewrite language packs, frames, identity axes, or operator code.
Identity manifold mutation by user prompt or correction is forbidden.
Testing policy
Tests should protect load-bearing behavior:
- versor closure
- deterministic replay
- runtime response/telemetry contracts
- memory correctness
- identity protection
- teaching/correction safety
- articulation contract
Avoid tests that preserve stale constructors, private helper shapes, or exact formatting that is not part of a documented contract.
Epistemic surface (ADR-0021)
CORE exposes a typed epistemic_status on the teaching and lexicon
surfaces. The status is a position in the revision graph, not a
source-trust tier:
| Status | Meaning |
|---|---|
COHERENT |
Fits current field geometry; no incoherence with reviewed claims detected at admission. |
CONTESTED |
Incoherent with at least one reviewed claim; review pending; not load-bearing. |
SPECULATIVE |
Proposed; not yet reviewed for coherence; admissible only as a candidate. |
FALSIFIED |
Incoherent under accumulated evidence; eligible for Stage-3 inversion; retained. |
Non-hardening invariant
No reviewed claim or proposition-graph edge ever becomes unrevisable.
No final, frozen, axiom, or permanent flag exists or may be
added on the runtime data model. The closest such property in the
architecture is the mathematical closure check
versor_condition(F) < 1e-6 — never an epistemic seal on a claim.
The invariant is enforced by tests/test_epistemic_invariants.py.
Curator review rule
epistemic_status transitions are computed from coherence with the
existing reviewed field — not asserted by source authority. At v1 the
judgment is curator-mediated, with one rule:
The curator's only admissible reasoning is geometric: does the claim cohere with already-reviewed claims, or does it produce incoherence? Source credentials, popularity, or institutional position must not be invoked as justification.
Schema surfaces
| Surface | Field | Default at creation |
|---|---|---|
teaching.PackMutationProposal |
epistemic_status: EpistemicStatus |
SPECULATIVE |
teaching.ReviewedTeachingExample |
epistemic_status: EpistemicStatus |
SPECULATIVE |
language_packs.schema.LexicalEntry |
epistemic_status: str |
"coherent" (seed) |
core.cognition.trace.compute_trace_hash |
teaching_epistemic_status: str |
"" if no proposal |
Promotion of a proposal's status uses the immutable updater
PackMutationProposal.with_status(...) — original is never mutated.
The status of the load-bearing proposal in a turn is folded into
trace_hash so replay detects when a downstream surface was produced
under a different epistemic frame than at the time of recall.
Test organization target
Future test moves should follow this taxonomy:
| Area | Destination |
|---|---|
| versor closure, holonomy, motors, null cone, energy physics | tests/algebra/ or tests/physics/ |
| chat runtime, config, async runtime, identity gate telemetry | tests/runtime/ |
| articulation, proposition, surface assembly, future pipeline | tests/cognition/ |
| correction capture, reviewed memory, consolidation | tests/teaching/ |
| language pack loading and seed pack invariants | tests/packs/ |
Do not reorganize tests as a standalone churn PR unless it directly reduces contract ambiguity or unlocks a cognitive subsystem.
Formation trust boundaries
The Formation Pipeline (see docs/formation_pipeline_plan.md) introduces six
trust boundaries between the world and the manifold. Every boundary has a
content-addressed input and output; every rejection produces an audit record.
No silent failures.
| # | Boundary | Input | Output | Trust contract |
|---|---|---|---|---|
| 1 | Mining → Smelting | URLs / files | OreBundle |
Untrusted text in; untrusted entries out. No code execution from sources; no dynamic imports; source URLs sandboxed; SHA-256 captured per entry. |
| 2 | Smelting → Forge | OreBundle + extracted candidates |
Candidate* lists |
Untrusted candidates in. The Forge is the only validator. Identity-override patterns and path-traversal in source SHAs are rejected at the Forge, not here. |
| 3 | Forge → Compose | Candidate* lists |
ValidatedTripleSet |
Every candidate runs through teaching.relation_parse.parse_triple, identity-axis screening, source allow-list, pack collision check, and the cross-reference rule. Output entries carry EpistemicStatus.SPECULATIVE. No pack mutation. |
| 4 | Compose → Compile/Run | ValidatedTripleSet |
CourseYAML → FormationPlan |
Deterministic, byte-stable composition. No mutation of the language pack manifest. |
| 5 | Run → Ratify | FormationPlan |
list[CognitiveTurnResult] |
The runner is a thin shim over CognitiveTurnPipeline.run(). It cannot invent operators; it can only invoke existing ones. Hard-halts on versor_condition(F) >= 1e-6. No identity-manifold mutation, ever. |
| 6 | Ratify → Promote | MasteryReport (self-sealed) |
reviewed teaching apply | Promotion requires a self-sealed MasteryReport whose SHA verifies, whose prerequisites are present in the MasteredCoursesIndex, and whose triples are submitted through teaching/review.py — the existing reviewed apply path. ADR-0021's "one mutation path" invariant is preserved. |
Content-addressing rules (binding across the whole pipeline):
- All hashed payloads are canonical JSON (sorted keys, tight separators, UTF-8, no NaN/Infinity). Floats are forbidden in hashed payloads; encode numerics as strings or integers.
MasteryReport.report_sha256is self-sealing: SHA over the payload withreport_sha256blanked, then written back into the field. Verifiers reverse the process.- No pickle. Pickle defeats replay determinism and is a code-execution surface.
See formation/hashing.py, formation/cache.py, and formation/forge.py
for the implementation of each rule.