Consolidating ratification of the GSM8K design of record. Ratify the built comprehension/derivation substrate, freeze the serving regex recognizer/ injector path to lexemes + refusal-only, pin Phase 5b execution to WIRING -> COMPOSITION -> LEXICON. - ADR-0207: new consolidating decision (Accepted, ratified 2026-06-03). Supersedes ADR-0163 §Phase B-E + ADR-0136 regex sentence-template prescriptions. Freeze + wrong=0 gates (22-case corpus + sealed 1,319). - ADR-0164/0165/0174/0178/0179: -> Accepted (ratified by ADR-0207, 2026-06-03). 0164 keeps its implementation clause (Phase 1+2 shipped; remainder per §5) so Accepted != fully built. - composition_validation/v1: 20 -> 22 cases (2nd R4/R5 positives, dataset-sourced golds), +contract invariants 6-7, +dataset-gold test. Baseline 4/18/0; 47 passed. - docs/analysis: extraction-richness audit (read-only) reconciling ADR-0179 to the tree (EX-1/2/4/5/6 landed; EX-3 deferred). Non-serving (evals/docs/tests only). train_sample 6/44/0 unchanged; no-ref <N> times hazard stays refused. GB3b/0136 untouched.
43 KiB
ADR-0174 — Held-Hypothesis Comprehension with Lookback and In-Loop Contemplation
Status: Accepted (ratified by ADR-0207, 2026-06-03) Date: 2026-05-28 Author: Shay Anchor: thesis-decoding-not-generating Parent: ADR-0164 — Incremental Comprehension Reader Companions: ADR-0165 — Regex Scope Rule, ADR-0163 — Path to GSM8K mastery, ADR-0150/0152/0155/0161 — Contemplation / HITL corridor, ADR-0170 — Injector Contract Widening, ADR-0172 — Math-Corpus Decomposition Extends: ADR-0164 (lexicon, categories, deterministic per-token reading — all preserved) Deprecates:
- The per-category injector dispatch table at
generate/recognizer_anchor_inject.py:233(ADR-0170 W2 and subsequent D.2.x extensions) as the runtime admission path. The injectors become hypothesis-emitters within the held-hypothesis reader; they no longer route admission via category lookup. - The legacy regex parser at
generate/math_parser.pyas a parallel runtime path. It survives only as the offline measurement-comparison baseline (--legacy-parserflag per CLEANUP-C2 brief).
Context — what ADR-0164 shipped, why the score hasn't moved
ADR-0164 correctly diagnosed the regex sentence-template trap and prescribed the right substrate: an operational lexicon, a closed category set, a deterministic shift-reduce reader over categories. Phases 1 and 2 shipped. The reader is wired (generate/comprehension/lifecycle.py, generate/comprehension/state.py, 2,700 lines combined) and the flag is on in the current train_sample run (use_reader: true).
The eval is unchanged: correct=3, refused=47, wrong=0 on evals/gsm8k_math/train_sample/v1, byte-identical to the regex-only baseline. Reader-trace inspection confirms the reader fires on every problem and produces a ReaderRefusal on the first unknown-word or unexpected-category token, then falls through to the regex pipeline which also refuses.
Three causes, in priority order:
-
All-or-nothing refusal at the token level.
apply_word(state, ps, token)returnsstate | ReaderRefusal. The first unknown word or unexpected category collapses the entire comprehension. There is no state representing "I do not yet know what role this token plays; I will hold the question open and continue reading." A natural-language reader without held hypotheses cannot read natural language. -
No lookback re-evaluation. Even when
apply_wordsucceeds, the commitment is final. The reader cannot undo a category assignment when a later token reveals the prior commitment was wrong. "She studied for 2 hours on Wednesday and three times as long on Thursday" — the temporal-aggregation reading of "for 2 hours" should be open until the second clause arrives; the reader currently locks it as a quantity at the first sentence boundary. -
Recovery lives offline. When the reader refuses, the path to learning the missing word is: refusal → audit row → contemplation lane (offline) → workbench → HITL ratify → next session. This is correct for durable learning but wrong for the current problem. A reader that cannot ask "what would I need to know to finish this read" within the read itself cannot solve problems whose answer is one inference away.
The result: each accepted category, each new lexicon entry, each new D.2.x injector lifts the eval by 0–2 cases. The correct count rises monotonically and slowly; the architecture overfits to GSM8K sentence shapes one shape at a time. This is the library-of-founds trap the project thesis explicitly forbids.
Diagnosis — single-committed state cannot model partial understanding
A natural-language reader observes a token, hypothesizes its role given everything else, and revises that hypothesis as more tokens arrive. The hypothesis space narrows with reading. At sentence end (or problem end), the surviving hypothesis is admitted.
ADR-0164's reader is structurally single-committed: at every token, exactly one ProblemReadingState exists. Disambiguation must complete at the moment of token consumption, because there is nowhere to defer an interpretation. When deferral is impossible, the reader compensates with strict expectation-matching, and when expectation matching fails, the reader refuses.
The same problem manifests three ways:
- Ambiguous categories must commit immediately. "Tina makes" —
makescould open anaccumulation_verbframe, anaggregate_modifier(as in "makes total"), or a copular construction ("makes Tina happy"). The reader must pick one. Picking wrong means refusing later; picking right means refusing on the next ambiguous token. - Unknown words refuse rather than narrow. A token absent from the lexicon emits
ReaderRefusal(unknown_word, position). The legitimate alternative — "this is an unknown word at position N; my hypothesis set narrows to interpretations that don't depend on this word's category" — is not representable. - End-of-sentence finalization is binary.
finalize(state) → graph | Refusal. There is no "I have two complete hypotheses; let downstream constraints eliminate one." The held-hypothesis behavior already lives at the candidate-graph layer (Cartesian product over per-sentence choices + constraint elimination via_initial_admissible/roundtrip_admissible); it should live at the reader.
ADR-0164's apply_word(state, ps, token) → state | Refusal is the right shape but the wrong cardinality. Promote it to apply_word(state, ps, token) → state' where state'.open_hypotheses is a small ranked set, and refusal is what happens when the set becomes empty.
Decision — held-hypothesis comprehension
Replace single-committed ProblemReadingState with a held-hypothesis model in which the reader carries a small ranked set of open interpretations and applies three operators per token:
- EMIT — the token extends every compatible hypothesis (existing reader behavior, but applied to each hypothesis in the set).
- ELIMINATE — hypotheses whose constraints are violated by the new token are removed. Constraints are the existing admissibility predicates (
_initial_admissible,roundtrip_admissible, unit-grounding, verb-kind whitelist) applied to the in-flight hypothesis, not just the finalized candidate. - HOLD — when the token does not commit a category but narrows the role for some hypotheses, those hypotheses survive at lower confidence; uncommitted hypotheses are retained.
At sentence end (and problem end), the surviving hypothesis set drives admission:
- |surviving| = 0 → refuse with the union of elimination reasons.
- |surviving| = 1 → admit (existing graph emission path, unchanged).
- |surviving| ≥ 2 → invoke in-loop contemplation to synthesize an elimination sub-question; on resolution, eliminate further; if still ≥ 2 at problem end, refuse with
ambiguous: <N> surviving interpretations(preserves wrong = 0).
Four components
1. Held-hypothesis state (immutable, frozen-dataclass)
ProblemReadingState:
entities: tuple[EntityRef, ...]
quantities: tuple[QuantityRef, ...]
open_hypotheses: tuple[Hypothesis, ...] # NEW — ranked, ≤ HYPOTHESIS_CAP
pronoun_history: tuple[PronounRef, ...]
sentence_index: int
source_text_offset: int
unknown_held: tuple[UnknownHeld, ...] # NEW — tokens awaiting resolution
Hypothesis:
candidate: CandidateInitial | CandidateOperation | CandidateUnknown
category_assignments: tuple[CategoryAssignment, ...] # per-token category trace
constraint_state: ConstraintState # what's been verified
confidence_rank: int # 0 = best; ties broken by appearance order
unresolved: tuple[UnresolvedSlot, ...] # what we still need
UnknownHeld:
token: str
position: int
narrowed_categories: frozenset[Category] # hypotheses that survived this unknown
HYPOTHESIS_CAP is a small constant (3 or 4). The cap is not a heuristic limit on capability — it is a structural assertion that a coherent sentence has at most a few plausible parses. Exceeding the cap is a signal that the read has lost coherence; the reader refuses.
State remains immutable and canonical-bytes-serializable; the existing trace_hash deterministic-replay contract from ADR-0164 is preserved.
2. Lookback re-evaluation operator
A new operator on hypothesis state:
reevaluate(hypotheses, new_token, position) -> (refined_hypotheses, eliminations)
When a token arrives that resolves an earlier ambiguity, reevaluate walks the hypothesis set and:
- For each hypothesis, recomputes the category assignment of any prior token whose role depended on the now-resolved ambiguity.
- Records the recomputation in
category_assignments(so the trace is auditable: "token N was originallyaccumulation_verb, reassigned toaggregate_modifierafter token M=total"). - Eliminates hypotheses whose recomputed assignments violate existing constraints.
Lookback is bounded: it walks only back to the last token whose category was contested in the hypothesis set, never the whole sentence. The bound is structural — uncontested tokens contribute no recomputation work — not a heuristic cap.
3. Continuous constraint propagation
The candidate-graph layer's admissibility check already enforces grounding (roundtrip_admissible) and consistency (_initial_admissible). Today these run only on finalized candidates at the end of parse_and_solve. Move them inside the reader so they fire per-token:
- After every
EMIT, run the in-flight constraint check against the partial hypothesis. A hypothesis whose partial state already violates a constraint cannot become valid by adding more tokens — eliminate immediately. - The check is conservative: it only fires when the relevant slots are populated. An incomplete
CandidateOperationwith a verb but no value token does not trigger value-grounding; once the value token arrives, the check fires and eliminates the hypothesis if the value doesn't ground.
This is process of elimination during reading, not pattern-match-then-verify after reading. The set narrows token-by-token via real constraint failures, not via expectation-matching heuristics.
4. In-loop contemplation
When the surviving hypothesis set is ambiguous (|surviving| ≥ 2) or empty (|surviving| = 0 with held unknowns), the reader invokes contemplation inside the read, not as an offline batch job.
contemplate(state, residual) -> Resolution | None
Resolution:
kind: "eliminate" | "admit_unknown"
target_hypothesis_id: int # which hypothesis to refine
sub_question: str # the question the reader is asking itself
source: "vault" | "pack" | "audit_history"
evidence: tuple[EvidenceRef, ...]
The contemplation function consults — in this order — the vault (prior session memory), the active language packs (the cognition / relations / math packs), and the audit-history of prior reader refusals on the same word or shape. It returns Resolution only when the evidence is unambiguous; ambiguous evidence returns None and the reader refuses cleanly.
contemplate does not invoke an LLM, does not sample, does not normalize. It is a deterministic search over already-ratified evidence. The thesis discipline (thesis-decoding-not-generating) is enforced: the engine finds the resolution that already exists in its memory, or it refuses.
The in-loop call site is a single addition to finalize():
def finalize(ps: ProblemReadingState) -> MathProblemGraph | ReaderRefusal:
survivors = ps.open_hypotheses
if not survivors:
return ReaderRefusal(union of elimination reasons)
if len(survivors) == 1:
return survivors[0].to_graph()
# |survivors| ≥ 2
resolution = contemplate(ps, residual=survivors)
if resolution is None:
return ReaderRefusal(f"ambiguous: {len(survivors)} surviving interpretations")
return apply_resolution(ps, resolution).to_graph()
What this collapses
Three parallel parsing systems become one reader with hypothesis state:
| Module | Today's role | After ADR-0174 |
|---|---|---|
generate/math_parser.py |
Regex sentence-template parser (legacy) | Removed from runtime. Survives only as offline baseline behind --legacy-parser. |
generate/math_candidate_graph.py::parse_and_solve |
Recognizer-driven Cartesian-product parser | The held-hypothesis admission orchestrator. The Cartesian product, the per-sentence-choices accumulator, and the elimination passes move inside the reader; this module becomes the thin admission/solve dispatcher. |
generate/comprehension/lifecycle.py |
All-or-nothing reader (Phase 1+2 shipped, inert) | The reader. Hosts open_hypotheses, reevaluate, in-loop contemplate integration. |
generate/recognizer_anchor_inject.py |
Per-category injector dispatch table | Hypothesis emitters. The category-keyed lookup is removed; injectors become functions the reader calls to propose hypotheses from a recognized anchor. The category tag becomes a property of the emitted hypothesis, not a routing key. |
Lines saved (approximate, conservative): ~1,800 from math_parser.py removal, ~400 from injector dispatch elimination, ~300 from duplicated per-sentence-choice scaffolding in math_candidate_graph.py. The reader grows by an estimated ~600 lines for hypothesis state + reevaluate + contemplate integration. Net: ~1,900 lines removed.
Constraints (non-negotiable)
-
wrong = 0at every phase, every round, every split. Held hypotheses do not weaken admissibility — they relocate the elimination work earlier in the pipeline. The existing_initial_admissible,roundtrip_admissible, multi-branch-disagreement check, and the case-0050 hazard pin all remain in force. A hypothesis that survives the reader is admitted by the same predicates that admit a candidate today. -
No hidden normalization, stochastic fallback, or best-guess.
contemplateis deterministic search over ratified evidence; it returnsResolution | None, never a softmax distribution. Ambiguity that contemplation cannot resolve is a refusal, not a guess.HYPOTHESIS_CAPis a structural assertion about coherent reads, enforced by refusal — not a probability cutoff. -
No regex sentence-templates. ADR-0165 is preserved verbatim. Regex remains allowed only at the lexeme level (currency literal, fraction literal, percentage literal, time-unit noun). Any regex matching across word combinations remains forbidden.
-
Lexicon and category set remain closed and ADR-tracked. ADR-0164's lexicon discipline carries forward unchanged. New categories or new composition rules continue to require an ADR. Held-hypothesis reading is a new use of the existing categories, not an expansion of the category set.
-
Deterministic replay. Identical input → byte-equal hypothesis trace. The
trace_hashcontract from CLAUDE.md §Runtime Surface Contract is extended to coveropen_hypothesesserialization. The replay-equivalence gate (ADR-0172 W0-1) catches any non-determinism. -
In-loop contemplation has the same trust boundary as offline contemplation. It reads from vault, packs, and audit history. It never mutates them in-session. Any ratification that needs to happen still rides the existing HITL corridor (ADR-0150/0152/0155/0161). The in-loop call is read-only; the offline call writes proposals.
What's deprecated, what's preserved
Deprecated by this ADR
- Per-category injector dispatch (
generate/recognizer_anchor_inject.py:233 _INJECTORS). The category-keyed lookup table is removed. Injector functions (inject_discrete_count_statement, etc.) survive as hypothesis-emitter helpers called by the reader from per-token context, but they no longer route admission via category dispatch. The widening pattern (ADR-0170) is preserved as the type the emitter returns; the per-category dispatch as the admission mechanism is replaced. - Legacy regex parser as a runtime path (
generate/math_parser.py). Removed from the runtime pipeline; the file survives only to back the--legacy-parserbaseline flag inevals/gsm8k_math/runner.py(CLEANUP-C2). Once Phase 3 of this ADR is met, the baseline comparison can be retired and the file deleted entirely. - All-or-nothing
ReaderRefusalon first unknown-word or unexpected-category ingenerate/comprehension/lifecycle.py. Replaced byUnknownHeldand hypothesis narrowing.
Preserved in full
- ADR-0164's operational lexicon and category set. The work that went into
en_core_math_v1lexicon, category definitions, and shift-reduce composition rules is the foundation this ADR builds on. Held hypotheses use exactly the same categories and the same lexicon entries. - The binding graph and solver substrate (ADR-0116/0117/0132/0133/0134/0135). Downstream consumption is unchanged.
- The HITL corridor (ADR-0150/0152/0155/0161). Offline contemplation, proposal generation, ratification, and pack-mutation all preserved. In-loop contemplation is additive, not replacement.
wrong = 0doctrine and the replay-equivalence gate.- The composition registry and frame registry consumers (ADR-0168/0169). These are constraint sources the held-hypothesis reader consults; they remain unchanged.
- The capability-axis lanes (G1–G5, S1) and the math contemplation corpus (ADR-0172). They continue to validate the downstream substrate and act as regression nets.
Untouched but adjacent
- The recognizer registry / matcher set (
generate/recognizer_match.py,generate/recognizer_registry.py). Matchers continue to publish anchors; the difference is that anchors feed hypothesis emitters per-token rather than dispatch-table injectors. The HITL pathway that grows the recognizer registry (ADR-0163.C/D) is unchanged. - The reader-question hybrid path (ADR-0164.2 / ADR-0164.3 pronoun + cross-sentence). These become first-class hypothesis-producers within the held-hypothesis state.
Phasing
Phase 1 — Held-hypothesis state primitive
Implement Hypothesis, UnknownHeld, and the open_hypotheses field on ProblemReadingState. Refactor apply_word to operate on the hypothesis set (single hypothesis → tuple of 1, behavior preserved). No new admission behavior; the change is structural.
Acceptance:
- All existing reader tests pass byte-identical (the single-hypothesis case is exactly today's behavior).
test_reader_coexistence.pycontinues to assertwrong = 0on the 50-case train_sample.trace_hashinvariant verified ontrain_sample/v1.
Phase 2 — Continuous constraint propagation
Hoist _initial_admissible and roundtrip_admissible from the candidate-graph layer into per-token in-flight checks within the reader. Hypotheses violating constraints are eliminated immediately, not at end of parse_and_solve.
Acceptance:
- Train_sample score: no decrease (
correct ≥ 3, wrong = 0minimum). - Some refusal reasons shift from
no admissible candidateto early in-reader elimination (visible inreader_trace); the total count is preserved or improves. - Holdout split unchanged within ±1 case.
Phase 3 — Lookback re-evaluation
Implement reevaluate operator and wire it into apply_word. Hypotheses can have prior category assignments refined when later tokens disambiguate.
Acceptance:
- The 21 currently-empty
discrete_count_statementanchors (pronoun subject, compound clause) are revisited: when the question sentence resolves the pronoun, the held statement can be reevaluated. Target: ≥ 5 of these cases admit cleanly. correct ≥ 8on train_sample,wrong = 0.
Phase 4 — In-loop contemplation
Wire contemplate into finalize(). The function consults vault + packs + audit history for deterministic resolution of ambiguous hypothesis sets.
Acceptance:
correct ≥ 15on train_sample,wrong = 0(passes ADR-0163 Round-1 exit comfortably).- In-loop contemplation events are observable in the reader trace and replay-equivalent (re-running the same input yields the same contemplation call sequence).
- No case where in-loop contemplation introduces a wrong answer that offline-only contemplation would not.
Phase 5 — Remove parallel parsers
SUPERSEDED by the §"Phase 5 — Scope (amended 2026-05-28)" section below. The text in this subsection rests on three premises that a pre-scope investigation proved false against the shipped code:
math_parser.pyis already out of the runtime/scoring path,lifecycle.pyadmits 0/50 (it is the inert parallel parser, not the reader to promote), andcorrect ≥ 25is a semantic gate that structural collapse cannot meet. Read the amended scope, not this.
Delete generate/math_parser.py's runtime invocation paths. Remove the per-category injector dispatch table; injectors become inlined hypothesis emitters. Collapse the duplicate per-sentence-choices scaffolding in math_candidate_graph.py.
Acceptance:
correct ≥ 25on train_sample,wrong = 0(passes ADR-0163 Round-2 exit).- Net line count reduction matches the estimate (~1,900 lines).
- The capability-axis lanes G1–G5, S1 remain at 100%
wrong = 0.
Phase 6 — Scale
Per ADR-0163 §Phase F: public, dev, holdout. No changes to that scope from this ADR.
Acceptance criteria for this ADR (Proposed → Accepted)
This ADR moves to Accepted when:
- Phase 1 acceptance is met: held-hypothesis state primitive lands, all existing tests pass,
trace_hashinvariant holds. - A prototype of the lookback
reevaluateoperator exists with at least one test demonstrating prior-token category reassignment under a later disambiguating token. - A prototype of in-loop
contemplateexists with at least one test showing deterministic vault-consultation resolving an ambiguous hypothesis set on a curated case. - Capability-axis lanes G1–G5, S1 remain at 100%
wrong = 0. verify pinned lane SHAscontinues to pass.- Cross-references to ADR-0164 (lexicon and category preservation), ADR-0165 (regex scope), and ADR-0172 (replay-equivalence) reviewed and confirmed unchanged.
Open questions (resolve before Phase 1 PR)
- HYPOTHESIS_CAP value. Initial proposal: 4 (matches the candidate-graph layer's empirical observation that GSM8K sentences rarely admit more than 3 distinct readings before a constraint eliminates one). Should be set by measurement after Phase 1 lands the data collection.
- Lookback walk bound. Whether to bound by token-distance (e.g., re-evaluate at most 10 tokens back) or by category-contest (re-evaluate only tokens whose category was contested in the hypothesis set). Proposal: category-contest, because it is structural and cannot mask a real ambiguity behind a numeric cap.
- Contemplation evidence-ordering precedence. When vault, packs, and audit history all return candidate resolutions, the ordering matters for determinism. Proposal: vault > packs > audit history, mirroring the existing offline contemplation precedence in
teaching/contemplation.py. Confirm against the audit-history schema before Phase 4. - Sub-ADR for hypothesis emitters. The per-category injector functions becoming hypothesis emitters may warrant its own sub-ADR (ADR-0174.1) given the surface area touched. Decide after Phase 1 lands and the call surface is concrete.
- Eval set adequacy. The 50-case
train_sample/v1may be too narrow to validate the held-hypothesis approach; some of the architecture's value (lookback, in-loop contemplation) only manifests on multi-step problems with cross-sentence ambiguity. May need a curated 20-case sub-corpus exercising specifically these patterns before Phase 3 measurement.
Cross-references
- Parent: ADR-0164 — lexicon, categories, deterministic reader; this ADR extends without replacing.
- Constraint scope: ADR-0165 — preserved verbatim.
- Eval target:
evals/gsm8k_math/train_sample/v1/report.json,evals/gsm8k_math/train_sample/v1/README.md(§ADR-0164 Reader — Zero-Delta Diagnosis). - Substrate this builds on:
generate/comprehension/lifecycle.py,generate/comprehension/state.py,generate/recognizer_anchor_inject.py,generate/math_candidate_graph.py,generate/math_roundtrip.py. - Cleanup briefs touching the deprecated paths:
docs/handoff/CLEANUP-C2-run-lane-migration.md,docs/handoff/CLEANUP-C4-compositions-compile.md. - Thesis anchor: thesis-decoding-not-generating — every change in this ADR must pass the "teach the engine to find, not store another found thing" gate.
- HITL corridor preserved: ADR-0150 (contemplation), ADR-0152 (proposal), ADR-0155 (review), ADR-0161 (HITL queue), ADR-0172 (math-corpus decomposition).
- Anti-overfitting obligations: ADR-0114a — held-hypothesis reads are evaluated against the same obligations as the existing pipeline; perturbation, OOD ratio, depth curve, and adversarial axes all apply.
Implementation Notes (added 2026-05-28 after Phase 1-3a lookback review)
The 2026-05-28 lookback review (per CLAUDE.md §Lookback Review Discipline) surfaced drift between this ADR's spec text and what Phases 1-3a actually shipped. Documenting honestly here so Phase 4-5 implementers work from accurate ground truth.
reevaluate signature — implementation differs from spec
ADR text (§Decision §2):
reevaluate(hypotheses, new_token, position) -> (refined_hypotheses, eliminations)
As shipped (Phase 3a, PR #423):
reevaluate(hypothesis: Hypothesis, refinement: Refinement) -> ReevaluateResult
Differences and rationale:
- Single hypothesis + refinement object, not hypothesis set + token+position.
More composable: refinement objects (
PronounResolutionetc.) are reusable; the caller decides which hypotheses to apply to which refinements. - Returns a single
ReevaluateResult(refined-or-None plus bookkeeping), not a (refined_hypotheses, eliminations) tuple. Bulk-eliminate semantics belong on a higher-level orchestrator (not yet built — Phase 4 work).
The shipped design is preferred and the ADR text should be considered amended. Phase 4 implementers should follow the shipped signature.
Phase 2 is per-candidate, not per-token
ADR text (§Decision §3):
Move them inside the reader so they fire per-token: After every EMIT, run the in-flight constraint check against the partial hypothesis.
As shipped (Phase 2, PR #420):
Constraint propagation runs at the math_candidate_graph recognizer-
injection site (per-candidate, after inject_from_match returns), not
inside lifecycle.apply_word (per-token, during reading).
This is a real substrate-vs-active-wiring gap. The check_constraints primitive is available; the per-token integration is Phase 5 work (legacy parser removal + apply_word refactor). Phase 2 is more honestly described as "constraint propagation substrate ready for per-token wiring in Phase 5."
Lookback recompute scope is candidate-level, not token-level
ADR text (§Decision §2):
For each hypothesis, recomputes the category assignment of any prior token whose role depended on the now-resolved ambiguity.
As shipped (Phase 3a, PR #423):
PronounResolution appends one (0, "pronoun_resolved", pronoun)
entry to Hypothesis.category_assignments and rewrites the candidate's
semantic actor field. It does not walk back through per-token
assignments because Phase 1-3a's category_assignments is
candidate-level, not token-level. Per-token category assignment
becomes meaningful in Phase 5 (apply_word refactor).
Phase 3b will widen this when compound-clause refinement enters (multiple per-clause assignments do need recompute walks).
Hypothesis.constraint_state is never populated by Phase 2
The Phase 1 substrate carries Hypothesis.constraint_state: tuple[tuple[str, str], ...]
for recording predicate outcomes. Phase 2's check_constraints
populates ConstraintResult.predicates_run but does NOT copy that
into Hypothesis.constraint_state on the survivors. Survivors carry
forward their original (empty) constraint_state.
Phase 4 (in-loop contemplation) may want to consult
constraint_state to decide which evidence to seek. If so, Phase 4
must wire the population step explicitly. Not a Phase 2 defect — it's
a Phase 2 scope limit.
Multi-actor pronoun wrong=0 hazard defense (Phase 3a follow-up)
The 2026-05-28 review surfaced a real wrong=0 hazard in Phase 3a's
PronounResolution wiring: the _discourse_prior_subjects lookup is
gender-blind and stores only most-recent-prior subject. In multi-actor
problems ("Alice has 5. Bob has 3. She buys 2."), this could resolve
"She" to "Bob" and produce wrong attribution.
Fix landed in the same Phase 3a PR (PR #423): defensive
no_antecedent_ambiguous refusal when more than one distinct
proper-noun subject appears in prior context. Refusal-preferring
discipline preserves wrong = 0.
This is the prototype for refinement-quality gating that Phase 4 (in- loop contemplation) inherits: ambiguity that resolution cannot disambiguate is a refusal, not a guess.
LOC accounting
The ADR §"What this collapses" projects "Net ~1,900 lines removed" once Phase 5 retires the legacy parser. Honest current state:
- Phase 1 added ~243 lines (
state.py) - Phase 2 added ~726 lines (
constraint_propagation.pynew module) + ~50 linesmath_candidate_graph.pywiring - Phase 3a added ~387 lines (
lookback.pynew module) + ~125 linesmath_candidate_graph.pywiring + ~15 linesrecognizer_match.py
Phases 1-3a net: +1,500 lines added. Phase 5 will remove math_parser.py (~1,100 lines) + per-category dispatch (~400 lines) + duplicate per-sentence-choice scaffolding (~300 lines) to reach the projected net removal.
The substrate is correctly load-bearing; the line-count payoff is in Phase 5.
Test coverage backfill
The lookback review found 13 of 17 VALID_PREDICATE_NAMES lacked
direct predicate-name assertions in tests, and all 4
_check_composed_initial sub-checks were untested (parity verified
manually). Backfill landed in the same Phase 3a PR (10 new tests).
Phase 5 — Scope (amended 2026-05-28)
A pre-implementation investigation (per CLAUDE.md §Lookback Review Discipline, triggered "before starting the next phase") established the verified ground truth below. The original §Phase 5 subsection is superseded — it inverted the promote/retire direction and attached the lift gate to the wrong work.
Verified ground truth
| Original Phase 5 premise | Verified reality (2026-05-28) |
|---|---|
math_parser.py is the legacy parser to remove from runtime |
Already out of the chat runtime and the candidate-graph (_score_one_candidate_graph → parse_and_solve) train_sample scoring path. Live only in _score_one, evals/gsm8k_math/verify.py, and the perturbation / OOD / bounded-grammar obligation lanes (core/capability/perturbation_b3.py, generate/perturbation_suite.py, evals/gsm8k_parser_dev/*, evals/math_bounded_grammar, evals/obligation_2_ood_ratio). CLEANUP-C2 keeps it as the --legacy-parser baseline. Nothing to remove from the live path. |
lifecycle.py is the reader to promote to primary |
_try_comprehension_reader (lifecycle apply_word/finalize) admits 0/50 on train_sample — inert in GSM8K scoring. But lifecycle.py is NOT dead: generate/comprehension/audit.py (audit_problem/AuditRow) imports its reader surface, and audit_problem is load-bearing for the ADR-0172 math-contemplation teaching corridor (teaching/math_evidence.py, math_contemplation.py, math_inference_proposal.py, math_claim_signature.py, math_contemplation_proposal.py, core/cli.py, evals/flywheel_demo). The reader's refusals become teaching evidence. So the file stays; only its GSM8K-scoring dispatch is inert and retirable. |
Integration target is per-token apply_word |
All Phase 2/3a/3b/4 defenses (eliminate_violating, reevaluate, contemplate) are wired into the recognizer/candidate-graph path, which produces all 3 correct cases. lifecycle.py carries none of them. |
correct ≥ 25 is the Phase 5 gate |
Structural collapse is a refactor → ~0 lift. The lift lives in removing the 3–5 narrowness layers refusing simultaneously per case — semantic work the original phase never separated. |
Decision (Invert + split): the recognizer/candidate-graph path
(generate/math_candidate_graph.parse_and_solve + math_candidate_parser
recognizer_match+recognizer_anchor_inject, over thestate.pyhypothesis primitives) is the canonical reader.lifecycle.pyis retired. Phase 5 splits into a safe structural phase (5a) and a semantic lift phase (5b).
Retirement-safe vs load-bearing
-
Retire (5a) — GSM8K-scoring-only inert dispatch (~580 LOC):
generate/comprehension/lifecycle_runtime_adapter.py(402 LOC, imported only by the question-reader dispatch); both flag-gated reader dispatches inmath_candidate_graph.py—_try_comprehension_reader(whole-problem, admits 0/50),_try_reader_for_question(question-stage, via the adapter), and the_tokenize_sentencehelper they use; thecomprehension_reader_questionsconfig flag they share and the--use-readerplumbing in the train_sample runner;tests/test_reader_coexistence.py(its flag-ON/OFF byte-identity premise dissolves once there is one path). -
KEEP — load-bearing, corrected from the first draft:
generate/comprehension/lifecycle.py(stays — the audit→teaching corridor uses its reader surface; only its scoring dispatch is inert).tests/test_reader_phase2.pyandtest_reader_question_frame.pyimport it directly and stay.generate/comprehension/audit.py(audit_problem/AuditRow) — the ADR-0172 contemplation/evidence entry point.state.py— includingProblemReadingState(contemplate()'s parameter type, constructed in the Phase 4 recognizer wiring atmath_candidate_graph.py:928),Hypothesis,UnknownHeld,HYPOTHESIS_CAP;constraint_propagation.py,lookback.py,contemplate.py, and therecognizer_anchor_inject.pyinjector table.
Correction (2026-05-28, during 5a pre-flight): the first draft of this scope said "retire lifecycle.py (~1,872 LOC)". A pre-deletion trace found
audit.pyimports lifecycle's reader surface and feeds the live teaching corridor, so lifecycle.py is dual-use and must stay. 5a's real payoff is ~580 LOC (the scoring dispatch + adapter + flag), not the projected ~1,872. The deeper LOC reduction the parent ADR projected does not materialize while the contemplation corridor keeps the reader alive.
Phase 5a — Retire the inert parallel parser (structural)
Scope (corrected):
- Delete both flag-gated reader dispatch functions
(
_try_comprehension_reader,_try_reader_for_question) and their call sites inmath_candidate_graph.py, plus the_tokenize_sentencehelper; drop thecomprehension_reader_questionsconfig flag and the--use-readerrunner plumbing (the recognizer path runs unconditionally — it is no longer "opt-in reader vs regex," it is the only scoring path). - Delete
generate/comprehension/lifecycle_runtime_adapter.py(used only by the question-reader dispatch). Do NOT deletelifecycle.pyoraudit.py— both feed the live ADR-0172 contemplation corridor. - Remove
tests/test_reader_coexistence.py(flag-ON/OFF premise gone); keeptest_reader_phase2.py/test_reader_question_frame.py(they testlifecycle.py, which stays). - Leave
state.pyintact.ProblemReadingState/ReaderRefusalare load-bearing (contemplate + audit corridor);EntityRef/SentenceStateremain referenced by the survivinglifecycle.py. No state.py trim in 5a. - Collapsing the duplicate per-sentence-choice scaffolding is deferred — with the question-reader branch gone the dispatch is already single-path; any further structural collapse is its own follow-up, not load-bearing for 5a.
Acceptance (5a):
- train_sample 3/47/0 unchanged — byte-identical verdicts; this is a refactor, not a behaviour change. (Honest: ~0 lift is the expected and correct outcome of 5a.)
- Net −1,038 LOC of code + tests (as shipped: adapter 402 +
test_reader_coexistence.py302 + train_sample delta-report/use_readerplumbing ~96 + the twomath_candidate_graphdispatch fns/tokenizer + coverage-CLIuse_readerfield + stale delta artifact, against ~53 lines of replacement docstrings/comments). Larger than the first ~580 estimate because the coexistence test and delta-report harness were bigger than scoped. The parent ADR's ~1,872-line figure still does not apply:lifecycle.pystays for the teaching corridor. - Capability-axis lanes G1–G5, S1 remain 100%
wrong = 0. - Determinism /
trace_hashinvariant holds; pinned lane SHAs pass. math_parser.pybaseline lanes untouched (out of scope — keep).
Phase 5b — Operation-capability buildout (semantic, the real lift)
This is where correct climbs toward 25. It is not a refactor and
carries the live wrong = 0 risk; it lands as its own sub-phases
(candidate sub-ADR: ADR-0174.1) with per-sub-phase wrong=0 obligations,
not as a big bang.
Verified ground truth (2026-05-28 measurement)
The 47 train_sample refusals were profiled against GSM8K's own
<<a*b=c>> calculator annotations (ground-truth operations, not
brute-forced — brute-force number-matching was tried and rejected for
producing spurious coincidental hits, e.g. matching gold=4 to a stray
20/5):
| Profile | Count | Share |
|---|---|---|
Uses multiplication (*) |
37/47 | 79% |
| Uses mul or div | 43/47 | 91% |
| Pure add/subtract | 4/47 | 9% |
| Single-step solvable | 0/47 | 0% |
Step-count histogram: 2 steps: 13 · 3: 12 · 4: 8 · 5: 8 · 6: 3 · 7: 3.
Two load-bearing consequences:
-
Multiplication is the foundational capability, not a niche. At 79% it is maximally general — building genuine multiplicative quantity-extraction is "getting generally smarter," the opposite of overfitting. (Per Shay's framing: a change that flips a large general chunk is a real capability; a per-phrasing patch that flips one case is overfitting. Breadth-of-impact is the test, not where the code lives.)
-
No case flips from an operation matcher alone. Zero single-step cases. Multiplication is necessary but not sufficient for all 37 — the unit that flips a case is operation + composition (extract quantities across sentences/question → apply op → combine). A "multiplication sentence matcher" in isolation flips ~2 cases (only the single-sentence multiplicative aggregate, 0021-class) and would be overfitting-adjacent.
The solver is already capable: VALID_OPERATION_KINDS =
{add, subtract, transfer, multiply, divide, apply_rate, compare_additive, compare_multiplicative} with pack lemmas for each. The gap is entirely the
reader → injector → Operation front-end: the recognizer matches a
shape category but extracts zero anchors on real corpus sentences, and
the injectors only handle narrow Wave-A stub shapes. Phase 5b builds the
front-end down to the operations the solver is already waiting for.
What to build (and what NOT to)
- Build: general quantity-extraction (operands from a clause, across
sentences, and from the question sentence) + injectors that emit
first-class
multiply/divide/compare_multiplicativeoperations + the multi-step composition spine that chains them. The held-hypothesis /eliminate_violating/reevaluatesubstrate (Phases 1–4) is the wrong=0 scaffold for chains longer than 2 steps. - Do NOT: widen the
discrete_count_statementinjector to absorb these. The recognizer mis-matches multiplicative/comparative problems as discrete-count (number + noun present); the injector correctly refuses. Forcing those into a discrete-count frame is overfitting and a wrong=0 hazard. Route them to the correct operation injector instead.
Sub-phase sequence (biggest-chunk-first, measure-the-flip-gated)
Each sub-phase is a complete vertical slice (extraction → injector → existing solver op) whose success is judged by how many cases flip, not by whether a layer was touched:
- 5b.1 — Single-sentence multiplicative aggregate (0021-class:
"15 pounds for 10 reps and does 3 sets"). One clause, N operands, one
multiplychain — no cross-sentence binding. The cleanest possible proof-of-capability. Small expected flip (~2–4) but it stands up the extraction→multiply→solve path end-to-end with wrong=0. - 5b.2 — Shallow 2–3 step composition (the real chunk: 25/47 cases at ≤3 steps). Cross-sentence + question-sentence operand binding (e.g. 0003: 48 boxes × 24/box × $0.75-in-question), op + one combine. This is where the bulk of the lift lives.
- 5b.3 — Deep multi-step (4–7 steps, 22/47) under the held-hypothesis elimination machinery. Highest wrong=0 surface (long chains = more ways to admit a wrong answer); last, and only after 5b.1–5b.2 lock the extraction/composition contracts.
Dependencies / out-of-scope-but-required
- Solver gaps (separate solver ADR): same-actor multi-quantity aggregation and cross-unit superordinate sums — the reader can parse some shapes the solver still refuses to compute. Sequence the solver ADR before the 5b sub-phases that need those shapes.
- Comparatives reuse the existing ADR-0131 G2 axis and
compare_multiplicative/compare_additivesolver ops — extend, don't reinvent.
Acceptance (5b)
- Per-sub-phase
correctdelta reported withwrong = 0held at every step; case 0050 canary stays refused. - Generality guard: every flipped case must also hold under the ADR-0114a perturbation / OOD axes. A capability that flips N train_sample cases but collapses under reworded inputs was overfitting to the sample and does not count toward the chunk.
correct ≥ 25is the cumulative Round-2 target, reached by composition of sub-phases — never asserted of any single sub-phase.- Capability-axis lanes G1–G5, S1 remain 100%
wrong = 0.
Sequencing
- 5a — shipped (PR #430): single parse path, net −1,038 LOC, 3/47/0 byte-identical, wrong=0 held. Behaviour-preserving refactor; ~0 lift was the expected, correct outcome.
- 5b — next, as its own sub-ADR (ADR-0174.1): 5b.1 → 5b.2 → 5b.3, biggest-chunk-first, each gated by measured flip-count + the perturbation generality guard + wrong=0. The solver ADR (multi-quantity / cross-unit sums) sequences before the 5b sub-phases that depend on it.