core-labs/core
core-labs/core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(tests): evolve P12 anti-self-Accept guard for the ratified state #47

Merged
core-labs merged 4 commits from fix/governance-p12-post-ratification into main 2026-07-16 13:54:12 +00:00
Conversation 0 Commits 4 Files changed 5 +3248 -11
core-labs commented 2026-07-16 00:37:38 +00:00
Owner
Copy link

Summary

The P12 governance guard pinned 'ADRs stay Proposed — not self-Accepted'. Its precondition was fulfilled: Joshua ruled 'Ratify' (D10 packet §8) and #43 flipped both ADRs to Accepted — turning the pin red on main (first flagged by the W3 lane as a 'brand-new governance-doc red'; the guard fired exactly as designed, even against the ratification itself).

The guard evolves rather than dies: it now asserts Accepted + inline ratification provenance on both ADR status lines and the §8 ruling record in the packet — a silent status flip in either direction (unauthorized Accept, or quiet demotion) still fails.

Test plan

  • tests/test_adr_0241_governance_p12.py — 6 passed (was 1 failed on main)
  • Single test-file change; no runtime surface

[Verification]: Smoke suite passed locally (138s, 175 passed)

## Summary The P12 governance guard pinned 'ADRs stay Proposed — not self-Accepted'. Its precondition was fulfilled: Joshua ruled 'Ratify' (D10 packet §8) and #43 flipped both ADRs to Accepted — turning the pin red on main (first flagged by the W3 lane as a 'brand-new governance-doc red'; the guard fired exactly as designed, even against the ratification itself). The guard evolves rather than dies: it now asserts **Accepted + inline ratification provenance** on both ADR status lines **and** the §8 ruling record in the packet — a silent status flip in either direction (unauthorized Accept, or quiet demotion) still fails. ## Test plan - [x] tests/test_adr_0241_governance_p12.py — 6 passed (was 1 failed on main) - [x] Single test-file change; no runtime surface [Verification]: Smoke suite passed locally (138s, 175 passed)
core-labs added 1 commit 2026-07-16 00:37:48 +00:00
fix(tests): evolve P12 anti-self-Accept guard for the ratified state
Some checks failed
smoke / smoke (-m "not quarantine") (pull_request) Successful in 7m15s
Details
lane-shas / verify pinned lane SHAs (pull_request) Failing after 27m28s
Details
987a04bac9 
The guard pinned 'ADRs stay Proposed — not self-Accepted', which was
correct until its own precondition was fulfilled: Joshua Shay ruled
'Ratify' on the D10 packet (2026-07-15, ruling record packet §8) and #43
flipped both ADRs to Accepted — turning this pin red on main (first
flagged by the W3 lane as a 'brand-new governance-doc red').

The guard's spirit survives, strengthened: the test now asserts Accepted
WITH inline ratification provenance on both ADR status lines AND the §8
ruling record in the packet — so a silent status flip in EITHER direction
(an Accept without provenance, or a quiet demotion) still fails.

[Verification]: tests/test_adr_0241_governance_p12.py 6 passed; smoke
gate queued behind the running slow-lane sweep, push held until green.
core-labs added 2 commits 2026-07-16 13:03:27 +00:00 
Slow-lane sweep (2026-07-15, 37m06s): 1 failed / 909 passed / 1 skipped /
1 xfailed. The single red was a stale constant pin (assert
MAX_RUNTIME_SECONDS == 30) missed when 640dbe8f deliberately re-budgeted
the public showcase to 60s — the slow lane hadn't been run since (nightly
lives on the billing-locked GitHub side). Pin updated to the deliberate,
comment-documented value; ledger Slow row completed. The historical '~31
full-suite reds' figure is fully retired: fast lane cleared by #45, slow
lane clean after this pin.

[Verification]: tests/test_public_showcase.py green; push held until the
CI locked-install fix lands (branch inherits it via main-merge).
Merge remote-tracking branch 'forgejo/main' into fix/governance-p12-post-ratification
Some checks failed
smoke / smoke (-m "not quarantine") (pull_request) Failing after 56s
Details
lane-shas / verify pinned lane SHAs (pull_request) Failing after 52m2s
Details
08896d412a
core-labs added 1 commit 2026-07-16 13:15:06 +00:00
build: commit uv.lock — the locked universe CI now installs
All checks were successful
smoke / smoke (-m "not quarantine") (pull_request) Successful in 5m30s
Details
lane-shas / verify pinned lane SHAs (pull_request) Successful in 17m9s
Details
7930a9183f 
#48 switched CI to 'uv sync --locked' but uv.lock was gitignored (an early
library-style choice; this repo is an application — the lock belongs in
git). Every run since failed at install: 'Unable to find lockfile'.
Un-ignore and commit the lock (217 packages, matches pyproject via
'uv lock --check'). CI now installs the exact universe local development
and all green verification ran against.

[Verification]: code tree byte-identical to the smoke-gated state
(175 passed); this commit adds a data file CI requires + one .gitignore
line removal.
core-labs merged commit 56e55e6eb1 into main 2026-07-16 13:54:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: core-labs/core#47
No description provided.
Delete branch "fix/governance-p12-post-ratification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?