fix(tests): clear pre-existing full-suite reds (W2 INV-21 + rotor_power) #45

Merged

core-labs merged 1 commit from fix/pre-existing-test-reds-v2 into main

2026-07-15 23:40:25 +00:00

core-labs commented

2026-07-15 22:40:46 +00:00

Owner

Summary

Clears the 5 pre-existing red tests that the non-quarantine fast lane surfaces on current main (brief’s ~31 count reflected an older tip; smoke/pack/lane gates stayed green).

#	Test	Class	Disposition
1	`test_deductive_entailment_authority_demo::test_inv21_and_inv29_allowlists_are_unchanged`	(b) pin drift	Updated INV-21 pin for `core/physics/holographic_vault.py` (ADR-0241)
2	`test_proof_carrying_promotion_demo::test_inv21_and_inv29_allowlists_are_unchanged`	(b) pin drift	Same pin update
3	`test_engine_loop_proof::test_generated_final_state_satisfies_versor_condition_by_construction`	(b) producer	`generate/stream.py`: skip non-powerable `rotor_power` on mixed-parity recall hits
4	`test_register_pack_convivial_v1::test_runtime_chat_turn_idx_distinct_under_convivial`	(b) producer	`session/context.py`: skip anchor pull when transition is not a rotor
5	`test_session_coherence::test_session_anchor_pull_output_satisfies_versor_condition`	(b) fixture + producer	Grade-1 fixture parity + producer guard

Root cause notes

Multi-token inject fields are even-grade; many vault hits are grade-1. Their transition is a unit odd versor, not a rotor. Exact rotor_power correctly refuses; callers previously crashed.
No assertions weakened; no tests deleted; QUARANTINE remains empty; wrong=0 surfaces untouched; no lane-pin regen.

Ledger: docs/analysis/full-suite-reds-ledger-2026-07.md

Hard-rule checklist

Never weakened an assertion to pass
Never deleted a test without ledger
Did not edit .github/workflows/, chiral_gate.py, or goldtether.py

Test plan

Pre-fix fast lane enumerate: 5 failed / 11660 passed
Targeted fixed reds: 5 passed (post-rebase recheck)
Related modules: 10 passed
python scripts/verify_lane_shas.py → 9/9
uv run core test --suite smoke -q → 175 passed

[Verification]: targeted 10 passed; lane SHAs 9/9; smoke 175 passed; pre-fix fast 5 reds fixed

Do not merge without CI.

## Summary Clears the **5** pre-existing red tests that the non-quarantine fast lane surfaces on current `main` (brief’s ~31 count reflected an older tip; smoke/pack/lane gates stayed green). | # | Test | Class | Disposition | |---|------|-------|-------------| | 1 | `test_deductive_entailment_authority_demo::test_inv21_and_inv29_allowlists_are_unchanged` | (b) pin drift | Updated INV-21 pin for `core/physics/holographic_vault.py` (ADR-0241) | | 2 | `test_proof_carrying_promotion_demo::test_inv21_and_inv29_allowlists_are_unchanged` | (b) pin drift | Same pin update | | 3 | `test_engine_loop_proof::test_generated_final_state_satisfies_versor_condition_by_construction` | (b) producer | `generate/stream.py`: skip non-powerable `rotor_power` on mixed-parity recall hits | | 4 | `test_register_pack_convivial_v1::test_runtime_chat_turn_idx_distinct_under_convivial` | (b) producer | `session/context.py`: skip anchor pull when transition is not a rotor | | 5 | `test_session_coherence::test_session_anchor_pull_output_satisfies_versor_condition` | (b) fixture + producer | Grade-1 fixture parity + producer guard | ### Root cause notes - Multi-token inject fields are **even-grade**; many vault hits are **grade-1**. Their transition is a unit odd versor, not a rotor. Exact `rotor_power` correctly refuses; callers previously crashed. - No assertions weakened; no tests deleted; `QUARANTINE` remains empty; wrong=0 surfaces untouched; no lane-pin regen. Ledger: `docs/analysis/full-suite-reds-ledger-2026-07.md` ## Hard-rule checklist - [x] Never weakened an assertion to pass - [x] Never deleted a test without ledger - [x] Did not edit `.github/workflows/`, `chiral_gate.py`, or `goldtether.py` ## Test plan - [x] Pre-fix fast lane enumerate: 5 failed / 11660 passed - [x] Targeted fixed reds: 5 passed (post-rebase recheck) - [x] Related modules: 10 passed - [x] `python scripts/verify_lane_shas.py` → **9/9** - [x] `uv run core test --suite smoke -q` → **175 passed** `[Verification]: targeted 10 passed; lane SHAs 9/9; smoke 175 passed; pre-fix fast 5 reds fixed` Do not merge without CI.

core-labs added 1 commit 2026-07-15 22:40:56 +00:00

fix(tests): clear pre-existing full-suite reds (INV-21 pins + rotor_power)

smoke / smoke (-m "not quarantine") (pull_request) Successful in 7m11s

Details

lane-shas / verify pinned lane SHAs (pull_request) Successful in 25m7s

Details

dddd85cfca

Five fast-lane failures on main made the full suite dishonest.

- Refresh INV-21 allowlist pins in demo tests for holographic_vault (ADR-0241)
- Skip non-powerable (mixed-parity) rotor_power calls in generate recall and
  session anchor pull instead of crashing the cognitive path
- Align session_anchor_pull fixture to grade-1 field parity
- Ledger: docs/analysis/full-suite-reds-ledger-2026-07.md

[Verification]: targeted 10 passed; lane SHAs 9/9; smoke 175 passed