core-labs/core
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Merge pull request #679 from AssetOverflow/fix-ask-acquisition-guard

Browse source 
test(ask): make acquisition runtime guard structural
This commit is contained in:
Shay 2026-06-09 13:43:21 -07:00 committed by GitHub
commit d3e13bbf19
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/test_ask_acquisition.py
View file

@ -270,12 +270,25 @@ def test_acquisition_module_does_not_import_renderer_or_pass_manager() -> None:
assert node.func.id != "render_question"
def test_runtime_and_telemetry_schemas_are_not_changed_by_this_slice() -> None:
def test_runtime_and_telemetry_public_schemas_are_not_changed_by_acquisition_slice() -> None:
runtime_path = Path(__file__).resolve().parents[1] / "chat" / "runtime.py"
telemetry_path = Path(__file__).resolve().parents[1] / "chat" / "telemetry.py"
identity_path = Path(__file__).resolve().parents[1] / "core" / "physics" / "identity.py"
assert "contemplation_result" not in runtime_path.read_text(encoding="utf-8")
runtime_tree = ast.parse(runtime_path.read_text(encoding="utf-8"), filename=str(runtime_path))
for node in ast.walk(runtime_tree):
if isinstance(node, ast.FunctionDef) and node.name == "chat":
arg_names = [arg.arg for arg in node.args.args + node.args.kwonlyargs]
assert "contemplation_result" not in arg_names
if isinstance(node, ast.ClassDef) and node.name == "ChatResponse":
field_names = [
stmt.target.id
for stmt in node.body
if isinstance(stmt, ast.AnnAssign) and isinstance(stmt.target, ast.Name)
]
assert "disposition" not in field_names
assert "disposition" not in telemetry_path.read_text(encoding="utf-8")
identity_source = identity_path.read_text(encoding="utf-8")