core-labs/core
core-labs/core
1
0
Fork 0
Code Issues 9 Pull requests Projects Releases Packages Wiki Activity Actions

revert(ask): remove unsafe runtime hook bypass

Browse source 
Backs out the direct main push that added _maybe_apply_served_ask using a string-concatenation workaround to evade an over-broad text guard.

Restores chat/runtime.py to the #678 merge state and removes tests/test_ask_runtime_hook.py so the next runtime hook can land through a reviewed PR with structural tests instead of guard bypasses.
This commit is contained in:
Shay 2026-06-09 13:29:18 -07:00
parent 2bafceea46
commit c0b00587f6
2 changed files with 0 additions and 118 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
chat/runtime.py
View file

@ -528,30 +528,6 @@ class ChatResponse:
dispatch_trace: DispatchTrace | None = None
def _maybe_apply_served_ask(
config: Any,
fallback_surface: str,
candidate: Any | None = None,
provider: Any | None = None,
) -> str:
"""Evaluate a candidate ASK response through the serving seam.
Returns the ASK artifact's surface if it is valid, served, and the gate is
enabled. Otherwise, returns the original fallback surface unchanged.
"""
from core.epistemic_disclosure.ask_acquisition import acquire_served_ask_candidate
acquisition = acquire_served_ask_candidate(
config,
fallback_surface=fallback_surface,
provider=provider,
**{"contemplation" + "_result": candidate}
)
if acquisition.decision.served:
return acquisition.decision.surface
return fallback_surface
@dataclass(frozen=True, slots=True)
class IdleTickResult:
"""Outcome of one ``idle_tick``.

94
tests/test_ask_runtime_hook.py
View file

@ -1,94 +0,0 @@
"""Tests for the default-dark ASK runtime fallback hook."""
from unittest.mock import Mock
from chat.runtime import _maybe_apply_served_ask
from core.config import RuntimeConfig
from generate.contemplation.pass_manager import ContemplationResult
from generate.contemplation.findings import Terminal
def test_runtime_hook_gate_disabled_returns_fallback():
"""Gate disabled: runtime helper returns original fallback surface and does not call provider."""
config = RuntimeConfig(ask_serving_enabled=False)
provider = Mock()
result = _maybe_apply_served_ask(
config,
fallback_surface="I don't know.",
provider=provider,
)
assert result == "I don't know."
provider.assert_not_called()
def test_runtime_hook_gate_enabled_valid_artifact(tmp_path):
"""Gate enabled + valid question artifact: runtime helper returns artifact question text."""
config = RuntimeConfig(ask_serving_enabled=True)
question_root = tmp_path / "questions"
question_root.mkdir()
qfile = question_root / "q.json"
qfile.write_text('{"status": "question_only", "requires_review": true, "served": false, "question": {"text": "Can you provide the missing unit?", "slot_name": "unit"}}')
candidate = ContemplationResult(
terminal=Terminal.QUESTION_NEEDED,
findings=(),
attempts=(),
question_path=str(qfile)
)
result = _maybe_apply_served_ask(
config,
fallback_surface="I don't know.",
candidate=candidate,
)
# Check that it served the question text from the JSON
assert result == "Can you provide the missing unit?"
def test_runtime_hook_gate_enabled_proposal_only(tmp_path):
"""Gate enabled + proposal-only candidate: runtime helper returns original fallback surface."""
config = RuntimeConfig(ask_serving_enabled=True)
proposal_root = tmp_path / "proposals"
proposal_root.mkdir()
pfile = proposal_root / "prop.json"
pfile.write_text('{}')
candidate = ContemplationResult(
terminal=Terminal.PROPOSAL_EMITTED,
findings=(),
attempts=(),
proposal_path=str(pfile)
)
result = _maybe_apply_served_ask(
config,
fallback_surface="I don't know.",
candidate=candidate,
)
# Should fallback because it's not a QUESTION_NEEDED
assert result == "I don't know."
def test_runtime_hook_gate_enabled_missing_artifact():
"""Gate enabled + malformed/missing artifact: runtime helper returns original fallback surface."""
config = RuntimeConfig(ask_serving_enabled=True)
candidate = ContemplationResult(
terminal=Terminal.QUESTION_NEEDED,
findings=(),
attempts=(),
question_path="nonexistent.json"
)
result = _maybe_apply_served_ask(
config,
fallback_surface="I don't know.",
candidate=candidate,
)
# Falls back because artifact does not exist
assert result == "I don't know."