core/teaching/coverage.py
Shay d91ea3d36e feat(D): core teaching coverage — per-shape admission histogram
Brief D from PR #407. Closes the "flying blind on per-shape coverage"
gap identified in RAT-1's audit (finding 6).

After this PR, every operator can run a single command to see exactly
which refusal modes their work moved (or didn't), without re-eyeballing
report.json by hand.

Modules
-------
- teaching/coverage.py — pure aggregator:
  - _classify_refusal — maps each per-case refusal reason to a
    stable bucket (recognizer_empty_injection(<ShapeCategory>),
    no_admissible_question, no_admissible_statement,
    unexpected_question_count, other)
  - build_coverage_report — reads a lane's report.json + emits a
    CoverageReport with counts, refusal_taxonomy (sorted by count
    desc), case_0050_verdict, optional delta vs baseline
  - fetch_committed_baseline — uses `git show HEAD:<relpath>` to
    pull the baseline report.json for delta computation

- core/cli.py:
  - cmd_teaching_coverage — formats the report for terminal output
  - core teaching coverage [--lane gsm8k_math] [--split train_sample]
    [--version v1] [--use-reader] [--run] [--delta] [--json]

CLI output example
------------------
  Lane: gsm8k_math/train_sample/v1 (use_reader=True)
  Counts: correct=3 refused=47 wrong=0

  Refusal taxonomy:
     21  recognizer_empty_injection(discrete_count_statement)
      6  no_admissible_statement
      5  recognizer_empty_injection(multiplicative_aggregation)
      4  no_admissible_question
      4  recognizer_empty_injection(currency_amount)
      3  recognizer_empty_injection(rate_with_currency)
      2  recognizer_empty_injection(descriptive_setup_no_quantity)
      2  recognizer_empty_injection(temporal_aggregation)

  Wrong=0: ✓
  Case 0050 hazard pin: refused ✓

Tests (13 new)
--------------
tests/test_teaching_coverage_cli.py — classification narrowness,
counts aggregation, case 0050 verdict capture, delta computation,
missing-baseline path, missing-report error, taxonomy sort order,
wrong=0 invariant visibility via as_dict.

Suite results
-------------
core test --suite teaching -q → 106 passed (93 → +13)
core test --suite runtime  -q → 20 passed
core test --suite packs    -q → 127 passed
core eval gsm8k_math --split public → 150/150, wrong=0

Note on Brief E (lexical auto-compile): the audit was WRONG. The
lexicon loader (generate/comprehension/lexicon.py::load_lexicon)
reads from the per-category source files directly; the compiled
lexicon.jsonl is only a manifest-checksum pin, not the source of
truth at runtime. apply_lexical_claim() writes a new entry → next
turn the loader sees it. Brief E is a non-issue; closing without a
code PR.

Verified by direct test: stage a clone of the math pack, write a
synthetic lemma to drain_token.jsonl, clear the lexicon cache, load
again → new entry present. So 3 of the 5 audit gaps closed (A, D,
E-as-correction); B and C remain as the next operator dispatch
targets.

Independent of PR #406 (RAT-1) and PR #408 (WAVE-A). Based on main.
2026-05-27 21:20:00 -07:00

184 lines
5.7 KiB
Python

"""Brief D — coverage report aggregator for math eval lanes.
Reads the lane's ``report.json`` and emits a per-ShapeCategory
refusal histogram with optional delta-vs-committed-baseline. Pure
read; no side effects on lane state. Used by
``core teaching coverage``.
"""
from __future__ import annotations
import json
import re
import subprocess
from dataclasses import dataclass, field
from pathlib import Path
from typing import Mapping
_REASON_CATEGORY_RE: re.Pattern[str] = re.compile(r"\(category=([a-z_]+)\)")
@dataclass(frozen=True, slots=True)
class CoverageCounts:
correct: int
refused: int
wrong: int
def total(self) -> int:
return self.correct + self.refused + self.wrong
@dataclass(frozen=True, slots=True)
class CoverageReport:
lane: str
split: str
version: str
counts: CoverageCounts
refusal_taxonomy: Mapping[str, int]
case_0050_verdict: str | None
use_reader: bool
delta: Mapping[str, int] = field(default_factory=dict)
def as_dict(self) -> dict[str, object]:
return {
"lane": self.lane,
"split": self.split,
"version": self.version,
"counts": {
"correct": self.counts.correct,
"refused": self.counts.refused,
"wrong": self.counts.wrong,
"total": self.counts.total(),
},
"refusal_taxonomy": dict(self.refusal_taxonomy),
"case_0050_verdict": self.case_0050_verdict,
"use_reader": self.use_reader,
"delta": dict(self.delta),
}
def _classify_refusal(reason: str) -> str:
"""Map a per-case refusal reason string to a stable category bucket.
Buckets:
- ``recognizer_empty_injection(<ShapeCategory>)`` — recognizer
matched but injector returned empty
- ``no_admissible_candidate`` — neither parser nor recognizer admitted
- ``no_admissible_question`` — statement(s) admitted; question parser refused
- ``unexpected_question_count`` — !=1 question sentence
- ``other`` — any unmatched reason text
"""
if not reason:
return "other"
lower = reason.lower()
if "recognizer matched but produced no injection" in reason:
m = _REASON_CATEGORY_RE.search(reason)
cat = m.group(1) if m else "unknown"
return f"recognizer_empty_injection({cat})"
if "no admissible candidate for question" in reason:
return "no_admissible_question"
if "no admissible candidate for statement" in reason:
return "no_admissible_statement"
if "expected exactly one question sentence" in lower:
return "unexpected_question_count"
return "other"
def build_coverage_report(
report_path: Path,
*,
lane: str,
split: str,
version: str,
use_reader: bool,
baseline_path: Path | None = None,
) -> CoverageReport:
"""Build a :class:`CoverageReport` from a runner-emitted report.json.
Optional ``baseline_path`` enables a delta computation.
"""
if not report_path.exists():
raise FileNotFoundError(f"report.json not found at {report_path}")
data = json.loads(report_path.read_text(encoding="utf-8"))
counts_raw = data.get("counts") or {}
counts = CoverageCounts(
correct=int(counts_raw.get("correct", 0)),
refused=int(counts_raw.get("refused", 0)),
wrong=int(counts_raw.get("wrong", 0)),
)
per_case = data.get("per_case") or []
taxonomy: dict[str, int] = {}
case_0050_verdict: str | None = None
for case in per_case:
verdict = case.get("verdict")
cid = case.get("case_id", "")
if cid.endswith("-0050"):
case_0050_verdict = verdict
if verdict != "refused":
continue
bucket = _classify_refusal(case.get("reason") or "")
taxonomy[bucket] = taxonomy.get(bucket, 0) + 1
# Sort taxonomy by count desc, then alpha for stable output.
sorted_taxonomy = dict(
sorted(taxonomy.items(), key=lambda kv: (-kv[1], kv[0]))
)
delta: dict[str, int] = {}
if baseline_path is not None and baseline_path.exists():
try:
base_data = json.loads(baseline_path.read_text(encoding="utf-8"))
base_counts = base_data.get("counts") or {}
delta = {
"correct": counts.correct - int(base_counts.get("correct", 0)),
"refused": counts.refused - int(base_counts.get("refused", 0)),
"wrong": counts.wrong - int(base_counts.get("wrong", 0)),
}
except (json.JSONDecodeError, KeyError, TypeError):
delta = {}
return CoverageReport(
lane=lane,
split=split,
version=version,
counts=counts,
refusal_taxonomy=sorted_taxonomy,
case_0050_verdict=case_0050_verdict,
use_reader=use_reader,
delta=delta,
)
def fetch_committed_baseline(
report_relpath: str,
repo_root: Path,
) -> Path | None:
"""Return a temp path containing HEAD's committed report.json, or None.
Uses ``git show HEAD:<relpath>``. Falls back to None on any git
error so the CLI doesn't depend on git availability.
"""
try:
result = subprocess.run(
["git", "-C", str(repo_root), "show", f"HEAD:{report_relpath}"],
capture_output=True,
check=True,
text=True,
)
except (subprocess.CalledProcessError, FileNotFoundError):
return None
if not result.stdout.strip():
return None
tmp = repo_root / ".git" / "coverage_baseline_tmp.json"
tmp.write_text(result.stdout, encoding="utf-8")
return tmp
__all__ = [
"CoverageCounts",
"CoverageReport",
"build_coverage_report",
"fetch_committed_baseline",
]