core/tests/test_adr_index.py
Claude 71bf04fb44
feat(provenance,teaching): close the lateral gaps the assessment actually found
Squashes the arc's work into one commit; the workflow-file edit it originally
carried is excluded (see the end of this message).

## Lane 1 — Workbench recorded a proved answer as ungrounded

With deduction_serving_enabled ratified ON (ADR-0256), workbench/api.py's live
chat route builds a bare ChatRuntime(), so the deduction composer decides
Workbench turns and stamps grounding_source="deduction" — but
_coerce_grounding_source carried a hand-copied whitelist of the six pre-arc
labels and silently rewrote anything else to "none". The runtime comment
reasoned this was inert because "REPL turns do not flow through Workbench's
CognitivePipelineRecord path". True, and irrelevant: the traffic flows the
other way. Stale since 2026-07-24.

Scope is one field. workbench/api.py:818 prefers TurnEvent.epistemic_state,
which read epistemic_state_needed — honest. So the UNregistered path degraded
honestly while the hand-copied whitelist asserted a falsehood; a second copy of
a closed enum was worse than no copy. Hence registration AND derivation:
GROUNDING_SOURCES exposes the Literal's members, and the coercion reads it.
workbench-ui badges/tokens/snapshot follow; enumCoverage.test.ts forces atomicity.

## Lane 2 — the ratification ceremony

The discovery loop was instrumented but not closed. teaching/ratification.py
turns a reviewed decision into a chain record, a corpus commit, and a receipt.

Its design turns on one observation: _ratified_rows DROPS unadmissible rows
silently — correct when serving, a trap when ratifying, because the file grows,
the commit lands, and the band count does not move. So the ceremony refuses to
call an append a ratification until it has re-read the curriculum through the
real loader and seen the chain arrive; a non-admitted append is rolled back.
Validation is a pre-flight courtesy, admission is the proof.

Arena queue entry and ledger reseal are deliberately NOT performed (bridge rule
1); the receipt names them. Front door: `core proposal-queue ratify`, a sibling
of `review` rather than a flag on it.

## Lane 3 — structural closures

- ADR-0263 gains rule 5: absence policy is DECLARED in CAPABILITY_LEDGERS, not
  passed at the call site. An AST-matched test fails if a serving path passes
  missing_ok again.
- Deductive suite added WHOLE to the pre-push gate: 285 tests in 29s against
  smoke's 216 in 62s, so no coverage trade was needed.
- Smoke/CI parity assertion made bidirectional. It was one-directional, and had
  drifted.
- test_prior_surface_deduction_binding.py pins correction binding on the
  deduction path. The review's diagnosis did NOT reproduce — hash_surface moves
  in lockstep — so it pins what is there. Mutation-checked.
- Domain-keyed ADR index over 312 flat-numbered files, explicitly partial.
- Arc-close brief template, plus this arc's own brief filled in against it.

## Lanes 4 and 5 — two premises falsified by measurement, one of them mine

Math 4.2: baseline reproduced (correct=5 wrong=0 refused=495); all four named
cases traced to one seam with each gap isolated by one-variable probes. Then the
number that changes the recommendation: the gap blocking case 0000 affects 1
case in 500, the 'than' gap blocking 0001 affects 2. ADR-0251's prohibition on
per-case growth now rests on a count. No reader change made.

CGA: versor_condition is 0.22% of a turn, not the "~10x proof latency" I claimed
— that multiplied an isolated microbenchmark by a call count and compared it to
a single verdict's latency. The real cost is geometric_product at 33,986
calls/turn (~73%) via cga_inner in search paths. The obvious closed form is NOT
bit-exact (954/4000 in f32); backend.vault_recall's serial fold IS (3000/3000,
worst-rel 0) and is the correct target. cargo test could not run —
static.crates.io is denied by the sandbox network policy — so the Rust parity
question stays open and the typestate lane is carried forward, not shipped
uncompiled.

## Not landed: three lines owed to .github/workflows/smoke.yml

The CI smoke gate is narrower than the local one —
test_pack_draft_serve_boundary.py (ADR-0253 INV-33) has been local-only, unseen
because the parity pin checked one direction. The edit was authored and rejected
at push for lacking the `workflow` OAuth scope, so it is recorded as a named,
dated PENDING_IN_CI exception rather than dropped: the assertion still fires on
any new divergence, and a second guard fires once the three land.

[Verification]: pre-push gates all green — smoke 236 passed, warmed_session 10
passed, deductive 285 passed. Ratification 14, ADR index 5, CLI suites 10.
Grounding/epistemic sweep 741 passed 1 skipped. workbench-ui 598 passed across
73 files, tsc -b clean. capability index 11 passed, digest unchanged. Math
holdout correct=5 wrong=0 refused=495. Committed chain corpora byte-unchanged
after the tests that write to them.
Environment caveat: the repo pins requires-python ==3.12.13, which uv cannot
fetch for linux-x86_64, so `uv sync --locked` fails. All Python runs used a
scratch venv on 3.12.11 with declared deps — not the locked universe, not the
full ~12k suite. The pin was left untouched. Re-run on a 3.12.13 host before
treating this as merge evidence.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FduW6Krm3PPQv3P5iwBYtx
2026-07-25 04:51:15 +00:00

73 lines
3 KiB
Python

"""The domain-keyed ADR index must not rot into a page of dead links.
`docs/adr/INDEX-by-domain.md` exists because the corpus is at 312 files under
flat sequential numbering, and sequence records *when* a decision was made and
nothing about *what it governs*. An index whose links have decayed is worse
than no index, because it converts "I should grep" into "I already checked".
Deliberately narrow: this pins that every ADR the index names exists, and that
the index stays honest about being partial. It does not assert coverage of all
312 — the index says so itself, and a test demanding completeness would only
push someone to satisfy it with unread rows.
"""
from __future__ import annotations
import re
from pathlib import Path
import pytest
ADR_DIR = Path(__file__).resolve().parents[1] / "docs" / "adr"
INDEX = ADR_DIR / "INDEX-by-domain.md"
@pytest.fixture(scope="module")
def index_text() -> str:
return INDEX.read_text(encoding="utf-8")
def test_index_exists(index_text: str) -> None:
assert index_text.strip(), "the ADR domain index is empty"
def test_every_indexed_adr_resolves(index_text: str) -> None:
"""A dead link means an ADR was renamed and the index was not touched."""
links = re.findall(r"\]\(\./([^)]+)\)", index_text)
assert links, "no relative links parsed — the index format changed"
dead = sorted({link for link in links if not (ADR_DIR / link).exists()})
assert dead == [], f"index points at ADRs that do not exist: {dead}"
def test_index_covers_the_live_serving_arc(index_text: str) -> None:
"""The domains a next-arc session actually queries.
These are the ADRs behind capabilities that are ON in production: if one is
minted-and-forgotten out of the index, the index has stopped being the
thing you can trust for the live surface, which is its whole job.
"""
required = [
"ADR-0256", # deduction serving, earned license, flag ratified ON
"ADR-0262", # curriculum-grounded serving
"ADR-0263", # ratified-ledger bridge
"ADR-0255", # discovery-yield telemetry
"ADR-0142", # epistemic-state taxonomy
"ADR-0162", # workbench design system (the enum/badge contract)
"ADR-0251", # reader-arc prohibition on per-case pattern growth
]
missing = [adr for adr in required if adr not in index_text]
assert missing == [], f"live-arc ADRs absent from the domain index: {missing}"
def test_index_declares_its_own_partiality(index_text: str) -> None:
"""The honesty property. An index that silently claims completeness is a
trap; this one states its scope, and that statement is load-bearing."""
assert "not a complete index" in index_text.lower()
def test_all_six_deduction_bands_are_indexed(index_text: str) -> None:
"""v1b through v6-EX. The band cascade is the thing most likely to grow
without the index following, because each new band is one more ADR."""
for adr in ("ADR-0257", "ADR-0258", "ADR-0259", "ADR-0260", "ADR-0261"):
assert adr in index_text, f"{adr} (a shipped band) is not indexed"