core/generate/derivation/accumulate.py
Shay a719f1b58c
feat(adr-0184): extract semantic-state helper seam S1 (#490)
* feat(adr-0184): add semantic-state helper package

* feat(adr-0184): add referent binding helpers

* feat(adr-0184): add change cue helpers

* refactor(adr-0184): use semantic-state helpers in accumulation

* test(adr-0184): cover semantic-state helper guards
2026-05-30 08:36:02 -07:00

190 lines
9.1 KiB
Python

"""ADR-0178 GB-3b.1 — single-referent accumulation chaining.
The first cross-clause *comprehension* reading: one actor's quantity changes over
successive clauses (``Sam has 14 apples. He buys 9 more.`` -> ``14 + 9``). It is
the safe specialisation of the cross-clause sum that GB-3a's referent guard
correctly refuses wholesale (the ``Alice has 6 … Tom has 2 …`` hazard): we chain
across clauses **only** when (a) the later clause stays on the **same referent**
and (b) it carries a **licensed change cue** whose polarity is unambiguous.
Otherwise we refuse — the guard is generalised, never weakened.
Reading:
1. **Anchor** — clause 1 must establish exactly one quantity ``(actor, N, unit)``.
2. **Change steps** — each later quantity-bearing clause applies ``+ M`` (gain) or
``- M`` (loss) to the running total, where ``M`` is the clause's single grounded
quantity, taken **in the anchor's unit** (``9 more`` = 9 more *apples*; the unit
is inherited from the running total, which is what accumulation means).
3. **Gate** — the constructed chain runs through the unchanged self-verification
gate (grounding ∧ unit ∧ completeness ∧ uniqueness). The gate keeps
wrong=0; this only proposes a structurally-licensed candidate.
ADR-0184 S1 extracts the reusable referent and change-cue helpers into
``generate.derivation.state``. This module remains the public accumulation
composer surface; behavior is intentionally unchanged.
Sealed (no ``chat/`` import); deterministic; refuse-preferring.
"""
from __future__ import annotations
import re
from typing import Final
from generate.derivation.clauses import segment_clauses
from generate.derivation.extract import extract_quantities
from generate.derivation.model import GroundedDerivation, Quantity, Step
from generate.derivation.state.bind import (
continues_anchor_referent,
leading_subject_token,
)
from generate.derivation.state.change import (
classify_change_polarity,
select_change_cue,
)
from generate.derivation.verify import Resolution, select_self_verified
def _build_accumulation(
problem_text: str, *, drop_isolated_foreign: bool
) -> GroundedDerivation | None:
"""Construct the single-referent accumulation chain (ungated).
``drop_isolated_foreign`` (ADR-0182): when a change clause carries more than
one quantity, drop those with a **non-empty unit foreign to the anchor's unit**
(a candidate distractor — ``studies for 3 hours`` among ``pencils``) and proceed
if exactly one same-unit/unitless change remains. With the flag off this is the
strict GB-3b.1 reading (a multi-quantity change clause refuses), so
:func:`compose_accumulation` is byte-identical to its pre-ADR-0182 behavior.
The distractor-skip reading is **never committed alone** — it only ever enters
the pool to force a disagreement refusal (see :mod:`generate.derivation.pool`).
"""
clauses = segment_clauses(problem_text)
quantity_clauses = [c for c in clauses if extract_quantities(c)]
if len(quantity_clauses) < 2:
return None
anchor_clause, *change_clauses = quantity_clauses
anchor_quantities = extract_quantities(anchor_clause)
if len(anchor_quantities) != 1:
return None # the anchor must establish exactly one quantity (GB-3b.1 scope)
start = anchor_quantities[0]
anchor_subject = leading_subject_token(anchor_clause)
steps: list[Step] = []
for clause in change_clauses:
if not continues_anchor_referent(clause, anchor_subject):
return None # new named actor -> referent hazard -> refuse
change_quantities = list(extract_quantities(clause))
if drop_isolated_foreign and len(change_quantities) > 1:
change_quantities = [
q for q in change_quantities if not (q.unit and q.unit != start.unit)
]
if len(change_quantities) != 1:
return None # one change per clause (multi-change is GB-3b.2)
polarity = classify_change_polarity(clause)
if polarity is None:
return None # no unambiguous licensed change cue -> refuse
change = change_quantities[0]
# The change is in the running total's dimension ("9 more" = 9 more apples).
operand = Quantity(value=change.value, unit=start.unit, source_token=change.source_token)
op = "add" if polarity > 0 else "subtract"
steps.append(Step(op=op, operand=operand, cue=select_change_cue(clause, polarity)))
if not steps:
return None
return GroundedDerivation(start=start, steps=tuple(steps))
# ADR-0182 anchor-skip: sub-clause split on conjunctions. A single sentence can pack
# a state and its change ("Tom has 8 tickets and buys 4 more tickets") — the
# sentence-level segmenter (used everywhere; not changed) keeps them together. This
# finer split is *local* to the ungated candidate generator, so it cannot move
# GB-1/GB-2/serving/practice (which never call it). Lexeme-level (ADR-0165): it names
# coordinating conjunctions, it does not parse grammar.
_CONJUNCTION_SPLIT: Final[re.Pattern[str]] = re.compile(r",?\s+(?:and then|and|then)\s+")
def _sub_clauses(problem_text: str) -> list[str]:
"""Sentence clauses, each further split on coordinating conjunctions."""
parts: list[str] = []
for clause in segment_clauses(problem_text):
parts.extend(p.strip() for p in _CONJUNCTION_SPLIT.split(clause) if p.strip())
return parts
def _build_accumulation_anchor_skip(problem_text: str) -> GroundedDerivation | None:
"""ADR-0182 — accumulation over sub-clauses, skipping a leading all-foreign block.
Reads ``A train travels 60 mph for 2 hours. Tom has 8 tickets and buys 4 more
tickets.`` by skipping the (anchor-position) train block — its quantities cannot
seed an anchor (≠1 quantity) — and anchoring on the first single-quantity
sub-clause (``Tom has 8 tickets``), then chaining its conjunction-mate change
(``buys 4 more`` → +4). The skipped block's quantities go unused; the pool's
isolated-foreign exemption then classifies the reading ``exempt`` (commit-
ineligible), so it can only force a disagreement refusal, never commit. Ungated.
"""
sub_clauses = [(s, extract_quantities(s)) for s in _sub_clauses(problem_text)]
quantity_subs = [(s, qs) for s, qs in sub_clauses if qs]
if len(quantity_subs) < 2:
return None
# Anchor = first single-quantity sub-clause; leading non-anchorable (≠1
# quantity) sub-clauses are skipped (candidate distractor blocks).
anchor_idx = next((i for i, (_, qs) in enumerate(quantity_subs) if len(qs) == 1), None)
if anchor_idx is None:
return None
anchor_sub, anchor_qs = quantity_subs[anchor_idx]
start = anchor_qs[0]
anchor_subject = leading_subject_token(anchor_sub)
steps: list[Step] = []
for sub, qs in quantity_subs[anchor_idx + 1:]:
if not continues_anchor_referent(sub, anchor_subject):
return None # new named actor -> referent hazard -> refuse
if len(qs) != 1:
return None # one change per sub-clause (multi-change is GB-3b.2)
polarity = classify_change_polarity(sub)
if polarity is None:
return None # no unambiguous licensed change cue -> refuse
change = qs[0]
operand = Quantity(value=change.value, unit=start.unit, source_token=change.source_token)
op = "add" if polarity > 0 else "subtract"
steps.append(Step(op=op, operand=operand, cue=select_change_cue(sub, polarity)))
if not steps:
return None
return GroundedDerivation(start=start, steps=tuple(steps))
def compose_accumulation(problem_text: str) -> Resolution | None:
"""GB-3b.1 composer — single-referent gain/loss accumulation. Refuse-preferring.
The strict (commit) reading: it gates the no-distractor-skip derivation through
the unchanged self-verification gate. Behavior is byte-identical to pre-ADR-0182.
"""
derivation = _build_accumulation(problem_text, drop_isolated_foreign=False)
if derivation is None:
return None
return select_self_verified([derivation], problem_text, target_units=())
def accumulation_candidates(problem_text: str) -> tuple[GroundedDerivation, ...]:
"""ADR-0182 — the ungated accumulation readings for cross-composer pooling.
Three readings: the strict GB-3b.1 reading, the distractor-skip reading (drops an
isolated-foreign quantity in a multi-quantity change clause — 0014), and the
anchor-skip reading (skips a leading all-foreign block + reads a conjunction-mate
intra-sentence change — 0016). Ungated: the pool classifies each (``complete``
commits, ``exempt`` refuses-only) and the disagreement rule does the wrong=0 work.
Deterministic; de-dup is the pool's job.
"""
candidates: list[GroundedDerivation] = []
for drop in (False, True):
derivation = _build_accumulation(problem_text, drop_isolated_foreign=drop)
if derivation is not None:
candidates.append(derivation)
anchor_skip = _build_accumulation_anchor_skip(problem_text)
if anchor_skip is not None:
candidates.append(anchor_skip)
return tuple(candidates)