The Phase 1 multi-clause renderer (commit 63ffd88) produces grounded
content but reads mechanically because the subject lemma repeats in
every clause:
"Truth is what is true. Furthermore, truth belongs to cognition.truth.
In turn, truth grounds knowledge. Truth belongs to epistemic.ground.
Furthermore, truth belongs to logos.core. In turn, truth requires
evidence."
This is the literal articulation gap that motivated Phase 2 —
"reasoning at meaningful checkpoints during sentence construction
in order to have a stronger idea of what has come prior and is
already done to help better inform the next move." Between move
``i`` and move ``i+1`` the renderer now reflects on what subject
has just been established (the "focus") and renders the next clause
with a pronoun when the focus carries forward:
"Truth is what is true. Furthermore, it belongs to cognition.truth.
In turn, it grounds knowledge. It belongs to epistemic.ground.
Furthermore, it belongs to logos.core. In turn, it requires
evidence."
Rules
-----
* Track ``focus_subject`` across moves (the lemma most recently used
as a fact subject).
* When the next move's ``fact.subject`` is byte-equal to the current
focus → swap subject token to ``"it"``.
* When the next move's subject differs → preserve the explicit lemma
AND update focus. Topic shifts (TRANSITION moves; compound bridge
TRANSITION) thus reset the pronominalization channel naturally.
* Sentence-initial position (no connective): capitalised ``"It"``.
* Mid-sentence (after connective + comma): lowercase ``"it"``.
Doctrine alignment
------------------
Pure deterministic transformation of the existing plan; no new
content introduced, no LLM, no stochastic sampling. Same plan in →
same surface out, always. trace_hash invariance holds because:
* BRIEF-mode prompts short-circuit the planner before render
(commit 63ffd88's fast path) and are unaffected.
* Multi-move plans render to a deterministically-different string
that compute_trace_hash already folds in via ``surface``.
Wiring
------
* New ``reflective: bool = False`` parameter on ``render_plan``
(back-compat default — every existing call site and test pinning
Phase 1 output continues to work).
* ``_clause_for`` gains optional ``prior_focus_subject`` arg used by
the reflective path; unchanged default behaviour.
* Runtime hook ``chat.runtime._maybe_apply_discourse_planner``
passes ``reflective=True`` so the default chat path benefits.
Tests
-----
New ``tests/test_discourse_planner_reflective.py``:
* ``test_reflective_replaces_repeated_subject_with_it``
* ``test_reflective_handles_three_consecutive_same_subject_moves``
* ``test_reflective_capitalises_sentence_initial_pronoun``
* ``test_reflective_resets_focus_on_topic_shift``
* ``test_reflective_off_preserves_phase1_output``
* ``test_reflective_default_is_off_for_back_compat``
* ``test_reflective_is_deterministic``
* ``test_reflective_single_move_byte_identical_to_non_reflective``
(load-bearing — pins that the cognition eval stays byte-equal
across the Phase 2 flip because every cognition case is single-
move).
Verification
------------
pytest tests/test_discourse_planner_*.py 99/99 pass
(91 existing + 8 new)
pytest tests/test_articulation_demo.py all claims supported
pytest tests/test_narrative_example_intents.py pass
pytest tests/test_runtime_config.py pass
cognition eval OFF vs ON 45/45 surface byte-equal
45/45 trace_hash byte-equal
4/4 aggregate metrics
identical
core test --suite smoke 67/67 pass
core test --suite runtime 19/19 pass
Live demo (default config):
"What is knowledge?" → unchanged (BRIEF, fast-path)
"Tell me about
memory." → "Memory is what a person recalls.
Furthermore, it belongs to cognition.memory.
In turn, it requires recall."
"What is truth, and
why does it matter?"→ "Truth is what is true. Furthermore, it
belongs to cognition.truth. In turn, it
grounds knowledge. It belongs to
epistemic.ground. Furthermore, it belongs
to logos.core. In turn, it requires
evidence."
"Explain truth." → "Truth is what is true. Furthermore, it
belongs to cognition.truth. In turn, it
grounds knowledge."
Out of scope for this commit (future Phase 2 follow-ons):
* Connective rotation ("Furthermore" → "Also" → "In addition"
to break the repetitive cascade).
* Cross-clause de-duplication (skip moves whose ``new`` lemmas
were already introduced by an earlier move).
* Generalised pronoun selection beyond ``it`` (requires gender /
number / animacy signals the pack lexicon doesn't carry today).
898 lines
32 KiB
Python
898 lines
32 KiB
Python
"""Discourse planner contract — typed multi-move plan over grounded facts.
|
|
|
|
This module is **contract-only** in its initial landing: it defines the
|
|
frozen dataclasses, enums, canonical serialization, and the pure planner
|
|
function signature. It has **no runtime wiring**. Nothing in
|
|
``chat/*`` or any live ``ChatRuntime`` path imports from here yet.
|
|
|
|
Architectural rationale (see memory: feedback-design-fix-upstream-not-beside):
|
|
the existing ``realize_target`` already renders paragraph-scale output
|
|
when fed a multi-node ``PropositionGraph`` (``evals/discourse_paragraph``
|
|
passes at ``accuracy=1.0 / replay_determinism=1.0``). The bottleneck is
|
|
upstream — ``graph_planner.build_target`` receives one-node graphs from
|
|
runtime grounding. The fix is to lift grounding into a typed
|
|
``DiscoursePlan`` *before* the graph is built, so the realizer is fed
|
|
multi-node graphs from real runtime evidence rather than hand-authored
|
|
fixtures.
|
|
|
|
Pipeline target:
|
|
|
|
DialogueIntent + ResponseMode + GroundingBundle
|
|
-> DiscoursePlan (this module's output)
|
|
-> PropositionGraph (graph_planner, downstream)
|
|
-> ArticulationTarget (existing)
|
|
-> RealizedPlan (existing)
|
|
-> surface / trace_hash (existing)
|
|
|
|
Doctrine invariants this layer must satisfy:
|
|
|
|
* Every fact carries a source tag (``pack / teaching / vault / operator``)
|
|
— no decorative prose, no ungrounded transitions.
|
|
* Canonical serialization (alphabetical keys, separators stripped) so
|
|
two equal plans hash to the same bytes. This is the precondition
|
|
for folding ``DiscoursePlan`` into ``compute_trace_hash`` in a later
|
|
ADR — and is asserted by the companion contract tests *before* any
|
|
trace-hash change lands.
|
|
* Frozen dataclasses with ``slots=True``; ``tuple[...]`` containers
|
|
rather than ``list[...]``. Equality is by value.
|
|
* The planner function is **pure**: no I/O, no module-level mutable
|
|
state, no clock reads. Same ``(intent, mode, bundle)`` → same plan.
|
|
|
|
Reserved for follow-up ADRs (intentionally absent here):
|
|
|
|
* Classification of ``ResponseMode`` from raw input.
|
|
* Structured grounding accessors (``pack_grounded_facts``,
|
|
``teaching_grounded_chains``, ``cross_pack_grounded_chains``).
|
|
* Runtime wiring behind ``RuntimeConfig.discourse_planner=False``.
|
|
* Folding ``DiscoursePlan`` serialization into ``compute_trace_hash``.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from dataclasses import dataclass, field
|
|
from enum import Enum, unique
|
|
|
|
from generate.graph_planner import Relation
|
|
from generate.intent import (
|
|
CompoundIntent,
|
|
DialogueIntent,
|
|
IntentTag,
|
|
ResponseMode,
|
|
)
|
|
|
|
|
|
@unique
|
|
class FactSource(Enum):
|
|
"""Provenance of a ``GroundedFact``.
|
|
|
|
The enum order encodes canonical precedence used by
|
|
:func:`GroundingBundle.sorted_facts`:
|
|
|
|
pack < teaching < vault < operator
|
|
|
|
This mirrors in-pack precedence doctrine (ADR-0063 cross-pack
|
|
resolver: cognition pack consulted first) and the four-tier
|
|
inter-session memory architecture (ADR-0055: vault → audit →
|
|
reviewed corpus → ratified packs).
|
|
"""
|
|
|
|
PACK = "pack"
|
|
TEACHING = "teaching"
|
|
VAULT = "vault"
|
|
OPERATOR = "operator"
|
|
|
|
|
|
_FACT_SOURCE_PRIORITY: dict[FactSource, int] = {
|
|
FactSource.PACK: 0,
|
|
FactSource.TEACHING: 1,
|
|
FactSource.VAULT: 2,
|
|
FactSource.OPERATOR: 3,
|
|
}
|
|
|
|
|
|
@unique
|
|
class DiscourseMoveKind(Enum):
|
|
"""Five-move vocabulary the planner draws from.
|
|
|
|
* ``ANCHOR`` — establish the topic (always position 0).
|
|
* ``SUPPORT`` — add a domain/definitional fact about the anchor.
|
|
* ``RELATION`` — add a cause/verification/chain fact.
|
|
* ``TRANSITION`` — move topic to a related node (introduces new
|
|
``topic`` value distinct from prior move).
|
|
* ``CLOSURE`` — summarize endpoint or limitation.
|
|
"""
|
|
|
|
ANCHOR = "anchor"
|
|
SUPPORT = "support"
|
|
RELATION = "relation"
|
|
TRANSITION = "transition"
|
|
CLOSURE = "closure"
|
|
|
|
|
|
@dataclass(frozen=True, slots=True)
|
|
class GroundedFact:
|
|
"""Atomic, sourced, canonically-sortable fact triple.
|
|
|
|
``source_id`` is the provenance pointer inside ``source``:
|
|
pack lemma id, teaching chain id, vault entry hash, operator name.
|
|
It is preserved in the serialization so replay can re-locate the
|
|
fact deterministically.
|
|
"""
|
|
|
|
subject: str
|
|
predicate: str
|
|
obj: str
|
|
source: FactSource
|
|
source_id: str
|
|
|
|
def as_dict(self) -> dict[str, str]:
|
|
return {
|
|
"subject": self.subject,
|
|
"predicate": self.predicate,
|
|
"object": self.obj,
|
|
"source": self.source.value,
|
|
"source_id": self.source_id,
|
|
}
|
|
|
|
def sort_key(self) -> tuple[int, str, str, str, str]:
|
|
return (
|
|
_FACT_SOURCE_PRIORITY[self.source],
|
|
self.subject,
|
|
self.predicate,
|
|
self.obj,
|
|
self.source_id,
|
|
)
|
|
|
|
|
|
@dataclass(frozen=True, slots=True)
|
|
class GroundingBundle:
|
|
"""Collection of grounded facts available to the planner.
|
|
|
|
The bundle is *unordered* at construction time; callers obtain a
|
|
canonical view via :meth:`sorted_facts`. This decouples the input
|
|
of structured grounding accessors (which may iterate corpora in any
|
|
order) from the planner's deterministic output.
|
|
"""
|
|
|
|
facts: tuple[GroundedFact, ...] = ()
|
|
|
|
def sorted_facts(self) -> tuple[GroundedFact, ...]:
|
|
return tuple(sorted(self.facts, key=GroundedFact.sort_key))
|
|
|
|
def facts_by_source(self, source: FactSource) -> tuple[GroundedFact, ...]:
|
|
return tuple(f for f in self.sorted_facts() if f.source is source)
|
|
|
|
def is_empty(self) -> bool:
|
|
return len(self.facts) == 0
|
|
|
|
def as_dict(self) -> dict[str, object]:
|
|
return {"facts": tuple(f.as_dict() for f in self.sorted_facts())}
|
|
|
|
|
|
@dataclass(frozen=True, slots=True)
|
|
class DiscourseMove:
|
|
"""One step in a ``DiscoursePlan``.
|
|
|
|
``topic`` — the subject the move is *about* right now.
|
|
``given`` — tuple of lemmas already established by
|
|
prior moves (information shared with the
|
|
reader). Empty for ``ANCHOR``.
|
|
``new`` — lemmas introduced by this move.
|
|
``relation_to_previous`` — ``None`` for ``ANCHOR``; otherwise the
|
|
rhetorical relation linking back to the
|
|
immediately-prior move.
|
|
``fact`` — the ``GroundedFact`` this move surfaces;
|
|
``None`` for ``CLOSURE`` moves that only
|
|
summarize prior facts.
|
|
"""
|
|
|
|
kind: DiscourseMoveKind
|
|
topic: str
|
|
given: tuple[str, ...] = ()
|
|
new: tuple[str, ...] = ()
|
|
relation_to_previous: Relation | None = None
|
|
fact: GroundedFact | None = None
|
|
|
|
def as_dict(self) -> dict[str, object]:
|
|
return {
|
|
"kind": self.kind.value,
|
|
"topic": self.topic,
|
|
"given": tuple(self.given),
|
|
"new": tuple(self.new),
|
|
"relation_to_previous": (
|
|
self.relation_to_previous.value
|
|
if self.relation_to_previous is not None
|
|
else None
|
|
),
|
|
"fact": self.fact.as_dict() if self.fact is not None else None,
|
|
}
|
|
|
|
|
|
@dataclass(frozen=True, slots=True)
|
|
class DiscoursePlan:
|
|
"""Ordered, typed multi-move plan over a grounding bundle.
|
|
|
|
Equality and serialization are positional in ``moves``: the planner
|
|
is responsible for emitting moves in canonical order, and consumers
|
|
must not reorder them. ``as_dict`` is byte-stable across runs;
|
|
``to_json`` produces the exact bytes that a later ADR will hash into
|
|
``compute_trace_hash``.
|
|
"""
|
|
|
|
intent: DialogueIntent
|
|
mode: ResponseMode
|
|
moves: tuple[DiscourseMove, ...] = field(default_factory=tuple)
|
|
|
|
def is_empty(self) -> bool:
|
|
return len(self.moves) == 0
|
|
|
|
def anchor(self) -> DiscourseMove | None:
|
|
for m in self.moves:
|
|
if m.kind is DiscourseMoveKind.ANCHOR:
|
|
return m
|
|
return None
|
|
|
|
def topics(self) -> tuple[str, ...]:
|
|
seen: list[str] = []
|
|
for m in self.moves:
|
|
if m.topic not in seen:
|
|
seen.append(m.topic)
|
|
return tuple(seen)
|
|
|
|
def as_dict(self) -> dict[str, object]:
|
|
return {
|
|
"intent": {
|
|
"tag": self.intent.tag.value,
|
|
"subject": self.intent.subject,
|
|
"secondary_subject": self.intent.secondary_subject,
|
|
"object": self.intent.object,
|
|
"relation": self.intent.relation,
|
|
"negated": self.intent.negated,
|
|
"frame": self.intent.frame,
|
|
},
|
|
"mode": self.mode.value,
|
|
"moves": tuple(m.as_dict() for m in self.moves),
|
|
}
|
|
|
|
def to_json(self) -> str:
|
|
return json.dumps(self.as_dict(), sort_keys=True, separators=(",", ":"))
|
|
|
|
|
|
def _move_budget(mode: ResponseMode) -> tuple[int, int]:
|
|
"""Return ``(min_moves, max_moves)`` for *mode*.
|
|
|
|
BRIEF → exactly 1 (ANCHOR only) so flag-on rendering of a
|
|
single-sentence pack-grounded surface stays at parity
|
|
with the existing string composer.
|
|
EXPLAIN → up to 3 (ANCHOR + SUPPORT + RELATION).
|
|
PARAGRAPH → up to 5 (ANCHOR + SUPPORT + RELATION + TRANSITION +
|
|
CLOSURE).
|
|
EXAMPLE → up to 3 (ANCHOR + RELATION + CLOSURE) — instance-shape
|
|
surfacing through the reverse-chain view.
|
|
WALKTHROUGH→ deferred (needs operator-chain semantics), capped at 1.
|
|
"""
|
|
|
|
return _MODE_BUDGETS.get(mode, (1, 1))
|
|
|
|
|
|
_MODE_BUDGETS: dict[ResponseMode, tuple[int, int]] = {
|
|
ResponseMode.BRIEF: (1, 1),
|
|
ResponseMode.EXPLAIN: (1, 3),
|
|
ResponseMode.PARAGRAPH: (1, 5),
|
|
ResponseMode.EXAMPLE: (1, 3),
|
|
# WALKTHROUGH v1: ≤ 4 hops along the teaching-chain graph. The
|
|
# planner walks ``(subject, *, object) → (object, *, *)``
|
|
# starting from the anchor and follows up to three additional
|
|
# hops (4 moves total including the anchor). When no chain is
|
|
# available the v1 implementation falls back to the expository
|
|
# plan shape (EXPLAIN budget) rather than fabricating steps —
|
|
# operator-chain WALKTHROUGH is deferred to a follow-up ADR.
|
|
ResponseMode.WALKTHROUGH: (1, 4),
|
|
}
|
|
|
|
_WALKTHROUGH_MAX_HOPS = 3 # 3 hops after the anchor = 4 moves total
|
|
|
|
|
|
def _select_anchor(
|
|
intent: DialogueIntent,
|
|
bundle: GroundingBundle,
|
|
) -> GroundedFact | None:
|
|
"""Pick the anchor fact: a pack ``is_defined_as`` for the subject if
|
|
available, otherwise the first canonical pack fact, otherwise the
|
|
first canonical fact of any source.
|
|
"""
|
|
|
|
if bundle.is_empty():
|
|
return None
|
|
subject = intent.subject.strip().lower()
|
|
pack_facts = bundle.facts_by_source(FactSource.PACK)
|
|
# Prefer is_defined_as on the subject (carries the gloss).
|
|
for fact in pack_facts:
|
|
if fact.subject == subject and fact.predicate == "is_defined_as":
|
|
return fact
|
|
# Fall back to the first canonical pack fact on the subject.
|
|
for fact in pack_facts:
|
|
if fact.subject == subject:
|
|
return fact
|
|
# Fall back to the first canonical fact of any source.
|
|
for fact in bundle.sorted_facts():
|
|
return fact
|
|
return None
|
|
|
|
|
|
def _select_support(
|
|
anchor: GroundedFact,
|
|
bundle: GroundingBundle,
|
|
) -> GroundedFact | None:
|
|
"""Pick a SUPPORT fact distinct from the anchor: a pack ``belongs_to``
|
|
on the anchor's subject if available.
|
|
"""
|
|
|
|
for fact in bundle.facts_by_source(FactSource.PACK):
|
|
if fact == anchor:
|
|
continue
|
|
if fact.subject != anchor.subject:
|
|
continue
|
|
if fact.predicate == "belongs_to":
|
|
return fact
|
|
# Any other pack fact on the same subject.
|
|
for fact in bundle.facts_by_source(FactSource.PACK):
|
|
if fact == anchor or fact.subject != anchor.subject:
|
|
continue
|
|
return fact
|
|
return None
|
|
|
|
|
|
def _select_relation(
|
|
anchor: GroundedFact,
|
|
bundle: GroundingBundle,
|
|
*,
|
|
exclude: frozenset[tuple[int, str, str, str, str]] = frozenset(),
|
|
) -> GroundedFact | None:
|
|
"""Pick a RELATION fact: a teaching/cross-pack chain rooted on the
|
|
anchor's subject.
|
|
"""
|
|
|
|
for fact in bundle.facts_by_source(FactSource.TEACHING):
|
|
if fact.sort_key() in exclude:
|
|
continue
|
|
if fact.subject == anchor.subject:
|
|
return fact
|
|
return None
|
|
|
|
|
|
def _select_transition(
|
|
relation: GroundedFact,
|
|
bundle: GroundingBundle,
|
|
*,
|
|
exclude: frozenset[tuple[int, str, str, str, str]] = frozenset(),
|
|
) -> GroundedFact | None:
|
|
"""Pick a TRANSITION fact: a teaching/cross-pack chain rooted on the
|
|
RELATION's object (the topic shifts to the chain's tail).
|
|
"""
|
|
|
|
target = relation.obj.strip().lower()
|
|
if not target:
|
|
return None
|
|
for fact in bundle.facts_by_source(FactSource.TEACHING):
|
|
if fact.sort_key() in exclude:
|
|
continue
|
|
if fact.subject == target:
|
|
return fact
|
|
# No same-source continuation — try any pack fact on the new topic
|
|
# (lets the closure step still describe the transitioned topic).
|
|
for fact in bundle.facts_by_source(FactSource.PACK):
|
|
if fact.sort_key() in exclude:
|
|
continue
|
|
if fact.subject == target:
|
|
return fact
|
|
return None
|
|
|
|
|
|
def _plan_walkthrough(
|
|
intent: DialogueIntent,
|
|
mode: ResponseMode,
|
|
bundle: GroundingBundle,
|
|
anchor_fact: GroundedFact,
|
|
moves: list[DiscourseMove],
|
|
used: set[tuple[int, str, str, str, str]],
|
|
) -> DiscoursePlan:
|
|
"""WALKTHROUGH v1 — sequential teaching-chain walk.
|
|
|
|
Starting from the anchor's subject, follow up to
|
|
``_WALKTHROUGH_MAX_HOPS`` hops along teaching-chain edges
|
|
``(subject, *, object) → (object, *, *)``. Each hop is one
|
|
``RELATION`` move; the final hop becomes a ``CLOSURE`` move.
|
|
|
|
Cycle-safe: never re-emits a fact already in *used*. Bounded
|
|
depth. When the substrate has no chain rooted on the anchor (or
|
|
the walk stalls before any hop), the v1 implementation falls
|
|
back to the expository (EXPLAIN) plan shape rather than
|
|
fabricating walk steps.
|
|
"""
|
|
|
|
given_lemmas: list[str] = [anchor_fact.subject]
|
|
current_subject = anchor_fact.subject
|
|
|
|
walked_facts: list[GroundedFact] = []
|
|
for _hop in range(_WALKTHROUGH_MAX_HOPS):
|
|
next_fact: GroundedFact | None = None
|
|
for fact in bundle.facts_by_source(FactSource.TEACHING):
|
|
if fact.sort_key() in used:
|
|
continue
|
|
if fact.subject == current_subject:
|
|
next_fact = fact
|
|
break
|
|
if next_fact is None:
|
|
break
|
|
walked_facts.append(next_fact)
|
|
used.add(next_fact.sort_key())
|
|
current_subject = next_fact.obj.strip().lower()
|
|
|
|
if not walked_facts:
|
|
# No teaching-chain substrate — fall back to expository plan
|
|
# rather than fabricating walk steps. Anchor + (SUPPORT) +
|
|
# (RELATION) shape preserves the "walkthrough" intent without
|
|
# claiming a process the substrate cannot support.
|
|
return _plan_walkthrough_fallback(
|
|
intent, bundle, anchor_fact, moves, used
|
|
)
|
|
|
|
# Emit walked facts as RELATION moves with the final one becoming
|
|
# CLOSURE so the rendered surface terminates explicitly.
|
|
for idx, fact in enumerate(walked_facts):
|
|
kind = (
|
|
DiscourseMoveKind.CLOSURE
|
|
if idx == len(walked_facts) - 1
|
|
else DiscourseMoveKind.RELATION
|
|
)
|
|
moves.append(
|
|
DiscourseMove(
|
|
kind=kind,
|
|
topic=fact.subject,
|
|
given=tuple(given_lemmas),
|
|
new=(fact.obj,),
|
|
relation_to_previous=Relation.SEQUENCE,
|
|
fact=fact,
|
|
)
|
|
)
|
|
given_lemmas.append(fact.obj)
|
|
|
|
return DiscoursePlan(intent=intent, mode=mode, moves=tuple(moves))
|
|
|
|
|
|
def _plan_walkthrough_fallback(
|
|
intent: DialogueIntent,
|
|
bundle: GroundingBundle,
|
|
anchor_fact: GroundedFact,
|
|
moves: list[DiscourseMove],
|
|
used: set[tuple[int, str, str, str, str]],
|
|
) -> DiscoursePlan:
|
|
"""Fallback shape when no teaching chain is available for
|
|
WALKTHROUGH. Emits an ANCHOR + (SUPPORT) plan — the
|
|
``ResponseMode`` stays WALKTHROUGH on the resulting plan so
|
|
callers can tell the planner attempted a walkthrough but
|
|
degraded honestly.
|
|
"""
|
|
|
|
given_lemmas: list[str] = [anchor_fact.subject]
|
|
support_fact = _select_support(anchor_fact, bundle)
|
|
if support_fact is not None and support_fact.sort_key() not in used:
|
|
moves.append(
|
|
DiscourseMove(
|
|
kind=DiscourseMoveKind.SUPPORT,
|
|
topic=support_fact.subject,
|
|
given=tuple(given_lemmas),
|
|
new=(support_fact.obj,),
|
|
relation_to_previous=Relation.ELABORATION,
|
|
fact=support_fact,
|
|
)
|
|
)
|
|
used.add(support_fact.sort_key())
|
|
return DiscoursePlan(
|
|
intent=intent, mode=ResponseMode.WALKTHROUGH, moves=tuple(moves)
|
|
)
|
|
|
|
|
|
def plan_discourse(
|
|
intent: DialogueIntent,
|
|
mode: ResponseMode,
|
|
bundle: GroundingBundle,
|
|
*,
|
|
_exclude_facts: frozenset[tuple[int, str, str, str, str]] = frozenset(),
|
|
) -> DiscoursePlan:
|
|
"""Deterministic discourse planner.
|
|
|
|
Selects ordered moves from *bundle* according to *mode*'s budget
|
|
and the canonical anchor/support/relation/transition/closure
|
|
vocabulary. Pure: same ``(intent, mode, bundle)`` always produces
|
|
the same plan; no I/O, no clock reads, no module-level state.
|
|
|
|
Empty bundles produce an empty plan rather than raising — callers
|
|
fall through to the existing single-sentence composer path so the
|
|
runtime is always safe to call with the flag on.
|
|
|
|
Mode rules:
|
|
|
|
* ``BRIEF`` — ANCHOR only. Equivalent to today's single-
|
|
sentence pack-grounded surface.
|
|
* ``EXPLAIN`` — ANCHOR + SUPPORT + RELATION (up to 3 moves).
|
|
* ``PARAGRAPH`` — ANCHOR + SUPPORT + RELATION + TRANSITION +
|
|
CLOSURE (up to 5 moves).
|
|
* ``EXAMPLE`` — ANCHOR + RELATION + CLOSURE (up to 3 moves).
|
|
The relation is selected from the reverse-chain
|
|
view via the bundle (callers supply
|
|
cross-pack `include_object_view=True`).
|
|
* ``WALKTHROUGH`` — deferred to a follow-up ADR; falls back to
|
|
BRIEF shape so the planner is total.
|
|
"""
|
|
|
|
if bundle.is_empty():
|
|
return DiscoursePlan(intent=intent, mode=mode, moves=())
|
|
|
|
# Filter out facts the caller has already used in prior sub-plans.
|
|
if _exclude_facts:
|
|
bundle = GroundingBundle(
|
|
facts=tuple(
|
|
f for f in bundle.facts if f.sort_key() not in _exclude_facts
|
|
)
|
|
)
|
|
if bundle.is_empty():
|
|
return DiscoursePlan(intent=intent, mode=mode, moves=())
|
|
|
|
anchor_fact = _select_anchor(intent, bundle)
|
|
if anchor_fact is None:
|
|
return DiscoursePlan(intent=intent, mode=mode, moves=())
|
|
|
|
moves: list[DiscourseMove] = [
|
|
DiscourseMove(
|
|
kind=DiscourseMoveKind.ANCHOR,
|
|
topic=anchor_fact.subject,
|
|
given=(),
|
|
new=(anchor_fact.subject,),
|
|
relation_to_previous=None,
|
|
fact=anchor_fact,
|
|
)
|
|
]
|
|
used: set[tuple[int, str, str, str, str]] = {anchor_fact.sort_key()}
|
|
_, max_moves = _move_budget(mode)
|
|
|
|
# WALKTHROUGH v1 — sequential teaching-chain walk.
|
|
if mode is ResponseMode.WALKTHROUGH:
|
|
return _plan_walkthrough(intent, mode, bundle, anchor_fact, moves, used)
|
|
|
|
if max_moves <= 1:
|
|
return DiscoursePlan(intent=intent, mode=mode, moves=tuple(moves))
|
|
|
|
given_lemmas: list[str] = [anchor_fact.subject]
|
|
last_topic = anchor_fact.subject
|
|
|
|
# SUPPORT (EXPLAIN, PARAGRAPH — not EXAMPLE which goes anchor→relation).
|
|
if mode in (ResponseMode.EXPLAIN, ResponseMode.PARAGRAPH):
|
|
support_fact = _select_support(anchor_fact, bundle)
|
|
if support_fact is not None:
|
|
moves.append(
|
|
DiscourseMove(
|
|
kind=DiscourseMoveKind.SUPPORT,
|
|
topic=support_fact.subject,
|
|
given=tuple(given_lemmas),
|
|
new=(support_fact.obj,),
|
|
relation_to_previous=Relation.ELABORATION,
|
|
fact=support_fact,
|
|
)
|
|
)
|
|
used.add(support_fact.sort_key())
|
|
given_lemmas.append(support_fact.obj)
|
|
last_topic = support_fact.subject
|
|
if len(moves) >= max_moves:
|
|
return DiscoursePlan(
|
|
intent=intent, mode=mode, moves=tuple(moves)
|
|
)
|
|
|
|
# RELATION.
|
|
relation_fact = _select_relation(
|
|
anchor_fact, bundle, exclude=frozenset(used)
|
|
)
|
|
if relation_fact is not None:
|
|
moves.append(
|
|
DiscourseMove(
|
|
kind=DiscourseMoveKind.RELATION,
|
|
topic=relation_fact.subject,
|
|
given=tuple(given_lemmas),
|
|
new=(relation_fact.obj,),
|
|
relation_to_previous=Relation.CAUSE,
|
|
fact=relation_fact,
|
|
)
|
|
)
|
|
used.add(relation_fact.sort_key())
|
|
given_lemmas.append(relation_fact.obj)
|
|
last_topic = relation_fact.subject
|
|
if len(moves) >= max_moves:
|
|
return DiscoursePlan(
|
|
intent=intent, mode=mode, moves=tuple(moves)
|
|
)
|
|
|
|
# TRANSITION (PARAGRAPH only).
|
|
transition_fact: GroundedFact | None = None
|
|
if mode is ResponseMode.PARAGRAPH and relation_fact is not None:
|
|
transition_fact = _select_transition(
|
|
relation_fact, bundle, exclude=frozenset(used)
|
|
)
|
|
if transition_fact is not None:
|
|
moves.append(
|
|
DiscourseMove(
|
|
kind=DiscourseMoveKind.TRANSITION,
|
|
topic=transition_fact.subject,
|
|
given=tuple(given_lemmas),
|
|
new=(transition_fact.obj,),
|
|
relation_to_previous=Relation.SEQUENCE,
|
|
fact=transition_fact,
|
|
)
|
|
)
|
|
used.add(transition_fact.sort_key())
|
|
given_lemmas.append(transition_fact.obj)
|
|
last_topic = transition_fact.subject
|
|
if len(moves) >= max_moves:
|
|
return DiscoursePlan(
|
|
intent=intent, mode=mode, moves=tuple(moves)
|
|
)
|
|
|
|
# CLOSURE (PARAGRAPH, EXAMPLE) — summarize the latest topic. No
|
|
# new fact (fact=None); closure carries the prior given lemmas
|
|
# forward without introducing new content.
|
|
if mode in (ResponseMode.PARAGRAPH, ResponseMode.EXAMPLE):
|
|
moves.append(
|
|
DiscourseMove(
|
|
kind=DiscourseMoveKind.CLOSURE,
|
|
topic=last_topic,
|
|
given=tuple(given_lemmas),
|
|
new=(),
|
|
relation_to_previous=Relation.ELABORATION,
|
|
fact=None,
|
|
)
|
|
)
|
|
|
|
return DiscoursePlan(intent=intent, mode=mode, moves=tuple(moves))
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Compound discourse planning
|
|
# ---------------------------------------------------------------------------
|
|
#
|
|
# When a prompt is decomposed into multiple ``DialogueIntent`` parts
|
|
# by ``classify_compound_intent``, each part is planned independently
|
|
# and the resulting sub-plans are concatenated in *source order*. No
|
|
# cross-part re-sorting — determinism comes from the per-part canonical
|
|
# selection inside ``plan_discourse`` plus the deterministic
|
|
# decomposition order from the classifier.
|
|
#
|
|
# A bridging ``TRANSITION`` move is inserted between consecutive
|
|
# sub-plans so the rendered surface has an explicit handoff between
|
|
# parts. Topic for the bridge is taken from the next sub-plan's
|
|
# anchor; ``given`` carries the prior part's topics forward.
|
|
|
|
|
|
def plan_compound_discourse(
|
|
compound: CompoundIntent,
|
|
mode: ResponseMode,
|
|
bundles: tuple[GroundingBundle, ...],
|
|
) -> DiscoursePlan:
|
|
"""Plan a multi-part response from a decomposed ``CompoundIntent``.
|
|
|
|
``bundles`` must have one ``GroundingBundle`` per part, in the same
|
|
order as ``compound.parts``. Each part is planned with
|
|
:func:`plan_discourse`; sub-plans are concatenated preserving
|
|
source order with a ``TRANSITION`` move bridging consecutive parts.
|
|
|
|
Falls back to the single-part :func:`plan_discourse` shape when
|
|
``compound`` carries exactly one part — byte-equivalent to calling
|
|
``plan_discourse(compound.primary, mode, bundles[0])`` directly.
|
|
|
|
The returned plan's ``intent`` is the primary part; downstream
|
|
consumers that only need a single ``DialogueIntent`` (e.g. the
|
|
runtime surface tag) still get a meaningful value.
|
|
"""
|
|
|
|
if len(compound.parts) != len(bundles):
|
|
raise ValueError(
|
|
f"plan_compound_discourse: parts ({len(compound.parts)}) and "
|
|
f"bundles ({len(bundles)}) must align"
|
|
)
|
|
|
|
if not compound.is_compound():
|
|
return plan_discourse(compound.primary, mode, bundles[0])
|
|
|
|
moves: list[DiscourseMove] = []
|
|
prior_topics: list[str] = []
|
|
used_facts: set[tuple[int, str, str, str, str]] = set()
|
|
for idx, (part, bundle) in enumerate(zip(compound.parts, bundles)):
|
|
sub_plan = plan_discourse(
|
|
part, mode, bundle, _exclude_facts=frozenset(used_facts)
|
|
)
|
|
if sub_plan.is_empty():
|
|
continue
|
|
for sub_move in sub_plan.moves:
|
|
if sub_move.fact is not None:
|
|
used_facts.add(sub_move.fact.sort_key())
|
|
if moves:
|
|
# Bridge from the previous sub-plan to this one. Topic is
|
|
# the next anchor's topic; given carries the prior topics
|
|
# forward so the rendered TRANSITION clause reads naturally.
|
|
next_anchor = sub_plan.anchor()
|
|
bridge_topic = (
|
|
next_anchor.topic
|
|
if next_anchor is not None
|
|
else part.subject.strip().lower()
|
|
)
|
|
moves.append(
|
|
DiscourseMove(
|
|
kind=DiscourseMoveKind.TRANSITION,
|
|
topic=bridge_topic,
|
|
given=tuple(prior_topics),
|
|
new=(bridge_topic,) if bridge_topic else (),
|
|
relation_to_previous=Relation.SEQUENCE,
|
|
fact=None,
|
|
)
|
|
)
|
|
moves.extend(sub_plan.moves)
|
|
for topic in sub_plan.topics():
|
|
if topic not in prior_topics:
|
|
prior_topics.append(topic)
|
|
_ = idx # source-order index preserved by enumerate
|
|
|
|
if not moves:
|
|
return DiscoursePlan(intent=compound.primary, mode=mode, moves=())
|
|
|
|
return DiscoursePlan(
|
|
intent=compound.primary,
|
|
mode=mode,
|
|
moves=tuple(moves),
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Plan rendering — deterministic multi-clause surface
|
|
# ---------------------------------------------------------------------------
|
|
#
|
|
# A first renderer that joins each move's grounded fact into a clause
|
|
# using fixed connectives. Step 5 of the discourse-planner sequencing
|
|
# uses this for the initial runtime wiring; a follow-up ADR will route
|
|
# plans through the existing PropositionGraph → realize_target spine.
|
|
#
|
|
# Every visible token in the rendered surface is either:
|
|
# * the subject/object of a GroundedFact (verbatim from pack lexicon
|
|
# or reviewed teaching corpus),
|
|
# * the gloss or semantic_domains string of a pack fact (verbatim),
|
|
# * a fixed-template connective from the table below.
|
|
# No synthesis, no LLM, no approximation.
|
|
|
|
_PREDICATE_HUMANIZE: dict[str, str] = {
|
|
"is_defined_as": "is",
|
|
"belongs_to": "belongs to",
|
|
}
|
|
|
|
|
|
def _humanize_predicate(predicate: str) -> str:
|
|
return _PREDICATE_HUMANIZE.get(predicate, predicate.replace("_", " "))
|
|
|
|
|
|
def _clause_for(
|
|
move: DiscourseMove, *, prior_focus_subject: str | None = None,
|
|
) -> str | None:
|
|
"""Render a single move into one declarative clause, or ``None``
|
|
when the move carries no fact (e.g. CLOSURE without summary fact).
|
|
|
|
When ``prior_focus_subject`` is supplied AND equals ``move.fact.subject``
|
|
byte-for-byte, the clause is emitted with ``it`` as subject instead
|
|
of repeating the lemma — the Phase 2 reflective rendering hook.
|
|
This is purely opt-in; ``render_plan(plan)`` without the
|
|
``reflective=True`` switch never sets this argument and behaviour is
|
|
byte-identical to Phase 1.
|
|
"""
|
|
|
|
fact = move.fact
|
|
if fact is None:
|
|
return None
|
|
|
|
subject_token = fact.subject
|
|
if (
|
|
prior_focus_subject is not None
|
|
and fact.subject == prior_focus_subject
|
|
):
|
|
subject_token = "it"
|
|
|
|
if move.kind is DiscourseMoveKind.ANCHOR and fact.predicate == "is_defined_as":
|
|
return f"{subject_token} is {fact.obj}"
|
|
if fact.predicate == "is_defined_as":
|
|
return f"{subject_token} is {fact.obj}"
|
|
if fact.predicate == "belongs_to":
|
|
return f"{subject_token} belongs to {fact.obj}"
|
|
return (
|
|
f"{subject_token} {_humanize_predicate(fact.predicate)} {fact.obj}"
|
|
)
|
|
|
|
|
|
_MOVE_CONNECTIVE: dict[DiscourseMoveKind, str] = {
|
|
DiscourseMoveKind.ANCHOR: "",
|
|
DiscourseMoveKind.SUPPORT: "Furthermore, ",
|
|
DiscourseMoveKind.RELATION: "In turn, ",
|
|
DiscourseMoveKind.TRANSITION: "Consequently, ",
|
|
DiscourseMoveKind.CLOSURE: "",
|
|
}
|
|
|
|
|
|
def render_plan(plan: DiscoursePlan, *, reflective: bool = False) -> str:
|
|
"""Render a :class:`DiscoursePlan` as a deterministic multi-clause
|
|
surface terminated with periods.
|
|
|
|
Empty plans render to the empty string — callers must check
|
|
``plan.is_empty()`` and fall back to their existing path before
|
|
calling this. Single-move plans render as a single sentence
|
|
byte-equivalent to today's pack-grounded surface for the same fact.
|
|
|
|
Determinism: ``render_plan(p) == render_plan(p)`` for any plan
|
|
``p``; the function is pure.
|
|
|
|
``reflective`` (Phase 2 hook, opt-in):
|
|
|
|
When ``True``, the renderer threads a tracked ``focus_subject``
|
|
across moves: the first non-None clause sets the focus, and every
|
|
subsequent move whose ``fact.subject`` equals the current focus
|
|
is rendered with ``it`` as subject instead of repeating the lemma.
|
|
A move whose subject differs from the prior focus is treated as
|
|
a topic shift — the explicit subject is preserved and focus is
|
|
updated to the new lemma so following same-subject moves
|
|
pronominalize against the new focus.
|
|
|
|
Default is ``False`` for back-compat with every existing call
|
|
site and test pinning the Phase-1 byte-equivalent output. The
|
|
runtime adapter (``chat.runtime._maybe_apply_discourse_planner``)
|
|
passes ``reflective=True``.
|
|
"""
|
|
|
|
if plan.is_empty():
|
|
return ""
|
|
clauses: list[str] = []
|
|
focus_subject: str | None = None
|
|
for idx, move in enumerate(plan.moves):
|
|
prior_focus = focus_subject if reflective else None
|
|
clause = _clause_for(move, prior_focus_subject=prior_focus)
|
|
if clause is None:
|
|
continue
|
|
if idx == 0:
|
|
head = clause[0].upper() + clause[1:] if clause else clause
|
|
clauses.append(f"{head}.")
|
|
if move.fact is not None:
|
|
focus_subject = move.fact.subject
|
|
continue
|
|
connective = _MOVE_CONNECTIVE.get(move.kind, "")
|
|
if connective:
|
|
head = clause[0].lower() + clause[1:] if clause else clause
|
|
clauses.append(f"{connective}{head}.")
|
|
else:
|
|
head = clause[0].upper() + clause[1:] if clause else clause
|
|
clauses.append(f"{head}.")
|
|
# Update focus to this move's subject so the next iteration
|
|
# can pronominalize against it (or detect topic shift).
|
|
if move.fact is not None:
|
|
focus_subject = move.fact.subject
|
|
return " ".join(clauses)
|
|
|
|
|
|
__all__ = [
|
|
"CompoundIntent",
|
|
"DiscourseMove",
|
|
"DiscourseMoveKind",
|
|
"DiscoursePlan",
|
|
"DialogueIntent",
|
|
"FactSource",
|
|
"GroundedFact",
|
|
"GroundingBundle",
|
|
"IntentTag",
|
|
"Relation",
|
|
"ResponseMode",
|
|
"plan_compound_discourse",
|
|
"plan_discourse",
|
|
"render_plan",
|
|
]
|