core/generate/operators.py
Shay 948cca44e6 feat(phase3): multi_relation_walk closes Phase 3 v1 to 10/10 splits
Closes the mixed_relation_* (multi-step-reasoning) and composed_predicate
(compositionality) residuals with a single new operator plus a small
intent-classifier loosening. Both residuals shared an underlying shape:
walk any outgoing relation edge from the head, regardless of which
relation predicate appears at each step.

generate/operators.py:
  multi_relation_walk(triples, head, *, max_hops=5) -> WalkResult
    Walks any outgoing edge from head, accumulating a path across
    mixed relation types. Returns WalkResult with relation="<mixed>"
    so trace_hash records the cross-relation provenance explicitly.
    Deterministic, cycle-safe, first-write-wins on duplicate heads
    (across any relation).

generate/intent.py:
  _TRANSITIVE_QUERY_RE relaxed from a closed verb enumeration to any
  single verb-like word. "What does X (any verb)?" now routes to
  TRANSITIVE_QUERY consistently; unrecognised relations are handled
  by the pipeline's multi_relation_walk fallback rather than falling
  through to UNKNOWN. Verified no regression on 30 intent / realizer
  tests.

core/cognition/pipeline.py:
  _maybe_transitive_walk now does precision-first dispatch on
  TRANSITIVE_QUERY: try transitive_walk(relation) literal-match
  first, fall back to multi_relation_walk only when the literal
  walk returns a singleton. DEFINITION intents do not fall back
  (would be too permissive for "What is X?").

tests/test_inference_operators.py: 6 new TestMultiRelationWalk
tests covering single-relation pass-through, cross-relation walks,
cycle termination, max_hops truncation, and determinism.

Phase 3 v1 re-score:

  lane                       split        v1     v2     v3 (now)
  inference-closure          public       0.0    1.0    1.0  pass
  inference-closure          holdouts     0.0    1.0    1.0  pass
  multi-step-reasoning       public       0.0    0.73   1.0  pass
  multi-step-reasoning       holdouts     0.0    0.80   1.0  pass
  compositionality           public       0.06   0.31   0.69 pass
  compositionality           holdouts     0.0    0.30   0.80 pass
  cross-domain-transfer      public       0.0    1.0    1.0  pass
  cross-domain-transfer      holdouts     0.0    1.0    1.0  pass
  introspection              public       0.0    1.0    1.0  pass
  introspection              holdouts     0.0    1.0    1.0  pass

PHASE 3 v1 IS COMPLETE: 10 of 10 splits passing. Phase 3 exit gate
(>= 2 lanes passing v1 by phase exit) is satisfied five times over.
Foundation guarantees (premises_stored_rate, replay_determinism)
remain 1.0 across all lanes. Trace_hash bit-stability preserved
with operator invocation records folded in per ADR-0018.

Compositionality public at 0.69 / holdouts at 0.80 - the residual
failures are the novel_pair_under_seen_relation / novel_relation_on_seen_pair
cases whose contract authoring is itself ambiguous (the leakage
check in the v1 contract fires by design on those patterns). Those
are contract-refinement candidates for v2 of that lane, not
engineering work. Overall_pass threshold (>= 0.50) is comfortably
met on both splits.

CLI suites smoke / cognition / teaching / packs all pass; 53
operator+teaching+pipeline tests green; no regression.
2026-05-16 15:24:44 -07:00

204 lines
6.4 KiB
Python

"""Typed deterministic operators over CORE's typed state (ADR-0018).
Two operators land here as the Phase 3 v2 inference-depth bundle. Both
are pure functions; both are bounded by a ``max_hops`` cap so they
cannot diverge; both produce outputs that round-trip through the
existing pipeline (entities, vault entries).
Operator-invocation records are folded into ``trace_hash`` (see
``core/cognition/trace.py``) so any turn that calls an operator stays
bit-for-bit replay-deterministic.
"""
from __future__ import annotations
from dataclasses import dataclass
_DEFAULT_MAX_HOPS = 5
@dataclass(frozen=True, slots=True)
class WalkResult:
"""A typed relation-walk result.
``path`` is the sequence of entities visited, starting from the head
and ending at the deepest entity reachable under the requested
relation. Length 1 means no edges were found. Length > 1 means a
chain was traversed.
``relation`` and ``head`` are echoed back so the result is self-
describing for downstream wiring and trace_hash inclusion.
``truncated`` is True when the walk hit the max_hops bound before
exhausting the path; consumers should treat that as a soft signal
that a longer chain may exist in the underlying store.
"""
head: str
relation: str
path: tuple[str, ...]
truncated: bool
def as_dict(self) -> dict[str, object]:
return {
"head": self.head,
"relation": self.relation,
"path": list(self.path),
"truncated": self.truncated,
}
def _normalize(token: str) -> str:
return token.strip().lower()
def transitive_walk(
triples: tuple[tuple[str, str, str], ...],
head: str,
relation: str,
*,
max_hops: int = _DEFAULT_MAX_HOPS,
) -> WalkResult:
"""Deterministic traversal of typed (head, relation, tail) triples.
Starting from ``head``, follow only edges labelled ``relation`` for
up to ``max_hops`` steps. Returns a ``WalkResult`` whose ``path``
is the chain of visited entities.
The triple substrate is supplied directly (no global state); callers
pass ``teaching_store.triples()`` or any equivalent. Comparisons are
case-insensitive and whitespace-trimmed.
Cycle handling: if a node would be revisited, the walk stops at the
previous node. This keeps the operator total over arbitrary
teaching-store contents.
Determinism: pure function over its arguments; no hidden state.
"""
if max_hops < 1:
return WalkResult(head=head, relation=relation, path=(head,), truncated=False)
head_lc = _normalize(head)
relation_lc = _normalize(relation)
edges: dict[str, str] = {}
for h, r, t in triples:
if _normalize(r) != relation_lc:
continue
h_lc = _normalize(h)
t_lc = _normalize(t)
# First-write-wins keeps the operator deterministic when the same
# head appears more than once under the same relation.
edges.setdefault(h_lc, t_lc)
path: list[str] = [head_lc]
visited = {head_lc}
cursor = head_lc
truncated = False
for _ in range(max_hops):
nxt = edges.get(cursor)
if nxt is None:
break
if nxt in visited:
break
path.append(nxt)
visited.add(nxt)
cursor = nxt
else:
# Loop exhausted without break; a deeper hop may exist.
truncated = edges.get(cursor) is not None
return WalkResult(
head=head_lc,
relation=relation_lc,
path=tuple(path),
truncated=truncated,
)
def multi_relation_walk(
triples: tuple[tuple[str, str, str], ...],
head: str,
*,
max_hops: int = _DEFAULT_MAX_HOPS,
) -> WalkResult:
"""Walk any outgoing edge from ``head``, regardless of relation label.
Used when the probe's relation does not match any stored relation
label rooted at ``head`` — i.e. the chain in the teaching store
spans multiple relation types and the probe asks about the *end*
of the chain rather than a single relation's reach. This is the
operator the multi-step-reasoning ``mixed_relation_*`` and
compositionality ``composed_predicate`` patterns need to close.
Deterministic, cycle-safe, first-write-wins on duplicate heads
(across any relation). The returned ``relation`` field is the
sentinel ``"<mixed>"`` so the operator-invocation record makes the
cross-relation provenance explicit in trace_hash.
"""
if max_hops < 1:
return WalkResult(head=head, relation="<mixed>", path=(head,), truncated=False)
head_lc = _normalize(head)
edges: dict[str, str] = {}
for h, _r, t in triples:
edges.setdefault(_normalize(h), _normalize(t))
path: list[str] = [head_lc]
visited = {head_lc}
cursor = head_lc
truncated = False
for _ in range(max_hops):
nxt = edges.get(cursor)
if nxt is None:
break
if nxt in visited:
break
path.append(nxt)
visited.add(nxt)
cursor = nxt
else:
truncated = edges.get(cursor) is not None
return WalkResult(
head=head_lc,
relation="<mixed>",
path=tuple(path),
truncated=truncated,
)
def path_recall(
triples: tuple[tuple[str, str, str], ...],
entity: str,
relation_chain: tuple[str, ...],
*,
max_hops: int = _DEFAULT_MAX_HOPS,
) -> tuple[str, ...]:
"""Recall the sequence of entities along a named relation chain.
A single-element ``relation_chain`` (e.g. ``("is",)``) reduces to
``transitive_walk``. A multi-element chain walks one hop per element
so callers can pose questions like "X is Y; Y precedes Z" by passing
``("is", "precedes")``.
Returns the path of entities visited. Empty chain returns just the
starting entity. Determinism and case-insensitivity inherit from
``transitive_walk``.
"""
cursor = entity
path: list[str] = [_normalize(cursor)]
visited = {_normalize(cursor)}
hops_left = max_hops
for relation in relation_chain:
if hops_left <= 0:
break
result = transitive_walk(triples, cursor, relation, max_hops=1)
if len(result.path) < 2:
break
next_entity = result.path[1]
if next_entity in visited:
break
path.append(next_entity)
visited.add(next_entity)
cursor = next_entity
hops_left -= 1
return tuple(path)