41f309eb92
Regression coverage for the audit repro (5/4), zero/one/gt-one geometric no-bypass, injected Fraction domain mutations, promotable resolver refusal, and flip the PR #87 preexisting gap pin to require operator refuse alongside baseline.
356 lines
15 KiB
Python
356 lines
15 KiB
Python
from fractions import Fraction
|
|
from pathlib import Path
|
|
|
|
import dataclasses
|
|
|
|
import pytest
|
|
|
|
from generate.derivation.fraction_decrease import resolve_promotable_fraction_decrease
|
|
from generate.problem_frame_builder import build_problem_frame
|
|
from generate.problem_frame_contracts import (
|
|
_fraction_decrease_scale_binding,
|
|
_is_valid_fraction_decrease_scale,
|
|
assess_contracts,
|
|
assess_fraction_decrease,
|
|
assess_geometric_proposals,
|
|
assess_percent_partition,
|
|
)
|
|
from algebra.versor import versor_condition
|
|
|
|
|
|
FRACTION_DECREASE_CASE = (
|
|
"In one hour, Addison mountain's temperature will decrease to 3/4 of its temperature. "
|
|
"If the current temperature of the mountain is 84 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
|
|
FRACTION_DECREASE_SIBLING = (
|
|
"In two hours, Cedar peak's temperature will decrease to 2/3 of its temperature. "
|
|
"If the current temperature of the peak is 60 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
|
|
FINAL_VALUE_CONFUSER = (
|
|
"In one hour, the lake's temperature will decrease to 3/4 of its temperature. "
|
|
"If the current temperature of the lake is 80 degrees, what will the temperature be?"
|
|
)
|
|
|
|
AFFINE_CONFUSER = (
|
|
"Yun had 20 paperclips initially, but then lost 12. Marion has 1/4 more than what "
|
|
"Yun currently has, plus 7. How many paperclips does Marion have?"
|
|
)
|
|
|
|
MULTIPLE_FRACTION_CONFUSER = (
|
|
"The reactor's temperature will decrease to 3/4 of its temperature and later decrease "
|
|
"to 1/2 of its temperature. If the current temperature is 80 degrees, what will the "
|
|
"temperature decrease by?"
|
|
)
|
|
|
|
PERCENT_PARTITION_CASE = (
|
|
"A school has 100 students. Half of the students are girls, the other half are boys. "
|
|
"20% of the girls have dogs at home and 10% of the boys have dogs at home. "
|
|
"How many students own dogs?"
|
|
)
|
|
|
|
ONE_SUBGROUP_CONFUSER = (
|
|
"There are 100 students. Half are girls. 30% of the girls own pets. "
|
|
"How many students own pets?"
|
|
)
|
|
|
|
UNEQUAL_PARTITION_CONFUSER = (
|
|
"A school has 100 students. 60 of the students are girls and 40 are boys. "
|
|
"20% of the girls have dogs and 10% of the boys have dogs. "
|
|
"How many students own dogs?"
|
|
)
|
|
|
|
INVERSE_REMAINING_CONFUSER = (
|
|
"Yvonne brings a box of chocolates to school. Half have nuts and half do not. "
|
|
"The students eat 80% of the ones with nuts and eat half of the ones without nuts. "
|
|
"If there are 28 chocolates left, how many chocolates were in the box?"
|
|
)
|
|
|
|
|
|
def test_fraction_decrease_contract_is_runnable_from_problemframe() -> None:
|
|
assessment = assess_fraction_decrease(build_problem_frame(FRACTION_DECREASE_CASE))
|
|
assert assessment.runnable
|
|
assert assessment.missing_bindings == ()
|
|
assert assessment.evidence_spans
|
|
# Pivot revelation: geometric dilation binds from frame scale Fraction(3/4),
|
|
# not from re-parsing "decrease to N/M of" prose.
|
|
assert assessment.bindings
|
|
assert assessment.bindings[0].semantic_identity in {"3/4", "3 / 4"}
|
|
assert float(versor_condition(assessment.bindings[0].geometric_payload)) < 1e-6
|
|
|
|
|
|
def test_fraction_decrease_geometric_uses_frame_scale_not_prose_regex() -> None:
|
|
frame = build_problem_frame(FRACTION_DECREASE_CASE)
|
|
geom = assess_geometric_proposals(frame)
|
|
assert len(geom) == 1
|
|
assert geom[0].candidate_organ == "fraction_decrease"
|
|
assert geom[0].runnable
|
|
assert geom[0].bindings[0].semantic_identity.replace(" ", "") == "3/4"
|
|
# Payload is dilation for k=0.75 (same as Fraction(3,4)).
|
|
from generate.problem_frame_contracts import _dilation_versor_payload
|
|
import numpy as np
|
|
|
|
expected = _dilation_versor_payload(0.75)
|
|
assert np.allclose(geom[0].bindings[0].geometric_payload, expected)
|
|
|
|
|
|
def test_no_legacy_decrease_to_fraction_prose_regex_in_contracts() -> None:
|
|
"""Guard: the overfitting local prose parser must not return."""
|
|
source = Path("generate/problem_frame_contracts.py").read_text(encoding="utf-8")
|
|
assert r"decrease to (\d+" not in source
|
|
assert "_build_fraction_decrease_payload_and_bind" not in source
|
|
|
|
|
|
def test_fraction_decrease_sibling_is_runnable() -> None:
|
|
assessment = assess_fraction_decrease(build_problem_frame(FRACTION_DECREASE_SIBLING))
|
|
assert assessment.runnable
|
|
|
|
|
|
def test_final_value_question_is_not_delta_runnable() -> None:
|
|
assessment = assess_fraction_decrease(build_problem_frame(FINAL_VALUE_CONFUSER))
|
|
assert not assessment.runnable
|
|
assert "delta_decrease_target_unbound" in assessment.missing_bindings
|
|
|
|
|
|
def test_affine_more_than_fraction_is_not_change_runnable() -> None:
|
|
assessments = assess_contracts(build_problem_frame(AFFINE_CONFUSER))
|
|
assert not any(item.candidate_organ == "fraction_decrease" for item in assessments)
|
|
|
|
|
|
def test_multiple_fraction_or_base_candidates_refuse_readiness() -> None:
|
|
assessments = assess_contracts(build_problem_frame(MULTIPLE_FRACTION_CONFUSER))
|
|
assert not any(item.candidate_organ == "fraction_decrease" and item.runnable for item in assessments)
|
|
|
|
|
|
def test_tightly_grounded_percent_partition_is_diagnostically_runnable() -> None:
|
|
assessment = assess_percent_partition(build_problem_frame(PERCENT_PARTITION_CASE))
|
|
assert assessment.runnable
|
|
assert assessment.missing_bindings == ()
|
|
assert assessment.evidence_spans
|
|
|
|
|
|
def test_percent_partition_requires_two_complementary_subgroups() -> None:
|
|
assessment = assess_percent_partition(build_problem_frame(ONE_SUBGROUP_CONFUSER))
|
|
assert not assessment.runnable
|
|
assert "partition_subgroups_not_distinct" in assessment.missing_bindings
|
|
assert "percent_subgroup_links_incomplete" in assessment.missing_bindings
|
|
|
|
|
|
def test_inverse_remaining_percent_case_is_not_runnable() -> None:
|
|
assessment = assess_percent_partition(build_problem_frame(INVERSE_REMAINING_CONFUSER))
|
|
assert not assessment.runnable
|
|
assert "inverse_topology_unlicensed" in assessment.missing_bindings
|
|
assert "original_whole_unbound" in assessment.missing_bindings
|
|
|
|
|
|
def test_unequal_partition_confuser_is_not_runnable() -> None:
|
|
assessment = assess_percent_partition(build_problem_frame(UNEQUAL_PARTITION_CONFUSER))
|
|
assert not assessment.runnable
|
|
assert "partition_subgroups_not_distinct" in assessment.missing_bindings or "percent_subgroup_links_incomplete" in assessment.missing_bindings
|
|
|
|
|
|
def test_fraction_decrease_rejects_scale_zero() -> None:
|
|
case = (
|
|
"In one hour, Addison mountain's temperature will decrease to 0/4 of its temperature. "
|
|
"If the current temperature of the mountain is 84 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
assessment = assess_fraction_decrease(build_problem_frame(case))
|
|
assert not assessment.runnable
|
|
assert "scale_out_of_range" in assessment.missing_bindings
|
|
|
|
|
|
def test_fraction_decrease_rejects_scale_one() -> None:
|
|
case = (
|
|
"In one hour, Addison mountain's temperature will decrease to 4/4 of its temperature. "
|
|
"If the current temperature of the mountain is 84 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
assessment = assess_fraction_decrease(build_problem_frame(case))
|
|
assert not assessment.runnable
|
|
assert "scale_out_of_range" in assessment.missing_bindings
|
|
|
|
|
|
def test_fraction_decrease_rejects_scale_greater_than_one() -> None:
|
|
case = (
|
|
"In one hour, Addison mountain's temperature will decrease to 5/4 of its temperature. "
|
|
"If the current temperature of the mountain is 84 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
assessment = assess_fraction_decrease(build_problem_frame(case))
|
|
assert not assessment.runnable
|
|
assert "scale_out_of_range" in assessment.missing_bindings
|
|
|
|
|
|
def test_fraction_decrease_scale_domain_predicate() -> None:
|
|
"""Single shared domain: finite 0 < k < 1 for Fraction and float."""
|
|
assert _is_valid_fraction_decrease_scale(Fraction(3, 4))
|
|
assert _is_valid_fraction_decrease_scale(Fraction(2, 3))
|
|
assert _is_valid_fraction_decrease_scale(0.5)
|
|
assert not _is_valid_fraction_decrease_scale(Fraction(0, 4))
|
|
assert not _is_valid_fraction_decrease_scale(Fraction(4, 4))
|
|
assert not _is_valid_fraction_decrease_scale(Fraction(5, 4))
|
|
assert not _is_valid_fraction_decrease_scale(Fraction(-1, 4))
|
|
assert not _is_valid_fraction_decrease_scale(0.0)
|
|
assert not _is_valid_fraction_decrease_scale(1.0)
|
|
assert not _is_valid_fraction_decrease_scale(1.25)
|
|
assert not _is_valid_fraction_decrease_scale(-0.5)
|
|
assert not _is_valid_fraction_decrease_scale(float("nan"))
|
|
assert not _is_valid_fraction_decrease_scale(float("inf"))
|
|
assert not _is_valid_fraction_decrease_scale(float("-inf"))
|
|
assert not _is_valid_fraction_decrease_scale("not-a-number")
|
|
assert not _is_valid_fraction_decrease_scale(None)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"scale_surface",
|
|
["5/4", "4/4", "0/4"],
|
|
ids=["gt_one", "one", "zero"],
|
|
)
|
|
def test_fraction_decrease_geometric_refuses_out_of_range_scale(scale_surface: str) -> None:
|
|
"""Geometric admission must agree with obligation scale_out_of_range (no bypass)."""
|
|
case = (
|
|
f"In one hour, the river will decrease to {scale_surface} of its level. "
|
|
"If the current level is 40 feet, what will the level decrease by?"
|
|
)
|
|
frame = build_problem_frame(case)
|
|
obligation = assess_fraction_decrease(frame)
|
|
assert not obligation.runnable
|
|
assert "scale_out_of_range" in obligation.missing_bindings
|
|
assert obligation.bindings == () or not obligation.bindings
|
|
|
|
geom = [
|
|
a
|
|
for a in assess_geometric_proposals(frame)
|
|
if a.candidate_organ == "fraction_decrease"
|
|
]
|
|
assert geom, "expected a geometric fraction_decrease proposal assessment"
|
|
for assessment in geom:
|
|
assert not assessment.runnable
|
|
assert not assessment.bindings
|
|
|
|
assert _fraction_decrease_scale_binding(frame) is None
|
|
assert resolve_promotable_fraction_decrease(case) is None
|
|
|
|
|
|
def test_fraction_decrease_scale_gt_one_live_repro_refuses() -> None:
|
|
"""Audit repro: 5/4 must not promote a negative decrease answer."""
|
|
case = (
|
|
"In one hour, the river will decrease to 5/4 of its level. "
|
|
"If the current level is 40 feet, what will the level decrease by?"
|
|
)
|
|
assert resolve_promotable_fraction_decrease(case) is None
|
|
frame = build_problem_frame(case)
|
|
obligation = assess_fraction_decrease(frame)
|
|
assert "scale_out_of_range" in obligation.missing_bindings
|
|
geom = assess_geometric_proposals(frame)
|
|
assert all(
|
|
not (a.candidate_organ == "fraction_decrease" and a.bindings)
|
|
for a in geom
|
|
)
|
|
|
|
|
|
def test_fraction_decrease_rejects_injected_negative_zero_one_and_gt_one_scale() -> None:
|
|
"""Domain gate on mutated Fraction scales (GroundedScalar is Fraction-only)."""
|
|
case = (
|
|
"In one hour, Addison mountain's temperature will decrease to 3/4 of its temperature. "
|
|
"If the current temperature of the mountain is 84 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
base_frame = build_problem_frame(case)
|
|
assert assess_fraction_decrease(base_frame).runnable
|
|
|
|
# Locate scale quantity fact and replace value.
|
|
relation = next(
|
|
r for r in base_frame.bound_relations if r.relation_type == "decrease_to_fraction"
|
|
)
|
|
scale_id = next(role.target_id for role in relation.roles if role.role == "scale")
|
|
mention = next(m for m in base_frame.mentions if m.mention_id == scale_id)
|
|
fact_id = mention.fact_id
|
|
assert fact_id is not None
|
|
|
|
for bad_value in (
|
|
Fraction(-1, 4),
|
|
Fraction(0, 1),
|
|
Fraction(1, 1),
|
|
Fraction(5, 4),
|
|
):
|
|
new_quantities = []
|
|
for q in base_frame.quantities:
|
|
if q.fact_id == fact_id:
|
|
new_quantities.append(dataclasses.replace(q, value=bad_value))
|
|
else:
|
|
new_quantities.append(q)
|
|
frame = dataclasses.replace(base_frame, quantities=tuple(new_quantities))
|
|
assessment = assess_fraction_decrease(frame)
|
|
assert not assessment.runnable, bad_value
|
|
assert "scale_out_of_range" in assessment.missing_bindings, bad_value
|
|
assert _fraction_decrease_scale_binding(frame) is None, bad_value
|
|
geom = assess_geometric_proposals(frame)
|
|
assert all(
|
|
not (a.candidate_organ == "fraction_decrease" and a.bindings)
|
|
for a in geom
|
|
), bad_value
|
|
|
|
|
|
def test_multi_base_candidate_is_refused() -> None:
|
|
import dataclasses
|
|
case = (
|
|
"In one hour, Addison mountain's temperature will decrease to 3/4 of its temperature. "
|
|
"If the current temperature of the mountain is 84 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
frame = build_problem_frame(case)
|
|
relation = [r for r in frame.bound_relations if r.relation_type == "decrease_to_fraction"][0]
|
|
frame = dataclasses.replace(frame, bound_relations=(relation, relation))
|
|
assessment = assess_fraction_decrease(frame)
|
|
assert not assessment.runnable
|
|
assert "decrease_relation_ambiguous" in assessment.missing_bindings
|
|
|
|
|
|
def test_state_entity_continuity_unproven_blocks_runnable() -> None:
|
|
import dataclasses
|
|
case = (
|
|
"In one hour, Addison mountain's temperature will decrease to 3/4 of its temperature. "
|
|
"If the current temperature of the mountain is 84 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
frame = build_problem_frame(case)
|
|
# Target "mention-0004" is "degrees" which does not match "temperature" (state_entity)
|
|
new_target = dataclasses.replace(frame.bound_question_target, target_mention_id="mention-0004")
|
|
frame = dataclasses.replace(frame, bound_question_target=new_target)
|
|
assessment = assess_fraction_decrease(frame)
|
|
assert not assessment.runnable
|
|
assert "state_entity_continuity_unproven" in assessment.missing_bindings
|
|
|
|
|
|
def test_unit_continuity_unproven_blocks_runnable() -> None:
|
|
import dataclasses
|
|
case = (
|
|
"In one hour, Addison mountain's temperature will decrease to 3/4 of its temperature. "
|
|
"If the current temperature of the mountain is 84 degrees, what will the temperature "
|
|
"decrease by?"
|
|
)
|
|
frame = build_problem_frame(case)
|
|
relation = [r for r in frame.bound_relations if r.relation_type == "decrease_to_fraction"][0]
|
|
new_roles = []
|
|
for role in relation.roles:
|
|
if role.role == "unit":
|
|
new_roles.append(dataclasses.replace(role, target_id="mention-9999"))
|
|
else:
|
|
new_roles.append(role)
|
|
new_relation = dataclasses.replace(relation, roles=tuple(new_roles))
|
|
frame = dataclasses.replace(frame, bound_relations=(new_relation,))
|
|
assessment = assess_fraction_decrease(frame)
|
|
assert not assessment.runnable
|
|
assert "unit_continuity_unproven" in assessment.missing_bindings
|
|
|
|
|
|
def test_unequal_partition_confuser_produces_specific_blocker() -> None:
|
|
assessment = assess_percent_partition(build_problem_frame(UNEQUAL_PARTITION_CONFUSER))
|
|
assert not assessment.runnable
|
|
assert "partition_subgroups_not_distinct" in assessment.missing_bindings
|
|
assert "percent_subgroup_links_incomplete" in assessment.missing_bindings
|