ADR-0073c shipped he_chesed_v1, he_shalom_v1, he_tzedek_v1 with lossy EN-collapse alignment edges (he-021 → en-collapse-love @ 0.63, etc.) but the synthetic en-collapse-* targets didn't exist in any mounted lexicon. Result: the three lenses ratified but stayed dormant — the runtime OOV gate fired on "What is love?" / "What is peace?" / "What is justice?" before the lens engagement path got a chance. This commit adds a minimal pack whose lexicon carries exactly those three synthetic anchors: en-collapse-love lemma="love" domain=collapse_anchor.love en-collapse-peace lemma="peace" domain=collapse_anchor.peace en-collapse-justice lemma="justice" domain=collapse_anchor.justice Mounted last in DEFAULT_RESOLVABLE_PACK_IDS — cognition / relations packs win first-match on any future collision. No real content pack currently carries these lemmas (grep-confirmed) so the mount adds no collision risk. The pack-grounded surface for "What is love?" advertises its nature honestly via the pack id (en_collapse_anchors_v1) and the domain string (collapse_anchor.love) — the surface is intentionally minimal; the substantive content arrives via the lens annotation [lens(he_chesed_v1):covenant-love] / [lens(he_shalom_v1):wholeness-peace] / [lens(he_tzedek_v1):right-order]. chat/pack_grounding.py:_en_lemma_to_entry_id() now reads both en_core_cognition_v1 and en_collapse_anchors_v1, with cognition winning on lemma collision. New test file tests/test_en_collapse_anchors_v1_pack.py pins: - each anchor lemma resolves to its synthetic entry_id - collapse pack mounted last (precedence guarantee) - each of the three lenses engages on its target English prompt - baseline surface (no lens) still advertises anchor nature Validation: - Cognition eval byte-identical (100/100/91.7/100) - 160 lens/pack/resolver tests pass + 8 new - anchor-lens-tour green - register-tour green
245 lines
9.3 KiB
Python
245 lines
9.3 KiB
Python
"""chat/pack_resolver.py — ADR-0063 cross-pack surface resolver.
|
|
|
|
The cold-start grounding composers in :mod:`chat.pack_grounding` were
|
|
hardcoded to a single lexicon pack (``en_core_cognition_v1``). That
|
|
asymmetry blocked ``en_core_relations_v1`` from being mounted on the
|
|
default runtime: mounting it would silently widen vault recall and
|
|
intent classification without a corresponding ratified surface
|
|
composer for kinship lemmas.
|
|
|
|
This module supplies the missing abstraction: a *deterministic*,
|
|
*first-match-wins* resolver that maps a lemma to ``(pack_id, semantic_domains)``
|
|
across an ordered tuple of mounted lexicon packs. Surface composers
|
|
consult the resolver instead of a single pack; the surface trust-boundary
|
|
tag follows the *resolving* pack id.
|
|
|
|
Design constraints (CLAUDE.md / Reconstruction-over-storage):
|
|
|
|
- The resolver loads each pack lexicon at most once per process via
|
|
:func:`functools.lru_cache`. Ratified packs are immutable, so caching
|
|
is sound.
|
|
- A pack that fails to load (missing file, unreadable JSON) contributes
|
|
an empty index — callers cannot distinguish "pack absent" from "lemma
|
|
absent in mounted packs". Both produce ``None``.
|
|
- First-match-wins on collision. The orthogonality test in
|
|
``tests/test_en_core_relations_v1_pack.py`` enforces zero overlap
|
|
today; this rule documents the deterministic resolution if a future
|
|
pack pair collides.
|
|
- No mutation of pack data is performed anywhere in this module. All
|
|
return types are tuples/frozensets/dicts of plain strings.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from functools import lru_cache
|
|
from pathlib import Path
|
|
|
|
# Default mounted lexicon-pack ids that ADR-0063 surface composers
|
|
# consult. Order matters: earlier packs win on lemma collision. This
|
|
# tuple is intentionally narrow — it lists only ratified ``en_core_*``
|
|
# *content* packs. Identity/safety/ethics packs are propositional
|
|
# overlays and never carry vocabulary; they are deliberately excluded.
|
|
DEFAULT_RESOLVABLE_PACK_IDS: tuple[str, ...] = (
|
|
"en_core_cognition_v1",
|
|
"en_core_meta_v1",
|
|
"en_core_attitude_v1",
|
|
"en_core_temporal_v1",
|
|
"en_core_action_v1",
|
|
"en_core_quantitative_v1",
|
|
"en_core_spatial_v1",
|
|
"en_core_causation_v1",
|
|
"en_core_polarity_v1",
|
|
"en_core_relations_v1",
|
|
"en_core_relations_v2",
|
|
# ADR-0073c — synthetic English anchor lemmas for cross-lang collapse.
|
|
# Mounted last so cognition / relations content packs win first-match.
|
|
# Carries "love" / "peace" / "justice" entries that exist only as
|
|
# collapse-anchor targets for the he_chesed / he_shalom / he_tzedek
|
|
# anchor lenses. Composer surfaces here are intentionally minimal —
|
|
# the substantive content lives in the lens annotation.
|
|
"en_collapse_anchors_v1",
|
|
)
|
|
|
|
_PACK_ROOT = Path(__file__).resolve().parent.parent / "language_packs" / "data"
|
|
|
|
|
|
@lru_cache(maxsize=16)
|
|
def _pack_lexicon_for(pack_id: str) -> dict[str, tuple[str, ...]]:
|
|
"""Return ``{lemma_lower: semantic_domains}`` for *pack_id*, cached.
|
|
|
|
Returns an empty dict if the pack's lexicon file is missing,
|
|
unreadable, or contains no entries with ``semantic_domains``.
|
|
Ratified packs are immutable so the cache survives the process
|
|
lifetime.
|
|
"""
|
|
lexicon_path = _PACK_ROOT / pack_id / "lexicon.jsonl"
|
|
if not lexicon_path.exists():
|
|
return {}
|
|
out: dict[str, tuple[str, ...]] = {}
|
|
for line in lexicon_path.read_text(encoding="utf-8").splitlines():
|
|
line = line.strip()
|
|
if not line:
|
|
continue
|
|
try:
|
|
entry = json.loads(line)
|
|
except json.JSONDecodeError:
|
|
continue
|
|
if not isinstance(entry, dict):
|
|
continue
|
|
lemma = entry.get("lemma") or entry.get("surface")
|
|
if not lemma or not isinstance(lemma, str):
|
|
continue
|
|
domains = entry.get("semantic_domains", ())
|
|
if not isinstance(domains, (list, tuple)) or not domains:
|
|
continue
|
|
out[lemma.lower()] = tuple(str(d) for d in domains)
|
|
return out
|
|
|
|
|
|
def resolve_lemma(
|
|
lemma: str,
|
|
pack_ids: tuple[str, ...] = DEFAULT_RESOLVABLE_PACK_IDS,
|
|
) -> tuple[str, tuple[str, ...]] | None:
|
|
"""Return ``(pack_id, semantic_domains)`` for the first pack in
|
|
*pack_ids* whose lexicon contains *lemma*, else ``None``.
|
|
|
|
First-match-wins on collision. ``pack_ids`` defaults to
|
|
:data:`DEFAULT_RESOLVABLE_PACK_IDS`.
|
|
"""
|
|
if not lemma or not isinstance(lemma, str):
|
|
return None
|
|
key = lemma.strip().lower()
|
|
if not key:
|
|
return None
|
|
for pack_id in pack_ids:
|
|
index = _pack_lexicon_for(pack_id)
|
|
domains = index.get(key)
|
|
if domains:
|
|
return (pack_id, domains)
|
|
return None
|
|
|
|
|
|
def is_resolvable(
|
|
lemma: str,
|
|
pack_ids: tuple[str, ...] = DEFAULT_RESOLVABLE_PACK_IDS,
|
|
) -> bool:
|
|
"""Return True iff *lemma* resolves in any of *pack_ids*."""
|
|
return resolve_lemma(lemma, pack_ids) is not None
|
|
|
|
|
|
def mounted_lemmas(
|
|
pack_ids: tuple[str, ...] = DEFAULT_RESOLVABLE_PACK_IDS,
|
|
) -> frozenset[str]:
|
|
"""Return the frozen union of lemmas across *pack_ids*.
|
|
|
|
Used by topic extractors that iterate over user-text tokens and
|
|
need an O(1) "is this token any mounted lemma?" check.
|
|
"""
|
|
out: set[str] = set()
|
|
for pack_id in pack_ids:
|
|
out.update(_pack_lexicon_for(pack_id).keys())
|
|
return frozenset(out)
|
|
|
|
|
|
@lru_cache(maxsize=16)
|
|
def _pack_glosses_for(pack_id: str) -> dict[str, tuple[str, str]]:
|
|
"""Return ``{lemma_lower: (pos, gloss)}`` from the pack's optional
|
|
``glosses.jsonl`` companion file.
|
|
|
|
Returns an empty dict when the pack ships no glosses (back-compat
|
|
with the original ratified packs). Glosses are an additive overlay
|
|
on top of the immutable, checksum-sealed ``lexicon.jsonl`` — they
|
|
intentionally live in a separate file so adding a gloss never
|
|
perturbs the lexicon checksum.
|
|
|
|
Each line of ``glosses.jsonl`` must be a JSON object with at least
|
|
``lemma`` and ``gloss`` fields; ``pos`` (string) is optional and
|
|
drives the natural-language sentence frame in
|
|
:func:`chat.pack_grounding.pack_grounded_surface`. Lines without
|
|
a non-empty ``lemma`` or ``gloss`` are silently skipped — never
|
|
fabricated. Malformed JSON lines are also skipped (defensive
|
|
parsing — a single bad line never breaks gloss resolution for the
|
|
rest of the pack).
|
|
"""
|
|
path = _PACK_ROOT / pack_id / "glosses.jsonl"
|
|
if not path.exists():
|
|
return {}
|
|
out: dict[str, tuple[str, str]] = {}
|
|
for line in path.read_text(encoding="utf-8").splitlines():
|
|
line = line.strip()
|
|
if not line:
|
|
continue
|
|
try:
|
|
entry = json.loads(line)
|
|
except json.JSONDecodeError:
|
|
continue
|
|
if not isinstance(entry, dict):
|
|
continue
|
|
lemma = entry.get("lemma")
|
|
gloss = entry.get("gloss")
|
|
if not isinstance(lemma, str) or not lemma.strip():
|
|
continue
|
|
if not isinstance(gloss, str) or not gloss.strip():
|
|
continue
|
|
pos_raw = entry.get("pos")
|
|
pos = pos_raw if isinstance(pos_raw, str) else ""
|
|
out[lemma.strip().lower()] = (pos, gloss.strip())
|
|
return out
|
|
|
|
|
|
def resolve_gloss(
|
|
lemma: str,
|
|
pack_ids: tuple[str, ...] = DEFAULT_RESOLVABLE_PACK_IDS,
|
|
) -> tuple[str, str, str] | None:
|
|
"""Return ``(pack_id, pos, gloss)`` for the first pack in
|
|
*pack_ids* that BOTH (a) ratifies *lemma* in its ``lexicon.jsonl``
|
|
AND (b) carries a gloss for it in ``glosses.jsonl``.
|
|
|
|
First-match-wins on collision, matching :func:`resolve_lemma`'s
|
|
resolution order — so a lemma's lexicon resolution and gloss
|
|
resolution always agree on the resolving pack.
|
|
|
|
The lexicon-residency requirement is load-bearing trust-boundary
|
|
discipline (2026-05-19 design review). Without it, ``glosses.jsonl``
|
|
would become a parallel surface-authoring channel that bypasses the
|
|
checksum-sealed lexicon: someone could ship a gloss for a lemma the
|
|
pack has never ratified, and the runtime would emit that gloss as
|
|
if it were pack content. This function rejects any (lemma, pack)
|
|
pair where the lemma is not present in the pack's lexicon, even if
|
|
a gloss exists for it.
|
|
"""
|
|
if not lemma or not isinstance(lemma, str):
|
|
return None
|
|
key = lemma.strip().lower()
|
|
if not key:
|
|
return None
|
|
for pack_id in pack_ids:
|
|
lex = _pack_lexicon_for(pack_id)
|
|
if key not in lex:
|
|
# Lemma not ratified in this pack's lexicon — refuse to
|
|
# surface any gloss this pack might carry for it.
|
|
continue
|
|
glosses = _pack_glosses_for(pack_id)
|
|
entry = glosses.get(key)
|
|
if entry is not None:
|
|
pos, gloss = entry
|
|
return (pack_id, pos, gloss)
|
|
return None
|
|
|
|
|
|
def clear_resolver_cache() -> None:
|
|
"""Drop all caches in this module — lexicon AND glosses.
|
|
|
|
Test-only escape hatch: enables fixture-based pack mutation
|
|
scenarios. Production code never calls this — ratified packs are
|
|
immutable.
|
|
|
|
Both ``_pack_lexicon_for`` and ``_pack_glosses_for`` are
|
|
``functools.lru_cache``-wrapped, so the test must clear BOTH or a
|
|
fixture that adds glosses on disk would be invisible to subsequent
|
|
``resolve_gloss`` calls in the same test process. Prior versions
|
|
cleared only the lexicon cache.
|
|
"""
|
|
_pack_lexicon_for.cache_clear()
|
|
_pack_glosses_for.cache_clear()
|