core/generate/derivation/accumulate.py
Shay 0fbcce429b
feat(adr-0182): cross-composer disagreement pooling — distractor 0014 + disguised-polarity refuse (confuser wrong 5->2) (#476)
Implements ADR-0182's first win on top of EX-6 (#473). The distractor-quantity
confuser 0014 misfired (20x3x5=300) because a blunt product-of-all was the *unique*
self-verifying reading: the completeness clause forces the distractor into it, and
no rival reading existed to trigger the wrong=0 disagreement rule. No tight cue rule
separates it from the legitimate cross-unit products (`for` licenses both the 0014
distractor AND the correct train-0021 product) -- that is the deferred cue-precision
problem. So instead of a reactive patch, let the disagreement rule do the refusing.

Mechanism (sealed lane; chat/ does not import these -> serving 3/47/0 frozen):
- verify.classify_derivation: a derivation is `complete` (commit-eligible),
  `exempt` (verified but for an isolated-foreign unused quantity -> commit-
  INELIGIBLE), or None. Refactored self_verifies into _base_reasons +
  _unused_quantities so the two share logic and cannot drift (behavior identical;
  385 derivation tests + smoke 67 green).
- accumulate.accumulation_candidates: exposes the ungated readings, incl. a
  distractor-skip reading that drops an isolated-foreign quantity from a multi-
  quantity change clause (20+5=25). compose_accumulation is byte-identical
  (drop_isolated_foreign=False + the same gate).
- search.multiplicative_candidates / multistep.candidate_chains: ungated candidates.
- pool.resolve_pooled: pools every composer's readings; disagreement -> refuse; a
  single answer commits only if a `complete` candidate produced it (exempt-only ->
  refuse, so the commit-path completeness guarantee from ADR-0175 is untouched).
- confuser runner: _engine_answer now delegates to resolve_pooled (the prior
  first-composer-wins order could not notice it held two incompatible readings).

Result (the microscope):
- confuser wrong 5 -> 2. distractor 0014 refuses (product 300 vs additive 25);
  BONUS: both disguised-polarity cases (0001/0003) refuse -- the spurious
  "buys X for N coins" product disagrees with the accumulation reading. Remaining
  wrong: 0016 (distractor in the anchor clause -> needs anchor-skip, separate step)
  and 0020 (temporal-scope). pair-tells 4 -> 1.
- genuine positives still 7 solved, 0 wrong.
- train_sample 3/47/0 and practice 3/47/0 byte-identical (they call
  compose_accumulation/search directly -- unchanged -- not the pool).
- smoke 67, architectural invariants 40, lane-SHA freeze 8/8.

Tests:
- test_adr_0182_pool.py: classify (complete/exempt/None incl. narrow-exemption
  edges) + resolve_pooled, with the wrong=0 obligation test_exempt_only_never_commits
  (a distractor with no multiplicative cue must refuse, not commit 25 -- fails loudly
  if the exemption is made commit-eligible).
- test_adr_0163_f2_confusers.py: baseline tightened wrong 5->2, pair_tells 4->1;
  new test_distractor_0014_refuses_via_pooling + test_disguised_polarity_does_not_misfire.

Stacked on #473 (EX-6); merge #473 first. 0016 + the remaining wrongs are follow-ups.
2026-05-29 13:22:19 -07:00

205 lines
9.2 KiB
Python

"""ADR-0178 GB-3b.1 — single-referent accumulation chaining.
The first cross-clause *comprehension* reading: one actor's quantity changes over
successive clauses (``Sam has 14 apples. He buys 9 more.`` -> ``14 + 9``). It is
the safe specialisation of the cross-clause sum that GB-3a's referent guard
correctly refuses wholesale (the ``Alice has 6 … Tom has 2 …`` hazard): we chain
across clauses **only** when (a) the later clause stays on the **same referent**
and (b) it carries a **licensed change cue** whose polarity is unambiguous.
Otherwise we refuse — the guard is generalised, never weakened.
Reading:
1. **Anchor** — clause 1 must establish exactly one quantity ``(actor, N, unit)``.
2. **Change steps** — each later quantity-bearing clause applies ``+ M`` (gain) or
``- M`` (loss) to the running total, where ``M`` is the clause's single grounded
quantity, taken **in the anchor's unit** (``9 more`` = 9 more *apples*; the unit
is inherited from the running total, which is what accumulation means).
3. **Gate** — the constructed chain runs through the unchanged self-verification
gate (grounding ∧ cue ∧ unit ∧ completeness ∧ uniqueness). The gate keeps
wrong=0; this only proposes a structurally-licensed candidate.
Polarity (ordered, so the ambiguous ``gives`` is resolved, never guessed):
* ``more`` present -> **gain** (covers ``buys/gets/…
N more`` and ``gives her N more`` — the subject is the recipient);
* else an unambiguous **loss** verb -> **loss**;
* else ``gives``/``gave`` with ``to``/``away`` -> **loss** (gives N *to* someone);
* else an unambiguous **gain** verb -> **gain**;
* else -> **refuse** (no guessing).
Referent guard (wrong=0-critical; the ADR-0174 multi-actor hazard's defensive fix,
built minimally in the clean lane rather than resurrecting the retired resolver):
a later clause stays on the anchor's referent iff its **subject token** is a
pronoun (``He/She/They/…``) or the same name as the anchor's subject. A **new named
subject** (a different capitalised non-pronoun first token, e.g. ``Tom``) -> refuse.
Pronoun gender/number is **not** matched (that was the old resolver's trap); a new
*name* is the only signal, and it triggers refusal, not resolution.
Sealed (no ``chat/`` import); deterministic; refuse-preferring.
"""
from __future__ import annotations
import re
from typing import Final
from generate.derivation.clauses import segment_clauses
from generate.derivation.extract import extract_quantities
from generate.derivation.model import GroundedDerivation, Quantity, Step
from generate.derivation.verify import Resolution, select_self_verified
from generate.math_roundtrip import _tokens
# Closed change-cue lexeme sets (ADR-0165: lexemes, not grammar templates; refined
# by the CP ledger, not asserted complete). Sorted use keeps cue selection stable.
_GAIN_VERBS: Final[frozenset[str]] = frozenset(
{
"buys", "bought", "gets", "got", "finds", "found", "picks", "picked",
"earns", "earned", "receives", "received", "collects", "collected",
"wins", "won", "makes", "made", "gains", "gained", "adds", "added",
}
)
_LOSS_VERBS: Final[frozenset[str]] = frozenset(
{
"loses", "lost", "spends", "spent", "uses", "used", "eats", "ate",
"sells", "sold", "donates", "donated", "drops", "dropped", "removes",
"removed", "breaks", "broke",
}
)
_PRONOUNS: Final[frozenset[str]] = frozenset(
{"he", "she", "they", "it", "him", "her", "them", "his", "hers", "its", "their", "we", "i", "you"}
)
_WORD_RE: Final[re.Pattern[str]] = re.compile(r"[A-Za-z]+")
def _subject_token(clause: str) -> str | None:
"""The clause's leading word token (its surface subject), or None if wordless."""
match = _WORD_RE.search(clause)
return match.group(0) if match is not None else None
def _same_referent(clause: str, anchor_subject: str | None) -> bool:
"""True iff ``clause`` does not introduce a new *named* subject.
Conservative: a leading pronoun continues the referent; a leading token equal
to the anchor's subject continues it; any other capitalised (named) leading
token is a *new actor* and breaks the referent (-> caller refuses).
"""
subject = _subject_token(clause)
if subject is None:
return True # wordless fragment carries no new actor
if subject.lower() in _PRONOUNS:
return True
if anchor_subject is not None and subject == anchor_subject:
return True
# A new capitalised, non-pronoun leading token is a new named actor.
return not subject[:1].isupper()
def _polarity(clause: str) -> int | None:
"""+1 (gain), -1 (loss), or None (ambiguous / no licensed change cue -> refuse)."""
tokens = set(_tokens(clause))
if "more" in tokens:
return +1
loss = bool(_LOSS_VERBS & tokens)
gain = bool(_GAIN_VERBS & tokens)
gives = "gives" in tokens or "gave" in tokens
directional = "to" in tokens or "away" in tokens
if loss and not gain:
return -1
if gives and directional and not gain and not loss:
return -1
if gain and not loss:
return +1
return None
def _cue(clause: str, polarity: int) -> str:
"""A grounded cue lexeme present in the clause (for the gate's cue check)."""
tokens = set(_tokens(clause))
if "more" in tokens and polarity > 0:
return "more"
verbs = _GAIN_VERBS if polarity > 0 else _LOSS_VERBS
present = sorted(verbs & tokens)
if present:
return present[0]
return "gives" # the only remaining licensed loss path (gives … to/away)
def _build_accumulation(
problem_text: str, *, drop_isolated_foreign: bool
) -> GroundedDerivation | None:
"""Construct the single-referent accumulation chain (ungated).
``drop_isolated_foreign`` (ADR-0182): when a change clause carries more than
one quantity, drop those with a **non-empty unit foreign to the anchor's unit**
(a candidate distractor — ``studies for 3 hours`` among ``pencils``) and proceed
if exactly one same-unit/unitless change remains. With the flag off this is the
strict GB-3b.1 reading (a multi-quantity change clause refuses), so
:func:`compose_accumulation` is byte-identical to its pre-ADR-0182 behavior.
The distractor-skip reading is **never committed alone** — it only ever enters
the pool to force a disagreement refusal (see :mod:`generate.derivation.pool`).
"""
clauses = segment_clauses(problem_text)
quantity_clauses = [c for c in clauses if extract_quantities(c)]
if len(quantity_clauses) < 2:
return None
anchor_clause, *change_clauses = quantity_clauses
anchor_quantities = extract_quantities(anchor_clause)
if len(anchor_quantities) != 1:
return None # the anchor must establish exactly one quantity (GB-3b.1 scope)
start = anchor_quantities[0]
anchor_subject = _subject_token(anchor_clause)
steps: list[Step] = []
for clause in change_clauses:
if not _same_referent(clause, anchor_subject):
return None # new named actor -> referent hazard -> refuse
change_quantities = list(extract_quantities(clause))
if drop_isolated_foreign and len(change_quantities) > 1:
change_quantities = [
q for q in change_quantities if not (q.unit and q.unit != start.unit)
]
if len(change_quantities) != 1:
return None # one change per clause (multi-change is GB-3b.2)
polarity = _polarity(clause)
if polarity is None:
return None # no unambiguous licensed change cue -> refuse
change = change_quantities[0]
# The change is in the running total's dimension ("9 more" = 9 more apples).
operand = Quantity(value=change.value, unit=start.unit, source_token=change.source_token)
op = "add" if polarity > 0 else "subtract"
steps.append(Step(op=op, operand=operand, cue=_cue(clause, polarity)))
if not steps:
return None
return GroundedDerivation(start=start, steps=tuple(steps))
def compose_accumulation(problem_text: str) -> Resolution | None:
"""GB-3b.1 composer — single-referent gain/loss accumulation. Refuse-preferring.
The strict (commit) reading: it gates the no-distractor-skip derivation through
the unchanged self-verification gate. Behavior is byte-identical to pre-ADR-0182.
"""
derivation = _build_accumulation(problem_text, drop_isolated_foreign=False)
if derivation is None:
return None
return select_self_verified([derivation], problem_text, target_units=())
def accumulation_candidates(problem_text: str) -> tuple[GroundedDerivation, ...]:
"""ADR-0182 — the ungated accumulation readings for cross-composer pooling.
The strict reading and (when it differs) the distractor-skip reading. Ungated:
the pool classifies each (``complete`` commits, ``exempt`` refuses-only) and the
disagreement rule does the wrong=0 work. Deterministic; de-dup is the pool's job.
"""
candidates: list[GroundedDerivation] = []
for drop in (False, True):
derivation = _build_accumulation(problem_text, drop_isolated_foreign=drop)
if derivation is not None:
candidates.append(derivation)
return tuple(candidates)