Hunt for the -n auto fast-lane polluters flagged in docs/testing-lanes.md
("Follow-up: xdist by default"). Three root causes, all shared-repo-path
writers with no per-test isolation, following the #782 monkeypatch idiom:
1. tests/test_workbench_replay.py::test_replay_leaves_no_trace hardcoded
`Path("engine_state")` (the real shared dir) instead of reading
`engine_state._DEFAULT_DIR`, which the root-conftest autouse fixture
already redirects per-test. It was a victim, not a polluter: any
concurrent worker writing the real dir made this snapshot-diff flake.
Fixed by reading `engine_state._DEFAULT_DIR` dynamically.
2. evals/gsm8k_math/train_sample/v1/runner.py hardcoded its report.json
output to the committed repo path with no override. Two test files
(test_rat1_end_to_end_admission.py, test_wave_a_multiplicative_
aggregation_injector.py; 4 tests total) spawn it as a subprocess and
read the same file back — a write race under -n auto, and a confirmed
downstream victim (test_gsm8k_sealed_attempt_scout.py::
test_report_json_mtime_unchanged_by_scout_import asserts the file's
mtime is stable). Added an optional CORE_GSM8K_TRAIN_SAMPLE_REPORT_PATH
env override (default unchanged) and pointed the 4 call sites at
tmp_path.
3. core/cli.py's `_DEMO_RESULTS_DIR` (evals/forward_semantic_control/
results/) is written, glob-scanned, and index.json-rebuilt by ~11 tests
across tests/test_cli_demo.py's TestDemoSubcommand and TestDemoPreambles
classes. Added an autouse fixture monkeypatching `cli._DEMO_RESULTS_DIR`
to a per-test tmp dir. This also unmasked a latent order-dependent
coupling: test_demo_list_results_indexes_reports and
test_demo_list_results_json_well_formed never wrote their own report,
relying on a sibling test's leftover file in the shared dir (silently
correct only because pytest ran the file in declaration order). Made
both self-contained.
No assertion weakening, no test deletion, no global autouse fixture masking
real bugs. All three fixes preserve the real (non-test) default behavior
byte-for-byte when unpatched/env-unset.
Verification: 8x targeted -n 8 loop over the 7 affected files (before and
after) did not force-reproduce the underlying race live (narrow timing
window, small-scale run) — confirmation is source-level (hardcoded shared
paths bypassing the established isolation idiom) plus the prior documented
flake for test_replay_leaves_no_trace in docs/testing-lanes.md. Full
fast-lane -n auto run recorded in the PR description.
|
||
|---|---|---|
| .. | ||
| adversarial | ||
| baselines | ||
| composition_validation/v1 | ||
| confusers | ||
| dev | ||
| equivalence | ||
| holdout_dev | ||
| holdouts/v1 | ||
| practice | ||
| public | ||
| scoring | ||
| train_sample | ||
| contract.md | ||
| README.md | ||
| runner.py | ||
| verify.py | ||
| verify_all.py | ||
gsm8k_math — Curated Eval Split for the GSM8K Evaluation Lane
Status: ADR-0119.2. 200 cases authored.
Schema source of truth: generate/math_problem_graph.py (typed dataclasses).
Format: JSONL — one case per line.
Why this set is not drawn from GSM8K
The GSM8K eval lane (ADR-0119) treats the actual GSM8K corpus as a sealed holdout test set. To preserve that integrity, we author this dataset independently in the same style as GSM8K (grade-school word problems with integer answers and 1-8 reasoning steps) but using our own vocabulary and grammar, ensuring zero overlap with the sealed holdout.
The dataset measures the solver pipeline (parser → solver → verifier → realizer). A correctly-parsed and solved problem is one whose parser output matches the ground-truth graph byte-for-byte and solves to the expected answer and unit.
Case schema
Each line is one JSON object:
{
"id": "gma-NNN",
"problem": "<the natural-language word problem>",
"expected_answer": <integer>,
"expected_unit": "<unit string>",
"ground_truth_graph": {
"entities": ["<entity_1>", "<entity_2>", ...],
"initial_state": [
{"entity": "<entity>", "quantity": {"unit": "<unit>", "value": <number>}},
...
],
"operations": [
{"actor": "<entity>", "kind": "<add|subtract|transfer|multiply|divide>",
"operand": {"unit": "<unit>", "value": <number>},
"target": "<entity>" /* required when kind=transfer; omitted otherwise */},
...
],
"unknown": {"entity": "<entity>" | null, "unit": "<unit>"}
},
"patterns": ["<pattern_tag_1>", "<pattern_tag_2>", ...],
"notes": "<authoring rationale>"
}
Field rules
id—gma-NNNwhere:gma-001...gma-050are for thedevsplit.gma-101...gma-250are for thepublicsplit.
problem— one or more complete English sentences ending in a question. Use Title-Cased proper names for entities ("Sam", "Anna's Toy Box"). Be consistent: the same entity always spelled the same way inproblemandground_truth_graph.entities.expected_answer— the integer answer to the question.expected_unit— the unit string the answer is in. Must matchground_truth_graph.unknown.unitbyte-for-byte.ground_truth_graph.entities— tuple in order of first introduction in the problem text. Not alphabetical. No duplicates.ground_truth_graph.initial_state— every entity that starts the problem with a known quantity. Empty list is legal if no initial possessions are asserted (rare).ground_truth_graph.operations— in source-text order. Empty list is legal (e.g. multi-entity sum questions with no mutations).ground_truth_graph.unknown.entity— set to the entity the question asks about, ornullif the question asks for a total across all entities ("How many ... in total?"; "How many do they have altogether?").patterns— tag list naming the constructions used. See Pattern registry below.notes— author-supplied one-sentence rationale. Read by future reviewers when the parser fails this case.
Canonicalization rules
- Units — lowercase, plural form ("apples", "candies", "dollars", "hours"). Use "dollars" for "$" quantities; the parser is expected to rewrite the "$" surface to the canonical unit.
- Entities — preserve capitalization as written. Do not lowercase.
- Numbers — integers when the text shows integers.
- Operation kinds — exactly one of
add,subtract,transfer,multiply,divide. Choose the one closest to the verb in the text:- "buys / gets / receives / earns / finds / adds" →
add - "eats / loses / sells / spends / drops / uses / removes" →
subtract - "gives / sends / hands / passes / mails / transfers" →
transfer(and settarget) - "doubles / triples / Nx as many" →
multiply - "splits evenly into N / N% of / shares equally with N people" →
divide
- "buys / gets / receives / earns / finds / adds" →
Scope limits (ADR-0119.2)
The parser and solver handle the following patterns and no others. Cases violating these constraints are out of scope:
- NO Time-modal / conditional phrasing ("If Sam had 5 apples, ...") — out of scope. Use direct declarative phrasing only.
- NO Rate/per-unit pricing requiring inference ("Each apple costs $2. Sam buys 4. How much does he spend?") — out of scope. A simpler variant ("Sam spends $8 on apples. How much does he have left?") IS in scope.
- NO Multi-clause / compound-question problems ("How many does Sam have, and how many does Tom have?") — out of scope. One unknown per case.
- NO Implicit-entity / generic plural ("There are 5 boys. Each has 2 apples.") — out of scope. Use named entities.
- NO Comparative phrasing without explicit numbers ("Sam has twice as many as Tom") — out of scope. Use numeric multipliers only ("Sam has 2 times 3 apples").
- NO metaphor or mixed units within one entity — out of scope. Keep units consistent.
- NO numeric magnitude beyond integer scope — out of scope. Only use integers.
Pattern registry
When tagging a case under patterns, draw from this list.
| Pattern tag | Construction | Example |
|---|---|---|
initial_has |
" has ." | "Sam has 5 apples." |
initial_there_are |
"There are ." (no entity; rare) | "There are 12 candies on the table." |
operation_buy_more |
" buys more." | "He buys 3 more." |
operation_get_more |
" gets more ." | "She gets 4 more pencils." |
operation_find_adds |
" finds ." | "Sam finds 2 apples on the path." |
operation_eat_loses |
" eats ." | "Tom eats 4 candies." |
operation_lose_loses |
" loses ." | "Anna loses 3 marbles." |
operation_sell_loses |
" sells ." | "Lisa sells 2 books." |
operation_donate_loses |
" donates ." | "Lisa donates 3 books." |
operation_use_loses |
" uses ." | "He uses 2 sheets of paper." |
operation_give_transfer |
" gives to ." | "Anna gives 3 marbles to Ben." |
operation_send_transfer |
" sends to ." | "Tom sends 4 letters to Sara." |
operation_double |
" doubles ..." | "Sam doubles his savings." |
operation_triple |
" triples ..." | "Sam triples his stickers." |
operation_split_divide |
"splits/shares evenly" | "They split 12 candies evenly." |
question_how_many_entity |
"How many does have?" | "How many apples does Sam have?" |
question_how_many_left |
"How many ... left?" | "How many candies does Tom have left?" |
question_how_many_total |
"How many ... in total?" / "altogether" | "How many stickers do they have in total?" |
question_how_many_now |
"How many ... now?" | "How many marbles does Anna have now?" |