2 commits

Author	SHA1	Message	Date
Shay	5da8988a63	chore(tests): reconcile pre-existing main rot — 58 failures → 0 ... Tests on main had drifted from intentional substrate changes that weren't propagated to their fixtures or pinned values. Categories: 1. PackMutationProposal missing source= arg (3 tests across test_mutation_proposal_type, test_provenance, test_expert_demo_runnable): add ProposalSource(kind="operator", source_id="", emitted_at_revision="test") to the shared fixture. test_expert_demo_runnable also retargets the "unpromoted domain" example from systems_software (now promoted) to arithmetic (real but unpromoted). 2. Pack content grew (test_en_core_meta_v1_pack 73→77 entries, 49→53 verbs; test_en_core_spatial_v1_pack 24→25 entries adding "places" plural surface): bump expected counts; allow new provenance shapes from the adr-0085-style-v2 review (including the seed:core_meta/seed:core_spatial author-time typos on two entries each — documented inline rather than masked). 3. Registry self-documenting "add names to the set" failures (test_lane_sha_verifier: add curriculum_loop_closure; test_register_runtime_threading: add gloss_aware_cause_surface, pack_grounded_unknown_surface, teaching_grounded_surface_transitive). 4. Gloss content was seeded where tests pinned None (test_pack_resolver_glosses TestMissingGlossesIsBackCompat): switch the no-glosses pack from en_core_relations_v1 (since glossed) to en_minimal_v1 (still gloss-free); narrow resolve_gloss probe to that pack so other packs' glosses can't shadow. 5. Entry-id renumber from cognition-pack expansion (test_language_pack_cache): en-core-cog-085 → en-core-cog-091. 6. Holdout tests fail without CORE_HOLDOUT_KEY or local plaintext (test_eval_holdout_split + test_transitive_surface): add _requires_holdout skip-marker mirroring _decrypt_holdout's contract; gate the transitive_surface holdout iteration on the same check. 7. Byte-identity surface guards regressed after the gloss-aware composer landed (test_realizer_guard_holdout, test_prompt_diversity_runner, test_register_substantive_consumption): re-pin to current surfaces ("Light is a visible medium that reveals truth." replaces "Light is a source of revelation that makes things knowable.", etc.). The guard's regression-catching role is preserved by pinning current output going forward; the new gloss-driven phrasings are visibly more grounded. Touched 14 test files: 176 passed, 4 skipped (holdout-gated), 0 failed on a targeted re-run. No production code touched.	2026-05-23 11:04:55 -07:00
Shay	6207b5fd0e	feat(register): R1–R4 register pack subsystem — deterministic surface variation ... Introduces the presentation axis as a fourth pack class (sibling to identity / safety / ethics), orthogonal to the truth path. Same input + same packs + same register ⇒ bit-for-bit reproducible surface; varying any of the three ⇒ genuinely different output. No stochastic sampling. ADR-0068 (R1): RegisterPack frozen dataclass, loader, ratify script, seam test. - default_neutral_v1 ratified as null register. ADR-0069 (R2): realizer register parameter threaded through 9 composer entry points; RuntimeConfig.register_pack_id; three byte-identity invariants (A: None ≡ pre-R2 unregistered; B: None ≡ default_neutral_v1; C: trace_hash invariant under register). Amended to default-with-lint after 167-call-site scout: composers default to UNREGISTERED, AST lint enforces explicit register= at runtime call sites. ADR-0070 (R3): terse_v1 register, first non-neutral pack. realizer_overrides schema with known-keys allow-list (disclosure_domain_count ∈ {1,2,3}). build_pack_surface_candidate reads override with fail-soft clamp. New invariant register_invariant_grounding asserts grounding_source + trace_hash byte-identical across {None, neutral, terse}. ADR-0071 (R4): seeded surface variation via convivial_v1. chat/register_variation.py applies SHA-256-seeded marker selection from bounded discourse-marker buckets. ChatResponse.pre_decoration_surface routes truth-path surface to core/cognition/pipeline.py so trace_hash stays invariant under register (the load-bearing architectural fix — initially invariant C failed under convivial because decoration was leaking into trace_hash via response.surface). Empty-string marker entries now legitimate ("no marker this turn" is a valid seed pick). realizer_overrides schema widened with per_intent nested block (validated against IntentTag whitelist; wired but not exercised by convivial). Two new invariants: seeded_variation_replay_equivalence (fresh runtimes → byte-identical) and seeded_variation_turn_distinct (same prompt across turns → ≥2 distinct surfaces). ADR-0072 (R5, draft): telemetry + operator surface — TurnEvent gains register_id and register_variant_id, core chat --register flag, core demo register-tour. Status: Proposed; not yet implemented. Three ratified register packs ship: default_neutral_v1 (null), terse_v1 (disclosure_domain_count=1), convivial_v1 (3 openings × 3 closings). Verification: - 84 register tests pass + 1 documented skip - Curated lanes green: smoke 67, cognition 120+1s, teaching 17, packs 6, runtime 19, algebra 132 - Cognition eval byte-identical to pre-register baseline: public 100/100/91.7/100, holdout 100/100/83.3/100 - Full lane: 2608 passed, 4 skipped, 1 failed (pre-existing test_cli_demo.py "Combined Demo" → "Run Every Demo" rename, unrelated) Truth-path isolation: chat/register_variation.py is realizer-side; the seam test (tests/test_register_pack_seam.py) refuses imports of packs.register from intent classification, propagation, vault recall, trace hashing, and algebra.	2026-05-19 16:52:36 -07:00