core-labs/core - Forgejo: Beyond coding. We forge.

core-labs/core

Fork 0

Commit graph

Author	SHA1	Message	Date
Shay	d94ea7e2d1	fix(quarantine): cluster C — drain all 27 tests, QUARANTINE now empty Fixes span three subsystems: math parser / OOD generator: - Add OOD unit registry words (ingots, shards, crystals, …) to allowed_nouns so rename_unit variants parse cleanly - Add scarf/scarves and other -ves→-f irregulars to _PLURAL_IRREGULARS so _canonical_unit("scarf") → "scarves" (not "scarfs") - Add _IRREGULAR_SINGULAR dict to _singular() in ood_surface_generator so "scarves" → "scarf" for n=1 rendering; prevents "scarve" parse error eval lane drift: - cold_start_grounding public cases: update 4 expected_grounding_source values from "pack"/"oov" → "teaching" (cognition chains now cover truth/memory/recall for DEFINITION prompts) - gsm8k_math runner: handle fast-path graph=None (capacity/earnings solvers return is_admitted=True with selected_graph=None) - coverage probe report: regenerate committed JSON after parser fix raised admission_rate and changed per_case trace hashes - test_gsm8k_math_runner: add decoded_unarticulated / _rate to expected metrics key set test guards: - test_composed_surface + test_compound_walkthrough_eval_lanes: skip holdout-split tests when CORE_HOLDOUT_KEY unset (not a regression) - test_en_core_action_v1_pack: EXPECTED_TOTAL 26→27, issubset check, provenance in-check for pack that gained one inflected entry - test_relations_chains_v1: EXPECTED_CHAIN_IDS 7→21 after seed expansion conftest: QUARANTINE frozenset emptied — ratchet at zero.	2026-05-25 07:15:26 -07:00
Shay	c492014815	feat(adr-0062): composed teaching-grounded surface (chain-of-chains) Pre-ADR-0062, the teaching-grounded composer emitted exactly one reviewed chain per surface — "light reveals truth" — even when the corpus already contained an immediate follow-up "truth grounds knowledge". With 21 active chains after curriculum saturation v2, many grounded prompts had a corpus-ratified follow-up the composer silently dropped. ADR-0062 adds the composed composer + an opt-in config flag: flag OFF (default): light — teaching-grounded (cognition_chains_v1): cognition.illumination; logos.core. light reveals truth (cognition.truth). No session evidence yet. flag ON: light — teaching-grounded (cognition_chains_v1): cognition.illumination; logos.core. light reveals truth (cognition.truth), which grounds knowledge (cognition.knowledge). No session evidence yet. Follow-up resolution: - prefer cause; fall back to verification (deterministic preference) - cycle guard: 1-step cycles (A→B, B→A) blocked - pack-residency guard: follow-up's object must be pack-resident - bounded depth: v1 follows exactly one hop - degrades to single-chain BYTE-IDENTICALLY when no follow-up survives the guards (drop-in replacement) Trust-boundary invariants preserved: - Every visible non-template token is lemma / pack-domain / humanize_predicate connective / template constant. Only added template constant: ", which " - Deterministic: same chains → same surface bytes - Default-False flag pattern mirrors ADR-0047/0058 - `versor_condition < 1e-6` invariant untouched (surface composition only) Cognition lane null-drop invariant CI-pinned: Composed mode emits a strictly LONGER surface (extra follow-up clause); every expected_term passing flag-OFF must still pass flag-ON. Asserted in test_cognition_lane_metrics_unchanged_with_composed_flag for both public and holdout splits. If a future change drops tokens, the test fails as a deliberate regression. public flag OFF: intent 100% / surface 100% / term 91.7% / versor 100% public flag ON : intent 100% / surface 100% / term 91.7% / versor 100% (identical) holdout flag OFF: intent 100% / surface 100% / term 83.3% / versor 100% holdout flag ON : intent 100% / surface 100% / term 83.3% / versor 100% (identical) Live-prompt lift visible on ~12 of 21 active chains; the rest hit cycle or pack-residency guards. Saturation v2's clusters were authored partly with composition in mind (thought→meaning→ understanding, inference→evidence→knowledge, etc.). - core/config.py — `RuntimeConfig.composed_surface: bool = False` - chat/teaching_grounding.py — `teaching_grounded_surface_composed` sibling to `teaching_grounded_surface` - chat/runtime.py — dispatch branch in `_maybe_pack_grounded_surface` selects composed vs single-chain based on config flag - tests/test_composed_surface.py — 11 tests pin: function-level (None on no chain / degrades when no follow-up / two-clause when follow-up exists / includes intermediate + final domains / deterministic / cycle guard / trust label preserved); runtime integration (default single-chain / flag-on composed / frozen config); cognition-lane null-drop invariant. Lanes (regression): smoke 67 / cognition 121 / teaching 17 / composed-surface 11 — all green.	2026-05-18 14:34:45 -07:00

Author

SHA1

Message

Date

Shay

d94ea7e2d1

fix(quarantine): cluster C — drain all 27 tests, QUARANTINE now empty

Fixes span three subsystems:

math parser / OOD generator:
- Add OOD unit registry words (ingots, shards, crystals, …) to
  allowed_nouns so rename_unit variants parse cleanly
- Add scarf/scarves and other -ves→-f irregulars to _PLURAL_IRREGULARS
  so _canonical_unit("scarf") → "scarves" (not "scarfs")
- Add _IRREGULAR_SINGULAR dict to _singular() in ood_surface_generator
  so "scarves" → "scarf" for n=1 rendering; prevents "scarve" parse error

eval lane drift:
- cold_start_grounding public cases: update 4 expected_grounding_source
  values from "pack"/"oov" → "teaching" (cognition chains now cover
  truth/memory/recall for DEFINITION prompts)
- gsm8k_math runner: handle fast-path graph=None (capacity/earnings
  solvers return is_admitted=True with selected_graph=None)
- coverage probe report: regenerate committed JSON after parser fix
  raised admission_rate and changed per_case trace hashes
- test_gsm8k_math_runner: add decoded_unarticulated / _rate to
  expected metrics key set

test guards:
- test_composed_surface + test_compound_walkthrough_eval_lanes: skip
  holdout-split tests when CORE_HOLDOUT_KEY unset (not a regression)
- test_en_core_action_v1_pack: EXPECTED_TOTAL 26→27, issubset check,
  provenance in-check for pack that gained one inflected entry
- test_relations_chains_v1: EXPECTED_CHAIN_IDS 7→21 after seed expansion

conftest: QUARANTINE frozenset emptied — ratchet at zero.

2026-05-25 07:15:26 -07:00

Shay

c492014815

feat(adr-0062): composed teaching-grounded surface (chain-of-chains)

Pre-ADR-0062, the teaching-grounded composer emitted exactly one
reviewed chain per surface — "light reveals truth" — even when the
corpus already contained an immediate follow-up "truth grounds
knowledge".  With 21 active chains after curriculum saturation v2,
many grounded prompts had a corpus-ratified follow-up the composer
silently dropped.

ADR-0062 adds the composed composer + an opt-in config flag:

  flag OFF (default):
    light — teaching-grounded (cognition_chains_v1): cognition.illumination;
    logos.core. light reveals truth (cognition.truth). No session evidence yet.

  flag ON:
    light — teaching-grounded (cognition_chains_v1): cognition.illumination;
    logos.core. light reveals truth (cognition.truth), which grounds
    knowledge (cognition.knowledge). No session evidence yet.

Follow-up resolution:
  - prefer cause; fall back to verification (deterministic preference)
  - cycle guard: 1-step cycles (A→B, B→A) blocked
  - pack-residency guard: follow-up's object must be pack-resident
  - bounded depth: v1 follows exactly one hop
  - degrades to single-chain BYTE-IDENTICALLY when no follow-up
    survives the guards (drop-in replacement)

Trust-boundary invariants preserved:
  - Every visible non-template token is lemma / pack-domain /
    humanize_predicate connective / template constant.  Only added
    template constant: ", which "
  - Deterministic: same chains → same surface bytes
  - Default-False flag pattern mirrors ADR-0047/0058
  - `versor_condition < 1e-6` invariant untouched (surface composition only)

Cognition lane null-drop invariant CI-pinned:
  Composed mode emits a strictly LONGER surface (extra follow-up
  clause); every expected_term passing flag-OFF must still pass flag-ON.
  Asserted in test_cognition_lane_metrics_unchanged_with_composed_flag
  for both public and holdout splits.  If a future change drops tokens,
  the test fails as a deliberate regression.

  public  flag OFF: intent 100% / surface 100% / term 91.7% / versor 100%
  public  flag ON : intent 100% / surface 100% / term 91.7% / versor 100% (identical)
  holdout flag OFF: intent 100% / surface 100% / term 83.3% / versor 100%
  holdout flag ON : intent 100% / surface 100% / term 83.3% / versor 100% (identical)

Live-prompt lift visible on ~12 of 21 active chains; the rest hit
cycle or pack-residency guards.  Saturation v2's clusters were
authored partly with composition in mind (thought→meaning→
understanding, inference→evidence→knowledge, etc.).

- core/config.py — `RuntimeConfig.composed_surface: bool = False`
- chat/teaching_grounding.py — `teaching_grounded_surface_composed`
  sibling to `teaching_grounded_surface`
- chat/runtime.py — dispatch branch in `_maybe_pack_grounded_surface`
  selects composed vs single-chain based on config flag
- tests/test_composed_surface.py — 11 tests pin: function-level
  (None on no chain / degrades when no follow-up / two-clause when
  follow-up exists / includes intermediate + final domains /
  deterministic / cycle guard / trust label preserved); runtime
  integration (default single-chain / flag-on composed / frozen
  config); cognition-lane null-drop invariant.

Lanes (regression): smoke 67 / cognition 121 / teaching 17 /
composed-surface 11 — all green.

2026-05-18 14:34:45 -07:00

2 commits