Commit graph

2 commits

Author SHA1 Message Date
Shay
8829529ed0
fix(W-025): polish contemplation-quality eval lane follow-ups (#290)
Three follow-ups raised in the W-025 PR #286 review, completed together so
the lane reaches its full mastery-level contract.

1. ``core eval`` failure-printer is now gated on ``lane_name == "cognition"``.
   Before this fix, every non-cognition lane that returned clean case_details
   without ``intent_correct``/``versor_closure`` keys triggered a spurious
   ``failures (N): <case_id>: intent, versor=0.00e+00`` block at the end of
   the human-readable output, even when every metric passed.  This matched
   the gating pattern already used for the workers preamble at the top of
   ``cmd_eval``.

2. EPILOG examples in ``core/cli.py`` now advertise
   ``core eval contemplation_quality`` and the ``--json --save`` form, so
   the lane is discoverable from ``core --help`` and not only from
   ``core eval --list``.

3. Tightened the learning-arc demo's Scene 5 to thread the demo's
   tempdir-scoped ``engine_state_dir`` into the second ``ChatRuntime``.
   The previous default-constructed runtime checkpointed to the repo's
   ``engine_state/``, which contradicted ADR-0159's read-only claim.
   ADR-0146/0150 still govern the runtime checkpoint path itself.

Tests:

- ``tests/test_contemplation_quality_lane.py`` (35 tests):
  case-set integrity, lane discovery, ``evaluate_report`` purity over
  well-formed / malformed / boundary-violating inputs, ``run_lane``
  invocation-contract enforcement (single case, supported source enum),
  and a read-only invariant snapshot on ``teaching/corpora``, ``packs/``,
  and ``language_packs/data/``.

- ``tests/test_eval_cli_failure_printer.py`` (4 tests): pins the
  cognition-only gating of the failure printer with stubbed
  ``evals.framework`` so the regression cannot return as a lane-blind
  condition.

Validation:

  uv run pytest tests/test_contemplation_quality_lane.py \
                tests/test_eval_cli_failure_printer.py \
                tests/test_learning_arc_demo.py -q   # 50 passed
  uv run core test --suite smoke -q                  # 67 passed
  uv run core eval contemplation_quality              # 9/9 passed, clean output
2026-05-26 09:39:18 -07:00
Shay
e7e28a2fd5
feat(W-019): learning-arc demo — engine-authored proposal from contemplation (ADR-0152) (#276)
Two-session arc where engine derives connective+object from corpus
decomposition; operator ratifies rather than authors. Distinguishes
from learning-loop (operator-authored) and directly exercises W-018
checkpoint contemplation and W-017 auto-proposal provenance path.
2026-05-25 13:03:10 -07:00