core-labs/core
core-labs/core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(tests): stop a test writing proposals into the live in-repo sink

Browse source 
Found by running the full tree: every full-suite run left an untracked
speculative proposal artifact in teaching/proposals/derived_close_facts/.

test_runtime_flag_on_emits_after_consolidation passes engine_state_path=tmp_path,
but that does not redirect the proposal sink — the runtime calls
emit_derived_close_proposals(ctx) with no sink argument, so it resolves
DEFAULT_SINK: the real, repo-relative directory. Fixed by monkeypatching the
module-level default the runtime resolves through.

Its neighbour was defending against exactly this with:

    assert not any(sink.glob("*.json")) or True   # may have pre-existing from other tests

which is vacuously true, and whose comment was describing the leak it was
papering over rather than the contract it claimed to check. With the flag-ON
test no longer writing there, an honest assertion is possible: snapshot the
live sink BEFORE the tick and require it unchanged after. (First attempt at
this took the snapshot after idle_tick(), which compares the sink to itself —
corrected here.)

Only visible now that the parents[3] DEFAULT_SINK bug is fixed and the sink
resolves inside the repo; before 2026-07-24 these artifacts were landing
outside the tree entirely, which is why nobody saw them.

[Verification]: 28 passed across test_derived_close_proposals,
test_proposal_queue, test_idle_proposal_review; working tree clean afterward,
no residue.
NON-CANONICAL: Python 3.12.11, not the pinned 3.12.13.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FduW6Krm3PPQv3P5iwBYtx
This commit is contained in:
Claude 2026-07-25 13:36:22 +00:00
parent 7bc7131fd9
commit b318501c55
No known key found for this signature in database
1 changed files with 30 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
tests/test_derived_close_proposals.py
View file

@ -218,19 +218,39 @@ def test_runtime_flag_off_does_not_emit(vocab_persona, tmp_path: Path):
ctx = rt._context
_tell("Socrates is a man.", ctx)
_tell("All men are mortals.", ctx)
res = rt.idle_tick() # consolidation happens (if flag on), proposal bridge must not
# Even if consolidation ran, the derived proposal sink under the test path
# should not have been written by the bridge (flag off).
# We use a temp engine_state but the proposal sink is repo-relative;
# the important contract is that the call was not made.
# Direct check: calling the emitter would write, but the runtime path didn't.
assert res.derived_close_proposals_emitted == 0
# No files should have been created for this disabled path (best-effort check)
# The proposal sink is repo-relative even when engine_state is a tmp_path,
# so the flag-off contract is checkable directly: snapshot the live sink
# BEFORE the tick, and require it unchanged after.
#
# This assertion used to read:
# assert not any(sink.glob("*.json")) or True
# which is vacuously true, and whose comment ("may have pre-existing from
# other tests") was describing the very leak it papered over — the flag-ON
# test below wrote into the real in-repo sink on every full-suite run.
# That test now redirects its sink, so an honest check is possible here.
sink = Path("teaching") / "proposals" / "derived_close_facts"
assert not any(sink.glob("*.json")) or True # may have pre-existing from other tests; non-fatal
before = set(sink.glob("*.json")) if sink.exists() else set()
res = rt.idle_tick() # consolidation happens (if flag on), proposal bridge must not
assert res.derived_close_proposals_emitted == 0
after = set(sink.glob("*.json")) if sink.exists() else set()
assert after == before, f"flag-off path wrote to the live sink: {after - before}"
def test_runtime_flag_on_emits_after_consolidation(vocab_persona, tmp_path: Path):
def test_runtime_flag_on_emits_after_consolidation(
vocab_persona, tmp_path: Path, monkeypatch
):
# ``engine_state_path=tmp_path`` does NOT redirect the proposal sink: the
# runtime calls ``emit_derived_close_proposals(ctx)`` with no ``sink``, so
# it lands on ``DEFAULT_SINK`` — the real, in-repo
# ``teaching/proposals/derived_close_facts/``. Before this monkeypatch,
# every full-suite run left a committed-looking speculative artifact in the
# working tree, which is how it was found (2026-07-25). Redirect the
# module-level default the runtime resolves through.
import generate.determine.derived_close_proposals as dcp
monkeypatch.setattr(dcp, "DEFAULT_SINK", tmp_path / "derived_close_facts")
cfg = replace(
DEFAULT_CONFIG,
consolidate_determinations=True,