core-labs/core
core-labs/core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(derivation): require integer peer-pick friend counts

Browse source
This commit is contained in:
Shay 2026-06-17 19:49:03 -07:00
parent 1110da565a
commit 8db5321f2f
2 changed files with 32 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
generate/math_candidate_parser.py
View file

@ -3088,7 +3088,13 @@ def _resolve_question_entity(
def _infer_peer_pick_partition( def _infer_peer_pick_partition(
problem_text: str | None, question_entity: str problem_text: str | None, question_entity: str
) -> tuple[int, str, str] | None: ) -> tuple[int, str, str] | None:
"""Infer peer friend-count from the conditional clause in ``problem_text``.""" """Infer peer friend-count from the conditional clause in ``problem_text``.
Gate A2d's peer count is a count of people, not a general numeric value.
The regex shares ``_VALUE`` for local parser consistency, but admission is
narrower: only positive integer, unitless counts are allowed. Money,
slash-fraction, decimal, and other non-integer numeric surfaces refuse.
"""
if problem_text is None: if problem_text is None:
return None return None
m = _PEER_PICK_CONDITIONAL_RE.search(problem_text) m = _PEER_PICK_CONDITIONAL_RE.search(problem_text)
@ -3098,12 +3104,15 @@ def _infer_peer_pick_partition(
if entity != _normalize_entity(question_entity): if entity != _normalize_entity(question_entity):
return None return None
count_token = m.group("count") count_token = m.group("count")
if count_token.startswith(("$", "¢", "€", "£", "¥", "₱")) or "/" in count_token:
return None
resolved = _resolve_value(count_token) resolved = _resolve_value(count_token)
if resolved is None: if resolved is None:
return None return None
peer_count = int(resolved.value) value = resolved.value
if peer_count <= 0: if value <= 0 or value != int(value):
return None return None
peer_count = int(value)
return peer_count, count_token, entity return peer_count, count_token, entity

20
tests/test_math_candidate_graph_peer_partition_question.py
View file

@ -104,6 +104,26 @@ def test_confuser_friends_without_count_refuses():
assert res.answer is None assert res.answer is None
def test_confuser_fractional_friend_count_refuses():
text = (
"Lilibeth fills 6 baskets where each basket holds 50 strawberries. "
"If 3/2 of Lilibeth's friends pick the same amount as her, "
"how many strawberries do Lilibeth and her friends pick in all?"
)
res = _run(text)
assert res.answer is None
def test_confuser_money_friend_count_refuses():
text = (
"Lilibeth fills 6 baskets where each basket holds 50 strawberries. "
"If $2 of Lilibeth's friends pick the same amount as her, "
"how many strawberries do Lilibeth and her friends pick in all?"
)
res = _run(text)
assert res.answer is None
def test_comparative_question_still_refuses(): def test_comparative_question_still_refuses():
text = ( text = (
"Francine has five full boxes of crayons and 5 loose crayons, " "Francine has five full boxes of crayons and 5 loose crayons, "