core-labs/core
core-labs/core
1
0
Fork 0
Code Issues 11 Pull requests 2 Projects Releases Packages Wiki Activity Actions

test(adr-0157): patch get_git_revision (the seam load_manifest actually calls)

Browse source 
A refactor split the revision helper into public get_git_revision() with
_git_revision() as a backward-compat alias, and pointed load_manifest() at
get_git_revision(). The revision-mismatch tests still patched _git_revision,
so the patch was a no-op and load_manifest read the real HEAD SHA — emitting
(or suppressing) warnings against the wrong 'current' revision. Patch the
function load_manifest calls. Feature unchanged; only the test seam was stale.
(The reboot path in chat/runtime.py still uses _git_revision, tested by
test_adr_0158 — left as-is.)
This commit is contained in:
Shay 2026-06-03 01:59:05 -07:00
parent 6d62ac2f24
commit 6ea52f8af0
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/test_adr_0157_revision_mismatch_warning.py
View file

@ -32,7 +32,7 @@ def test_matching_revision_emits_no_warning(tmp_path) -> None:
_write_manifest(tmp_path, revision="abc123def456")
store = EngineStateStore(tmp_path)
with patch("engine_state._git_revision", return_value="abc123def456"):
with patch("engine_state.get_git_revision", return_value="abc123def456"):
with warnings.catch_warnings():
warnings.simplefilter("error", RuntimeWarning)
manifest = store.load_manifest()
@ -45,7 +45,7 @@ def test_mismatched_revision_emits_runtime_warning(tmp_path) -> None:
_write_manifest(tmp_path, revision="oldrevisionabc")
store = EngineStateStore(tmp_path)
with patch("engine_state._git_revision", return_value="newrevisionxyz"):
with patch("engine_state.get_git_revision", return_value="newrevisionxyz"):
with pytest.warns(RuntimeWarning, match="oldrevisionabc"):
manifest = store.load_manifest()
@ -56,7 +56,7 @@ def test_warning_message_contains_both_revisions(tmp_path) -> None:
_write_manifest(tmp_path, revision="stored000000")
store = EngineStateStore(tmp_path)
with patch("engine_state._git_revision", return_value="current11111"):
with patch("engine_state.get_git_revision", return_value="current11111"):
with pytest.warns(RuntimeWarning) as record:
store.load_manifest()
@ -70,7 +70,7 @@ def test_manifest_returned_intact_despite_mismatch(tmp_path) -> None:
_write_manifest(tmp_path, revision="old", turn_count=42)
store = EngineStateStore(tmp_path)
with patch("engine_state._git_revision", return_value="new"):
with patch("engine_state.get_git_revision", return_value="new"):
with pytest.warns(RuntimeWarning):
manifest = store.load_manifest()
@ -84,7 +84,7 @@ def test_stored_unknown_revision_suppresses_warning(tmp_path) -> None:
_write_manifest(tmp_path, revision="unknown")
store = EngineStateStore(tmp_path)
with patch("engine_state._git_revision", return_value="abc123"):
with patch("engine_state.get_git_revision", return_value="abc123"):
with warnings.catch_warnings():
warnings.simplefilter("error", RuntimeWarning)
manifest = store.load_manifest()
@ -96,7 +96,7 @@ def test_current_unknown_revision_suppresses_warning(tmp_path) -> None:
_write_manifest(tmp_path, revision="abc123def456")
store = EngineStateStore(tmp_path)
with patch("engine_state._git_revision", return_value="unknown"):
with patch("engine_state.get_git_revision", return_value="unknown"):
with warnings.catch_warnings():
warnings.simplefilter("error", RuntimeWarning)
manifest = store.load_manifest()