core-labs/core
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: use rotors instead of reflectors in session coherence test (#22)

Browse source 
_farther_unrelated searched for grade-1 reflectors whose cga_inner
score was below the prompt score. Field states are even-grade
(grade 0+2+4), so cga_inner with a grade-1 reflector is always zero
— making the search impossible when prompt_score is negative.

Replaced with _random_rotor (product of two reflectors) which lives
in the same even-grade subspace and produces nonzero inner products.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Shay 2026-05-14 20:24:25 -07:00 committed by GitHub
parent 58a06124bf
commit 364e1fdd34
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/test_session_coherence.py
View file

@ -25,6 +25,19 @@ def _positive_unit_reflector(seed: int) -> np.ndarray:
return unitize_versor(mv)
def _random_rotor(seed: int) -> np.ndarray:
"""Build a random even-grade versor (rotor) for CGA inner-product comparison.
Field states are even-grade (grade 0+2+4). Reflectors are grade-1 and
orthogonal under cga_inner, so we need rotors to get nonzero scores.
"""
a = _positive_unit_reflector(seed)
b = _positive_unit_reflector(seed + 10000)
from algebra.cl41 import geometric_product as gp
rotor = gp(a, b)
return unitize_versor(rotor)
def _vocab() -> VocabManifold:
vocab = VocabManifold()
vocab.add("logos", _positive_unit_reflector(1))
@ -37,8 +50,8 @@ def _vocab() -> VocabManifold:
def _farther_unrelated(result_F: np.ndarray, prompt_F: np.ndarray, start_seed: int) -> np.ndarray:
prompt_score = cga_inner(result_F, prompt_F)
for seed in range(start_seed, start_seed + 256):
candidate = _positive_unit_reflector(seed)
for seed in range(start_seed, start_seed + 2048):
candidate = _random_rotor(seed)
if prompt_score > cga_inner(result_F, candidate):
return candidate
raise AssertionError("Could not construct a deterministic farther unrelated versor.")