core-labs/core
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix(workbench-ui): simplify practice evidence panel typing

Browse source
This commit is contained in:
Shay 2026-06-23 16:22:46 -07:00
parent 0aa217f917
commit 22c6aa4411
1 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
workbench-ui/src/app/trace/PracticeEvidencePanel.tsx
View file

@ -19,6 +19,10 @@ export interface PracticeEvidencePanelProps {
errorMessage: (error: unknown) => string;
}
function rowValue(value: string) {
return value;
}
function DetailSection({ section }: { section: PracticeEvidenceDetailSection }) {
return (
<section className="grid gap-2 rounded-md border border-[var(--color-border-subtle)] p-3">
@ -37,7 +41,7 @@ function DetailSection({ section }: { section: PracticeEvidenceDetailSection })
<MetadataTable
rows={item.rows.map((row) => ({
key: row.key,
value: row.value,
value: rowValue(row.value),
mono: true,
}))}
/>
@ -61,10 +65,6 @@ export function PracticeEvidencePanel({
() => (evidence ? JSON.stringify(evidence, null, 2) : ""),
[evidence],
);
const model = useMemo(
() => (evidence ? practiceEvidencePanelModel(evidence) : null),
[evidence],
);
if (isLoading) {
return <LoadingState label="Loading sealed practice evidence..." />;
@ -79,7 +79,7 @@ export function PracticeEvidencePanel({
/>
);
}
if (!evidence || model === null) {
if (!evidence) {
return (
<EmptyState
statement="No sealed practice evidence recorded for this turn."
@ -88,6 +88,7 @@ export function PracticeEvidencePanel({
);
}
const model = practiceEvidencePanelModel(evidence);
return (
<section className="grid gap-3" data-testid="practice-evidence-panel">
{model.emptyMessage ? (
@ -101,14 +102,14 @@ export function PracticeEvidencePanel({
<MetadataTable
rows={model.authorityRows.map((row) => ({
key: row.key,
value: row.value,
value: rowValue(row.value),
mono: true,
}))}
/>
<MetadataTable
rows={model.countRows.map((row) => ({
key: row.key,
value: row.value,
value: rowValue(row.value),
mono: true,
}))}
/>
@ -118,7 +119,7 @@ export function PracticeEvidencePanel({
<MetadataTable
rows={model.chainRows.map((row) => ({
key: row.key,
value: row.value,
value: rowValue(row.value),
mono: true,
}))}
/>
@ -138,7 +139,7 @@ export function PracticeEvidencePanel({
<MetadataTable
rows={model.sourceSpanRows.map((row) => ({
key: row.key,
value: row.value,
value: rowValue(row.value),
mono: true,
}))}
/>