core-labs/core
1
0
Fork 0
Code Issues 12 Pull requests 2 Projects Releases Packages Wiki Activity Actions

refactor: consolidate duplicate depth extraction — graph_planner.get_node_depths now delegates to build_node_depths (single source)

Browse source 
Addresses MEDIUM from code-review: eliminates duplication risk between GraphNode method and pure canonical func.
Tests (graph_anti / node_depths) remain green.
This commit is contained in:
Shay 2026-07-08 07:21:17 -07:00
parent 3d08e10357
commit 05348e5a79
1 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
generate/graph_planner.py
View file

@ -107,20 +107,13 @@ class PropositionGraph:
def get_node_depths(self) -> dict[str, dict]:
"""Return nid -> {language, root, morphology_id} for nodes carrying 3-lang depth.
Pure extraction. Enables graph-level consumers (anti-unif, framing, realizer)
Delegates to the canonical pure extractor in recognition.depth_canonical
(single source of truth; avoids duplication with build_node_depths).
Enables graph-level consumers (anti-unif, framing, realizer)
to operate on root forms for he/grc without string hacks.
"""
return {
n.node_id: {
k: v for k, v in {
"language": n.language,
"root": n.root,
"morphology_id": n.morphology_id,
}.items() if v is not None
}
for n in self.nodes
if n.language or n.root or n.morphology_id
}
from recognition.depth_canonical import build_node_depths
return build_node_depths(self.nodes)
def topo_order(self) -> tuple[str, ...]:
"""Kahn's topological sort over the graph's edges.